From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6BEAA0C49; Wed, 12 May 2021 01:35:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F9234003F; Wed, 12 May 2021 01:35:18 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A6A594003E; Wed, 12 May 2021 01:35:17 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F3BD95C0165; Tue, 11 May 2021 19:35:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 11 May 2021 19:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= TYnIs+RlYOFChQkUxuHQAS3i02m8WIWaCi78bt6KxS4=; b=PcmH8Qd8HyBA7HjM 5HI8x4K7Esk8N3rIQQMJ/vacrc2RCJIhnI7FqLMFqI6PIj86EnTN1MhN6oulWzLD sgmHAk8JZ9YLDzT50aIxNbOaywzAIdp49biDTHenW+FJheqOcjyBZ5237wF/jyO3 YbnPuQ3v6rmLNSieLKWdr6qmyAlQXHhySDM0QXAmOPGAoM7DQ27kKkmBb+dZLwGz UjXlWWlkkTAiJPlyA0Hu6n3k0WhDCCBKmHB6vf+eRi3wgVLAuF3hnockOAzZd970 srDySVdv6Aw5SExK93krvgBTK5ulDxg6wDkKRwlwk5nEROvPjmlokX40kQD8CzZr +rRWsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TYnIs+RlYOFChQkUxuHQAS3i02m8WIWaCi78bt6Kx S4=; b=lXJCMnzI48zmNrng7XYZ7Bm6tiCMLvqyH3huRbgrz74kKJe2Gg8Oq3Qy0 QoC0/mYMc9MivnT4xG96zeBw2Ci4d/P2AKwEo7G/aBenrdbOypnYJ2sS6VyuiMH0 a44LNIw924IiOWH+x8NEWephFHRg/Dtz0yHM3WmUm9FiUBRMT/XoXl7jNRX7lPTV 1VGwnoijsZvU/BlVFS61kq1c5QltDbWXcZuE/1wc+QWEkJCulgxM5PRLcc6mPWTG FKNlunshiwGmL0OZQQtZ6xYpqJS/uXtkojuwI28BSr2ostEeZVouQapxFTwSPvIv ThtJh3uVvR0UiK834MgmlSuPEVK/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehuddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 19:35:14 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: Dmitry Kozlyuk , stable@dpdk.org, dev@dpdk.org, Bruce Richardson , John McNamara Date: Wed, 12 May 2021 01:35:12 +0200 Message-ID: <8146889.VriENkGL5R@thomas> In-Reply-To: <20210511223435.GA4881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210502025656.29910-1-dmitry.kozliuk@gmail.com> <2280101.VUMvbZbiro@thomas> <20210511223435.GA4881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/05/2021 00:34, Tyler Retzlaff: > On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote: > > 06/05/2021 00:45, Tyler Retzlaff: > > > as a side question, what is the projects stance on getting more warnings > > > clean? there are a few not enabled that i'd really like to see e.g. > > > format, conversion, truncation etc.. > > > > > > i looked at lib/eal previously and there are... hundreds? of instances so > > > it's a non-trivial task. the problem i see is somehow getting to a > > > warnings clean state where we can enable -Werror in the CI pipeline but > > > at the same time figuring out how to prevent new instances from > > > appearing until we do. > > > > I don't understand the question. > > We are already supposed to be warning-free, > > and -werror should be enabled in all CI labs. > > What are the gaps? > > with the warnings we have enabled -Werror passes, but we don't have all > the warnings we could have that are of value. it would be great to see > -Wconversion -Wsign-compare -Wsign-conversion passing clean. > > i admit it is a lot of work though. -Wsign-compare is enabled for sure, look at config/meson.build. For the conversion warnings, I don't know. Do not hesitate to propose new warnings enablement with a list of warnings it is generating in its current state, so we can decide whether to enable (and fix) or not.