From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8E0E8293B for ; Mon, 13 May 2019 19:00:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 10:00:09 -0700 X-ExtLoop1: 1 Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.36]) ([10.237.221.36]) by orsmga002.jf.intel.com with ESMTP; 13 May 2019 10:00:07 -0700 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Stephen Hemminger Cc: Olivier Matz , thomas@monjalon.net, arybchenko@solarflare.com, dev@dpdk.org References: <1557509654-19325-1-git-send-email-mb@smartsharesystems.com> <20190513115439.5fjarh6au7u64fmq@platinum> <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> <20190513074708.775d0559@hermes.lan> <98CBD80474FA8B44BF855DF32C47DC35B4284A@smartserver.smartshare.dk> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJcYUAgBQkIaWtQAAoJEPkz60Pf E2EfV3QP/1LjjnY73PZsQuZHcboWvTs7Us4yifgMLlMlU6kJ5zPHN27pg955CSte5pdv8RAl kbo/ycq73dmmYpBb6F1dnh2ORnjKzRI/ix7fpN6HYE81M+jentgXhQF5VfsnR3MYx2MhhrI+ PpmgxkkLJ+oOlwn8WVC/2PAJQYhDy8CLHhYyTT0Qpta0Nk2Ce0AI31seDwQGJ7xZj/Gihzry jSR2ISEMOVH8pBtSsTjPtdzRDkeTr3tjIbMuenLT9h8GDQLU80yZmBC+s/oeiFIvl/t2wFbu M2ytl6ljq4GQ9TWdLxCPZnB7umaZol8/gFRmtd9GyPdaF3x290hTYqGAgAc8W43aSRbw9kcM MX3toHGuOa+zd2rjr8T9LDjqzhN6a2LEKwJa67NczSBlcv4/LcA5I9/GZN+NVTguCxU0MtKR 1HCCO/VGijKRtGr1tY3WoBos1eqeleG9fLRc3+c/Ceo5wfuJuzj1wZmJy+SDrJcr6MeHCcgV FXYPUoOlF2tIbmIiGJiMgvSRpseTN2taNHuu5I9RddnC9LuLBMyV1XD1HX/gwPZYbHUtKh5d MwXkJf/OqcXRqZk/wiJlB6m2B/83iHHBaK42wF/IWmLL5BuMzfmbqT0/QkyXv5uNUgOosz0u 3UsjocXObS2syEyZmkpOZYYzDYG7q5pqHeEJTDpG13RLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlxhQFUFCQZsJxcACgkQ+TPrQ98TYR9vdBAAt3o0kI8GKynIgDSmOSu1oE9CBu2CjImo FWwicZokFqABWKVxQuJ9E9/VIertxkkEo1QAn2/bhGBAtJ8Qtqd+SUZVXiZTnUn0+zbpYF10 Wt/pDhGIoe38USZS0wU6TMTBrRqI6BR1w9euCg2L3w2/a758vDpKLidCJctAPKTzI2RRTx8m 20MM3SjxxKwxSoWnQmbrJMvLqWcfJ00k44nxh48s/X8+ywuKbJoh8ZXyy7ZCWKCXePJ1DaMW QQy3E19BpgVswZjYsAji71VnY4Mwebilj6lJx1sCTgQavtvVRI6swDCQlfhmnw21tq+6YfiW GayFyOLzhEr6yTTb0U+LXK8A+gcHgkeD62JmVdrOToFuq7i+CYDZZlCmnu0S+EDku5TDACca jrfa/XxNrwOS5MQz9VjyYbj9exGpKnk7jFsoLnG5VzpXkXjEZZen0lwGKZRDHuG2P4jR9dH0 cXr9AOvnF/lQAJHcGdMX9wPZcgdTCMHboBU9I0gbZiicvkiuyaT+OAO9MYkIp2mfpAV92BcP TyLaLSDgrgj/Bjhwunrm4qm27RI6pNoBtIlGGDW8t0yMlQ8ykNK3AGpGD7wVm0iKPl9GzCqA qU+n3U/KO6lgw4Xa4/FHkEbZi5jQto5GwfKKsmrN/mhzV7JtihZGunscbB0ZiDbyGLB1YXu6 34s= Message-ID: <81579a34-1685-ce1a-f16f-fa0faed3706f@intel.com> Date: Mon, 13 May 2019 18:00:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B4284A@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 17:00:11 -0000 On 5/13/2019 4:15 PM, Morten Brørup wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger >> Sent: Monday, May 13, 2019 4:47 PM >> To: Morten Brørup >> Cc: Olivier Matz; thomas@monjalon.net; ferruh.yigit@intel.com; >> arybchenko@solarflare.com; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h >> instead of in rte_eth_ctrl.h >> >> On Mon, 13 May 2019 15:02:57 +0200 >> Morten Brørup wrote: >> >>>> >>>> IMHO, adding the copyright for flags move is a bit overkill. >>> >>> I also added the two ECN flags and descriptions of all the flags. And >> removed the misleading ALL flag. >>> >>> I don't know the formal or customary threshold criteria for adding a >> copyright notice, so I just added it. It's our first direct contribution >> where we didn't just send the corrections to another contributor, so I >> thought it would be nice to have our name in here. You're the maintainer, >> so I'll leave the final decision up to you. >> >> Most projects including DPDK do not add additional copyrights unless it >> is a complete rewrite. Please don't clutter the code with this stuff. > > That's a quite clear threshold definition, and my modifications clearly don't fall into this category. I think in the past threshold has been mentioned as "significant contribution", although this is kind of vague, it sounds lighter than "complete rewrite", anyway I agree for this patch it looks overkill to claim the copyright. > > Med venlig hilsen / kind regards > - Morten Brørup > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8C903A00E6 for ; Mon, 13 May 2019 19:00:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C0CE2BC1; Mon, 13 May 2019 19:00:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8E0E8293B for ; Mon, 13 May 2019 19:00:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 10:00:09 -0700 X-ExtLoop1: 1 Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.36]) ([10.237.221.36]) by orsmga002.jf.intel.com with ESMTP; 13 May 2019 10:00:07 -0700 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Stephen Hemminger Cc: Olivier Matz , thomas@monjalon.net, arybchenko@solarflare.com, dev@dpdk.org References: <1557509654-19325-1-git-send-email-mb@smartsharesystems.com> <20190513115439.5fjarh6au7u64fmq@platinum> <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> <20190513074708.775d0559@hermes.lan> <98CBD80474FA8B44BF855DF32C47DC35B4284A@smartserver.smartshare.dk> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJcYUAgBQkIaWtQAAoJEPkz60Pf E2EfV3QP/1LjjnY73PZsQuZHcboWvTs7Us4yifgMLlMlU6kJ5zPHN27pg955CSte5pdv8RAl kbo/ycq73dmmYpBb6F1dnh2ORnjKzRI/ix7fpN6HYE81M+jentgXhQF5VfsnR3MYx2MhhrI+ PpmgxkkLJ+oOlwn8WVC/2PAJQYhDy8CLHhYyTT0Qpta0Nk2Ce0AI31seDwQGJ7xZj/Gihzry jSR2ISEMOVH8pBtSsTjPtdzRDkeTr3tjIbMuenLT9h8GDQLU80yZmBC+s/oeiFIvl/t2wFbu M2ytl6ljq4GQ9TWdLxCPZnB7umaZol8/gFRmtd9GyPdaF3x290hTYqGAgAc8W43aSRbw9kcM MX3toHGuOa+zd2rjr8T9LDjqzhN6a2LEKwJa67NczSBlcv4/LcA5I9/GZN+NVTguCxU0MtKR 1HCCO/VGijKRtGr1tY3WoBos1eqeleG9fLRc3+c/Ceo5wfuJuzj1wZmJy+SDrJcr6MeHCcgV FXYPUoOlF2tIbmIiGJiMgvSRpseTN2taNHuu5I9RddnC9LuLBMyV1XD1HX/gwPZYbHUtKh5d MwXkJf/OqcXRqZk/wiJlB6m2B/83iHHBaK42wF/IWmLL5BuMzfmbqT0/QkyXv5uNUgOosz0u 3UsjocXObS2syEyZmkpOZYYzDYG7q5pqHeEJTDpG13RLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlxhQFUFCQZsJxcACgkQ+TPrQ98TYR9vdBAAt3o0kI8GKynIgDSmOSu1oE9CBu2CjImo FWwicZokFqABWKVxQuJ9E9/VIertxkkEo1QAn2/bhGBAtJ8Qtqd+SUZVXiZTnUn0+zbpYF10 Wt/pDhGIoe38USZS0wU6TMTBrRqI6BR1w9euCg2L3w2/a758vDpKLidCJctAPKTzI2RRTx8m 20MM3SjxxKwxSoWnQmbrJMvLqWcfJ00k44nxh48s/X8+ywuKbJoh8ZXyy7ZCWKCXePJ1DaMW QQy3E19BpgVswZjYsAji71VnY4Mwebilj6lJx1sCTgQavtvVRI6swDCQlfhmnw21tq+6YfiW GayFyOLzhEr6yTTb0U+LXK8A+gcHgkeD62JmVdrOToFuq7i+CYDZZlCmnu0S+EDku5TDACca jrfa/XxNrwOS5MQz9VjyYbj9exGpKnk7jFsoLnG5VzpXkXjEZZen0lwGKZRDHuG2P4jR9dH0 cXr9AOvnF/lQAJHcGdMX9wPZcgdTCMHboBU9I0gbZiicvkiuyaT+OAO9MYkIp2mfpAV92BcP TyLaLSDgrgj/Bjhwunrm4qm27RI6pNoBtIlGGDW8t0yMlQ8ykNK3AGpGD7wVm0iKPl9GzCqA qU+n3U/KO6lgw4Xa4/FHkEbZi5jQto5GwfKKsmrN/mhzV7JtihZGunscbB0ZiDbyGLB1YXu6 34s= Message-ID: <81579a34-1685-ce1a-f16f-fa0faed3706f@intel.com> Date: Mon, 13 May 2019 18:00:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B4284A@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513170007.vx3Px6mucvU9h58CmCoP6RohB8-uVb4N0MaON1wpMKs@z> On 5/13/2019 4:15 PM, Morten Brørup wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger >> Sent: Monday, May 13, 2019 4:47 PM >> To: Morten Brørup >> Cc: Olivier Matz; thomas@monjalon.net; ferruh.yigit@intel.com; >> arybchenko@solarflare.com; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h >> instead of in rte_eth_ctrl.h >> >> On Mon, 13 May 2019 15:02:57 +0200 >> Morten Brørup wrote: >> >>>> >>>> IMHO, adding the copyright for flags move is a bit overkill. >>> >>> I also added the two ECN flags and descriptions of all the flags. And >> removed the misleading ALL flag. >>> >>> I don't know the formal or customary threshold criteria for adding a >> copyright notice, so I just added it. It's our first direct contribution >> where we didn't just send the corrections to another contributor, so I >> thought it would be nice to have our name in here. You're the maintainer, >> so I'll leave the final decision up to you. >> >> Most projects including DPDK do not add additional copyrights unless it >> is a complete rewrite. Please don't clutter the code with this stuff. > > That's a quite clear threshold definition, and my modifications clearly don't fall into this category. I think in the past threshold has been mentioned as "significant contribution", although this is kind of vague, it sounds lighter than "complete rewrite", anyway I agree for this patch it looks overkill to claim the copyright. > > Med venlig hilsen / kind regards > - Morten Brørup >