From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ivan Malov <ivan.malov@oktetlabs.ru>, dev <dev@dpdk.org>,
Ori Kam <orika@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API
Date: Wed, 10 Nov 2021 14:21:13 +0000 [thread overview]
Message-ID: <815a9fc9-747f-46f8-c9cf-766fa71a9ecb@intel.com> (raw)
In-Reply-To: <CAJFAV8yPMCR-ax=1BiiYeuMwCxhAG5YWc8hQ6mYu+41vVhpQHw@mail.gmail.com>
On 11/2/2021 5:04 PM, David Marchand wrote:
> On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>>> IMHO, spamming of testpmd logs in described case should be fixed
>>>> in testpmd itself to avoid logs in the case of ENOTSUP. That's it.
>>>
>>> I think we should not call this API in testpmd
>>> if not doing rte_flow transfer rule.
>>>
>>
>> Since testpmd does not pursue top flow insertion rate etc,
>> I tend to agree. For debugging purposes (testpmd main goal)
>> the best way is to pick proxy just before usage without any
>> caching etc.
>
> +1.
>
+1 to not call this API when not doing rte_flow transfer rule,
and get rid of this testpmd logs..
next prev parent reply other threads:[~2021-11-10 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 9:00 Ivan Malov
2021-10-27 9:46 ` Thomas Monjalon
2021-10-27 9:55 ` Ivan Malov
2021-10-27 10:57 ` Thomas Monjalon
2021-10-28 16:24 ` Ivan Malov
2021-10-29 8:11 ` Thomas Monjalon
2021-11-01 9:41 ` Andrew Rybchenko
2021-11-02 15:45 ` Thomas Monjalon
2021-11-02 15:58 ` Andrew Rybchenko
2021-11-02 17:04 ` David Marchand
2021-11-10 14:21 ` Ferruh Yigit [this message]
2021-11-15 14:15 ` Ivan Malov
2021-11-15 15:09 ` Thomas Monjalon
2021-11-15 15:30 ` Ori Kam
2021-11-03 14:38 ` Ori Kam
2021-11-16 15:38 ` [PATCH] app/testpmd: fix flow transfer proxy port handling Ivan Malov
2021-11-16 19:23 ` Ori Kam
2021-11-17 7:41 ` Slava Ovsiienko
2021-11-17 10:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=815a9fc9-747f-46f8-c9cf-766fa71a9ecb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).