From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Remy Horton <remy.horton@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/3] malloc: allow reserving biggest element
Date: Mon, 14 May 2018 09:22:00 +0100 [thread overview]
Message-ID: <81764c64-fb1f-6230-3ec5-f36830d1f4eb@intel.com> (raw)
In-Reply-To: <cfe99755-703a-f170-c493-9d9e1c73b472@intel.com>
On 10-May-18 2:57 PM, Remy Horton wrote:
>
> On 03/05/2018 18:18, Anatoly Burakov wrote:
> [..]
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> [..]
>> + for (idx = 0; idx < RTE_HEAP_NUM_FREELISTS; idx++) {
>> + for (elem = LIST_FIRST(&heap->free_head[idx]);
>> + !!elem; elem = LIST_NEXT(elem, free_list)) {
>
> Why the double-negation?
>
> Otherwise, see no issues.
>
> Acked-by: Remy Horton <remy.horton@intel.com>
>
>
>
Presumably to make it a boolean value, not a pointer. This was written
before my time, didn't change it :)
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-05-14 8:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 14:10 [dpdk-dev] [PATCH 1/2] malloc: add biggest free IOVA-contiguous element to stats Anatoly Burakov
2018-04-25 14:10 ` [dpdk-dev] [PATCH 2/2] memzone: allow IOVA-contiguous memzones with zero size Anatoly Burakov
2018-04-25 14:40 ` [dpdk-dev] [PATCH 1/2] malloc: add biggest free IOVA-contiguous element to stats Burakov, Anatoly
2018-04-26 8:06 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2018-05-03 17:17 ` [dpdk-dev] [PATCH v3 0/3] Improve zero-length memzone allocation Anatoly Burakov
2018-05-14 11:19 ` [dpdk-dev] [PATCH v4 " Anatoly Burakov
2018-05-14 13:47 ` [dpdk-dev] [PATCH v5 " Anatoly Burakov
2018-05-31 9:50 ` [dpdk-dev] [PATCH v6 " Anatoly Burakov
2018-07-13 9:24 ` Thomas Monjalon
2018-05-31 9:50 ` [dpdk-dev] [PATCH v6 1/3] malloc: add finding biggest free IOVA-contiguous element Anatoly Burakov
2018-05-31 9:51 ` [dpdk-dev] [PATCH v6 2/3] malloc: allow reserving biggest element Anatoly Burakov
2018-05-31 9:51 ` [dpdk-dev] [PATCH v6 3/3] memzone: improve zero-length memzone reserve Anatoly Burakov
2018-05-14 13:47 ` [dpdk-dev] [PATCH v5 1/3] malloc: add biggest free IOVA-contiguous element to stats Anatoly Burakov
2018-05-14 13:58 ` Shreyansh Jain
2018-05-14 13:47 ` [dpdk-dev] [PATCH v5 2/3] malloc: allow reserving biggest element Anatoly Burakov
2018-05-14 13:47 ` [dpdk-dev] [PATCH v5 3/3] memzone: improve zero-length memzone reserve Anatoly Burakov
2018-05-14 11:19 ` [dpdk-dev] [PATCH v4 1/3] malloc: add biggest free IOVA-contiguous element to stats Anatoly Burakov
2018-05-14 11:19 ` [dpdk-dev] [PATCH v4 2/3] malloc: allow reserving biggest element Anatoly Burakov
2018-05-14 11:19 ` [dpdk-dev] [PATCH v4 3/3] memzone: improve zero-length memzone reserve Anatoly Burakov
2018-05-03 17:17 ` [dpdk-dev] [PATCH v3 1/3] malloc: add biggest free IOVA-contiguous element to stats Anatoly Burakov
2018-05-10 13:39 ` Remy Horton
2018-05-03 17:18 ` [dpdk-dev] [PATCH v3 2/3] malloc: allow reserving biggest element Anatoly Burakov
2018-05-10 13:57 ` Remy Horton
2018-05-14 8:22 ` Burakov, Anatoly [this message]
2018-05-03 17:18 ` [dpdk-dev] [PATCH v3 3/3] memzone: improve zero-length memzone reserve Anatoly Burakov
2018-05-11 10:25 ` Remy Horton
2018-05-14 8:21 ` Burakov, Anatoly
2018-05-14 11:29 ` Burakov, Anatoly
2018-05-14 12:23 ` Burakov, Anatoly
2018-05-15 6:24 ` Remy Horton
2018-05-15 8:37 ` Burakov, Anatoly
2018-04-26 8:06 ` [dpdk-dev] [PATCH v2 2/2] memzone: allow IOVA-contiguous memzones with zero size Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81764c64-fb1f-6230-3ec5-f36830d1f4eb@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).