From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C010C1BAFC for ; Mon, 14 May 2018 10:22:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 01:22:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,399,1520924400"; d="scan'208";a="54946098" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.6.248]) ([10.252.6.248]) by fmsmga001.fm.intel.com with ESMTP; 14 May 2018 01:22:01 -0700 To: Remy Horton , dev@dpdk.org References: <777ae6b10a7524e188c07ba14e576fc7b0e21018.1524729978.git.anatoly.burakov@intel.com> <7844071bf096c83cf2e92eb4bc759cf013ba47f0.1525366407.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <81764c64-fb1f-6230-3ec5-f36830d1f4eb@intel.com> Date: Mon, 14 May 2018 09:22:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/3] malloc: allow reserving biggest element X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 08:22:03 -0000 On 10-May-18 2:57 PM, Remy Horton wrote: > > On 03/05/2018 18:18, Anatoly Burakov wrote: > [..] >> Signed-off-by: Anatoly Burakov > > [..] >> +    for (idx = 0; idx < RTE_HEAP_NUM_FREELISTS; idx++) { >> +        for (elem = LIST_FIRST(&heap->free_head[idx]); >> +                !!elem; elem = LIST_NEXT(elem, free_list)) { > > Why the double-negation? > > Otherwise, see no issues. > > Acked-by: Remy Horton > > > Presumably to make it a boolean value, not a pointer. This was written before my time, didn't change it :) -- Thanks, Anatoly