From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 21F351E99F for ; Tue, 12 Jun 2018 15:07:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A440C21A57; Tue, 12 Jun 2018 09:07:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Jun 2018 09:07:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=vRTmCQ2zu7ZjlWV6/767yyOTaQ babvUDLj8EW1sHIMw=; b=fSeQfHCAaBvAx71zDMlTALeWDy5c0ae45KYaM/tp1t g1JewvFl2d7O2uYf9/DX7N959kFzaLcNRISZ9v8v6/qw6nOaHutwxC9Xd+EaYT10 L9yizGTkvDFdbCknLv+ZUj9MfZdRJiKungQ1dwiMDsWeIxEcl0M/PmLYBbdwlcPx k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=vRTmCQ 2zu7ZjlWV6/767yyOTaQbabvUDLj8EW1sHIMw=; b=MXYi68hjpX/hf/etI8UVd8 nshbhBPls8zKVIDRyhs6G/aZ1TnTATgiHTMraxmWY/NvDLVbyHryQdtKu80wX/bs RBECoLk+gvWyONPnbmbI9TQn/oOA21AWIGypwpfIfiTpqHWFgpWmn9tkhsYKDraP jwYUOV/4ZXjtOJx0bqZ0sqodqrbPcwRd60EMy4IIP5i6dW87cQVniwkoNUfslPxj ZOQ7NFR5JGw8c17PB3isniAcwgQW+xdObs4Dfkb8/Qu61fV0CVCeDhnqxHFVw5qZ yfUVverJKsUhG+gv3QlIupBawIqxsbGyq7pdgttBOt5jpapqQskTQjflvl+ivW2g == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C82D7102A2; Tue, 12 Jun 2018 09:07:24 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, john.mcnamara@intel.com, reshma.pattan@intel.com, bruce.richardson@intel.com, Jananee Parthasarathy Date: Tue, 12 Jun 2018 15:07:23 +0200 Message-ID: <8176896.7gnY6nVOUV@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/7] Make unit tests great again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 13:07:26 -0000 +Cc Jananee 07/06/2018 23:01, Anatoly Burakov: > Previously, unit tests were running in groups. There were > technical reasons why that was the case (mostly having to do > with limiting memory), but it was hard to maintain and update > the autotest script. > > In 18.05, limiting of memory at DPDK startup was no longer > necessary, as DPDK allocates memory at runtime as needed. This > has the implication that the old test grouping can now be > retired and replaced with a more sensible way of running unit > tests (using multiprocessing pool of workers and a queue of > tests). This patchset accomplishes exactly that. > > This patchset conflicts with some of the earlier work on > autotests [1] [2] [3], but i think it presents a cleaner > solution for some of the problems highlighted by those patch > series. I can integrate those patches into this series if > need be. > > [1] http://dpdk.org/dev/patchwork/patch/40370/ > [2] http://dpdk.org/dev/patchwork/patch/40371/ > [3] http://dpdk.org/dev/patchwork/patch/40372/ It may be interesting to work on lists of tests as done in the following patch: http://dpdk.org/dev/patchwork/patch/40373/ The idea is to split tests in several categories: - basic and short test - longer and lower priority - performance test As a long term solution, we can think about making category an attribute inside the test itself?