From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CD582A0562;
Sat, 17 Apr 2021 23:37:52 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4DE011618A4;
Sat, 17 Apr 2021 23:37:52 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 2DF1D4068F
for <dev@dpdk.org>; Sat, 17 Apr 2021 23:37:50 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 7F9DB5C0387;
Sat, 17 Apr 2021 17:37:49 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Sat, 17 Apr 2021 17:37:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
KrBzjhbz5Tc/TKJmaVCUPWsyQ64gXIl7x0c5rEYJqKs=; b=ovu1LFiAwjJit88Z
0A5lUgJFs5sJ9GaQfwrtxTAgS17ttTsuBH2t7XWRGm3SmABmqCF/E34Trxwv9jOT
C6jWby6Vtdy78/0Ww9Mxz1cqIZ4XigdW36eEUHyn+hFG5AclJ96XjZApE74iNezl
qSisHbbgH5KpyQnSnbkv70Q4HUk8LMYk8NhQOP0Y9ZrrUuyXOroF2NiDzvw9xAPy
pon3gi/hMsMGdHxL5UIigJUWKG7Lt02Ct55DHeJr0XWgrXBpP0WQAbmCBW6nI3Rn
7QNRVW+5gW9DF9tsnTOL6PitdVbW6wrlgVIueQ4u1yamF/NDwEbGbyFB6cFygsC/
7q3F0Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=KrBzjhbz5Tc/TKJmaVCUPWsyQ64gXIl7x0c5rEYJq
Ks=; b=UIXcHILW2yJWGbtnzIUQ1pldTCE5TWRSyYlIXClnl7cKt8oanPfCzcNAo
ylyxiiL2GJRdEGf1k6vTMROdD2DDvjU4OS8bQhtErxobfVFzytCDFsT6BhPAwuTe
ruSERLz5s5XpKiYV9TTlcFSbhxpfnAIlDO0c3IIcEq8Fil/V+CDnfuMbPu/Nms7S
32w5gpLNVvUlPoMPLdNjR2AeveVOIM7ilL4/M3GwlsSbpXWAITRsYMqdwhtpztlt
G2nhv7X4BeZa5t8cKVF5mNi/Og3ZyvOOuzyUXnZE9OlqgGw5K/qnzWCG8sFe8Ory
zmE/0v+s7opzIvcEhEC/L/VAY4JcA==
X-ME-Sender: <xms:K1V7YC2FWmkCcWqIlH6yDEHf_VEDzyyg_bHV-qWWA3WLbvr2u5NSkg>
<xme:K1V7YFE-o0I2Ul8z32qyzOH4YCBW9kFwG7uO5mhzEy-255JvO9iUge_g75z-W77fO
gN36-MFP0ltkAGLJg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeliedgvdelvdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev
uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:K1V7YK6mirHNX7dkrhfXTpKWY3lO5UW-hMEYL8JNkvbM5D_t2vcpZw>
<xmx:K1V7YD24FPtCPKJxoqyC9756F96RM4Urwkz63JysGPrr0UJH_MhJJg>
<xmx:K1V7YFEE2X-KtikgiQdAEVs8VRHobAcD_nFvdjE_bkGBomSJzIkMAA>
<xmx:LVV7YFBJ_bP705xkN99koVdUt3oqL-950f4CEi56p79arjG-u1CeRw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 3A296240054;
Sat, 17 Apr 2021 17:37:47 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org, ferruh.yigit@intel.com,
andrew.rybchenko@oktetlabs.ru
Date: Sat, 17 Apr 2021 23:37:45 +0200
Message-ID: <8177946.L7Sm5Rjx4H@thomas>
In-Reply-To: <5315cf0f-bf05-8e1d-9e68-e2b0a0017bd3@huawei.com>
References: <1618046334-39857-1-git-send-email-humin29@huawei.com>
<20210416092853.39a1517e@hermes.local>
<5315cf0f-bf05-8e1d-9e68-e2b0a0017bd3@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
17/04/2021 02:28, Min Hu (Connor):
>=20
> =E5=9C=A8 2021/4/17 0:28, Stephen Hemminger =E5=86=99=E9=81=93:
> > On Fri, 16 Apr 2021 11:22:02 +0100
> > Kevin Traynor <ktraynor@redhat.com> wrote:
> >=20
> >>> + if (dev_conf =3D=3D NULL) {
> >>> + RTE_ETHDEV_LOG(ERR,
> >>> + "Cannot configure ethdev port %u to NULL dev_conf\n",
> >>
> >> The others use a natural sounding names instead of argument name. If y=
ou
> >> wanted to match that it could be "..to NULL conf"
> >=20
> > I would prefer that error messages don't try to be English sentences.
> > The wording ends up awkward. and overly wordy.
> > If function name is automatically included by RTE_ETHDEV_LOG() then
> > Just:
> > RTE_ETHDEV_LOG(ERR, "NULL ethdev")
> > should be enough for programmer to find/fix the problem
> > .
> Hi, Stephen,
> Your opinion is quit different from that of Andrew Rybchenko.
> Andrew does not support show function name in the log:
> "- log messages should be human readable (i.e. I'd avoid
> usage of function name)"
>=20
> @Andrew ,@Thoms, @Ferruh, @Kevin, so, what's your opinion ?
I prefer human readable messages which are unique enough to be "grepped".