From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37AA2A0032; Fri, 22 Jul 2022 22:19:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD9C54021E; Fri, 22 Jul 2022 22:19:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DE4140156 for <dev@dpdk.org>; Fri, 22 Jul 2022 22:19:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658521178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2WlNQa4iMnFzBSc5+MrlL9doTqEFGd711MtY6lBqMbA=; b=daGdc9UOKTaYNEIzlOTkenc3UsRiVeHyOd1azOXrBnZwI5GS8hdgH2Jp51yQQ7/pv72juR OyKg4dpxNk9IFpj0gboVgUVO8su6GU1idDbsAe3KD0n2dmWcUgJHuHe1H6I2eNJlLlbUzi jBsYaZUsJiy1E3kASZXIW66FYOYs/MU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-wvtqwisBM9SU23l7jLUuxQ-1; Fri, 22 Jul 2022 16:19:37 -0400 X-MC-Unique: wvtqwisBM9SU23l7jLUuxQ-1 Received: by mail-qv1-f72.google.com with SMTP id ns1-20020a056214380100b00474050cf13aso3618439qvb.18 for <dev@dpdk.org>; Fri, 22 Jul 2022 13:19:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2WlNQa4iMnFzBSc5+MrlL9doTqEFGd711MtY6lBqMbA=; b=bxhwaKDH9A4yuKEkfR6+FirfHMA2aCPV1jwGViaShfp1rT1VUcfK4BfgIh+3w4JZkV wJOdQ649ZQTCyM3fhlGTK1uRTyJCvLwrzkv3goV0fEH8Bro+EHNuGEfT83dtgF5uwINQ nLFkjxbj5bloarWRMzL8h6+wuyNIy6J0dyhaxRNX9gcWggqHpmkaNlY4W5Lf3JSBxPfv zFCG2peYdbS3Ib+U1FiqhSAXF9G0rcu60JkTIDrT3V575FlTohD8YzK7Mvw673u+q9bY cowcJUlHYlOSFUm44T++PWMsWGtRdAMY7hPxo9dI1chv9xr01tmG6Swo5GaET27i0qBe risA== X-Gm-Message-State: AJIora8Eeiy4oWspVCm/dSG5ta+v6NwubRjxAOpnGJNsww6TsdFFVikp DN6ijC2hyZzxWlIGHXan4v32ujY+FGRqMFgsbrsJ90UaeYMXcV6GE2g/cHIq8EJBz2OWLl5DM5N 2Ft4= X-Received: by 2002:a05:6214:19cf:b0:474:147d:71b with SMTP id j15-20020a05621419cf00b00474147d071bmr1354204qvc.77.1658521177157; Fri, 22 Jul 2022 13:19:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uypJOEx9cxPhRhI9DBxoWFOcz5DGK41/Kww6z8Uyu2iTMDOB609TY4w7Zw1HXYymMnGazWUg== X-Received: by 2002:a05:6214:19cf:b0:474:147d:71b with SMTP id j15-20020a05621419cf00b00474147d071bmr1354186qvc.77.1658521176947; Fri, 22 Jul 2022 13:19:36 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id i67-20020a375446000000b006a6a6f148e6sm4003042qkb.17.2022.07.22.13.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 13:19:36 -0700 (PDT) Subject: Re: [PATCH v1 00/10] baseband/acc200 To: "Vargas, Hernan" <hernan.vargas@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, "Chautru, Nicolas" <nicolas.chautru@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "gakhil@marvell.com" <gakhil@marvell.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com> Cc: "mdr@ashroe.eu" <mdr@ashroe.eu>, "Richardson, Bruce" <bruce.richardson@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "stephen@networkplumber.org" <stephen@networkplumber.org> References: <1657238503-143836-1-git-send-email-nicolas.chautru@intel.com> <9087aa5a-6ba8-5df2-8a68-63926843ff7e@redhat.com> <DM6PR11MB366092B65D49CFCFDFE7D9A1EF889@DM6PR11MB3660.namprd11.prod.outlook.com> <067e2806-4c47-c897-0b71-84e5deb8a249@redhat.com> <DM6PR11MB3660AB4B0FB732CA274DFCA5EF909@DM6PR11MB3660.namprd11.prod.outlook.com> From: Tom Rix <trix@redhat.com> Message-ID: <819762f1-fd1f-9af3-e8db-97dab06aadc6@redhat.com> Date: Fri, 22 Jul 2022 13:19:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <DM6PR11MB3660AB4B0FB732CA274DFCA5EF909@DM6PR11MB3660.namprd11.prod.outlook.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hernan The changes I requested in v4, were not addressed in v5. Can you make these changes for v6? Tom On 7/22/22 11:29 AM, Vargas, Hernan wrote: > Hi Tom, > > The patch series for the ACC200 can wait until Nic's back. > Our priority are the changes for the bbdev API here: https://patches.dpdk.org/project/dpdk/list/?series=23912 > > Thanks, > Hernan > > -----Original Message----- > From: Tom Rix <trix@redhat.com> > Sent: Sunday, July 17, 2022 8:08 AM > To: Vargas, Hernan <hernan.vargas@intel.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org; thomas@monjalon.net; gakhil@marvell.com; hemant.agrawal@nxp.com > Cc: mdr@ashroe.eu; Richardson, Bruce <bruce.richardson@intel.com>; david.marchand@redhat.com; stephen@networkplumber.org > Subject: Re: [PATCH v1 00/10] baseband/acc200 > > > On 7/14/22 11:49 AM, Vargas, Hernan wrote: >> Hi Tom, Maxime, >> >> Could you please review the v5 series that Nic submitted last week? >> https://patches.dpdk.org/project/dpdk/list/?series=23912 >> >> Thanks, >> Hernan > Hernan, > > For this patch series for the acc200, will you be able to refactor it so acc has a common base ? > > Or will this be on hold until Nic is back ? > > Tom > >> >> -----Original Message----- >> From: Maxime Coquelin <maxime.coquelin@redhat.com> >> Sent: Tuesday, July 12, 2022 8:49 AM >> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org; >> thomas@monjalon.net; gakhil@marvell.com; hemant.agrawal@nxp.com; >> trix@redhat.com; Vargas, Hernan <hernan.vargas@intel.com> >> Cc: mdr@ashroe.eu; Richardson, Bruce <bruce.richardson@intel.com>; >> david.marchand@redhat.com; stephen@networkplumber.org >> Subject: Re: [PATCH v1 00/10] baseband/acc200 >> >> Hi Nicolas, Hernan, >> >> (Adding Hernan in the recipients list) >> >> On 7/8/22 02:01, Nicolas Chautru wrote: >>> This is targeting 22.11 and includes the PMD for the integrated >>> accelerator on Intel Xeon SPR-EEC. >>> There is a dependency on that parallel serie still in-flight which >>> extends the bbdev api >>> https://patches.dpdk.org/project/dpdk/list/?series=23894 >>> >>> I will be offline for a few weeks for the summer break but Hernan >>> will cover for me during that time if required. >>> >>> Thanks >>> Nic >>> >>> Nicolas Chautru (10): >>> baseband/acc200: introduce PMD for ACC200 >>> baseband/acc200: add HW register definitions >>> baseband/acc200: add info get function >>> baseband/acc200: add queue configuration >>> baseband/acc200: add LDPC processing functions >>> baseband/acc200: add LTE processing functions >>> baseband/acc200: add support for FFT operations >>> baseband/acc200: support interrupt >>> baseband/acc200: add device status and vf2pf comms >>> baseband/acc200: add PF configure companion function >>> >>> MAINTAINERS | 3 + >>> app/test-bbdev/meson.build | 3 + >>> app/test-bbdev/test_bbdev_perf.c | 76 + >>> doc/guides/bbdevs/acc200.rst | 244 ++ >>> doc/guides/bbdevs/index.rst | 1 + >>> drivers/baseband/acc200/acc200_pf_enum.h | 468 +++ >>> drivers/baseband/acc200/acc200_pmd.h | 690 ++++ >>> drivers/baseband/acc200/acc200_vf_enum.h | 89 + >>> drivers/baseband/acc200/meson.build | 8 + >>> drivers/baseband/acc200/rte_acc200_cfg.h | 115 + >>> drivers/baseband/acc200/rte_acc200_pmd.c | 5403 ++++++++++++++++++++++++++++++ >>> drivers/baseband/acc200/version.map | 10 + >>> drivers/baseband/meson.build | 1 + >>> 13 files changed, 7111 insertions(+) >>> create mode 100644 doc/guides/bbdevs/acc200.rst >>> create mode 100644 drivers/baseband/acc200/acc200_pf_enum.h >>> create mode 100644 drivers/baseband/acc200/acc200_pmd.h >>> create mode 100644 drivers/baseband/acc200/acc200_vf_enum.h >>> create mode 100644 drivers/baseband/acc200/meson.build >>> create mode 100644 drivers/baseband/acc200/rte_acc200_cfg.h >>> create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c >>> create mode 100644 drivers/baseband/acc200/version.map >>> >> Comparing ACC200 & ACC100 header files, I understand ACC200 is an evolution of the ACC10x family. The FEC bits are really close, ACC200 main addition seems to be FFT acceleration which could be handled in ACC10x driver based on device ID. >> >> I think both drivers have to be merged in order to avoid code duplication. That's how other families of devices (e.g. i40e) are handled. >> >> Thanks, >> Maxime >>