From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 151F6A2EEB for ; Thu, 12 Sep 2019 14:15:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00C1F1E971; Thu, 12 Sep 2019 14:15:00 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 929331D171 for ; Thu, 12 Sep 2019 14:14:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4C04302C096; Thu, 12 Sep 2019 12:14:57 +0000 (UTC) Received: from [10.36.118.30] (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4C4F4516; Thu, 12 Sep 2019 12:14:56 +0000 (UTC) To: Matan Azrad , Shahaf Shuler , Yongseok Koh Cc: dev@dpdk.org References: <1559211639-17442-1-git-send-email-matan@mellanox.com> From: Kevin Traynor Message-ID: <81aa0ce1-14c0-1e95-0caa-5a4607317600@redhat.com> Date: Thu, 12 Sep 2019 13:14:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1559211639-17442-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 12 Sep 2019 12:14:57 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/05/2019 11:20, Matan Azrad wrote: > Add support for data-path Rx and Tx completions with error handling: > > 1. Detect the error. > 2. Do not crash. > 3. Report it in statistics counters. > 4. Dump debug information to system log file. > 5. Recover the error under the hood. > 6. Add support for secondary process recovery. > > No performance impact was shown. > > Matan Azrad (9): > net/mlx5: remove Rx queues indexes correlation > net/mlx5: add log file procedure for debug data > net/mlx5: fix device arguments error detection > net/mlx5: mitigate Rx doorbell memory barrier > net/mlx5: separate Rx queue initialization > net/mlx5: extend Rx completion with error handling > net/mlx5: handle Tx completion with error > net/mlx5: recover secondary process Rx errors > net/mlx5: recover secondary process Tx errors > > doc/guides/nics/mlx5.rst | 7 + > drivers/net/mlx5/mlx5.c | 14 +- > drivers/net/mlx5/mlx5.h | 12 + > drivers/net/mlx5/mlx5_mp.c | 46 +++ > drivers/net/mlx5/mlx5_prm.h | 11 + > drivers/net/mlx5/mlx5_rxq.c | 42 +-- > drivers/net/mlx5/mlx5_rxtx.c | 673 ++++++++++++++++++++++++++++------ > drivers/net/mlx5/mlx5_rxtx.h | 193 +++++----- > drivers/net/mlx5/mlx5_rxtx_vec.c | 5 +- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +- > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 36 +- > drivers/net/mlx5/mlx5_trigger.c | 1 + > drivers/net/mlx5/mlx5_txq.c | 4 +- > 13 files changed, 792 insertions(+), 288 deletions(-) > Hi - these changes are very invasive ^^^. I'm not really comfortable to take this for 18.11.3. See http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported I will take patch 3/9 as it is a fix with Fixes: tag. thanks, Kevin.