From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EA08D7D4E for ; Wed, 19 Sep 2018 19:38:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 10:38:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,394,1531810800"; d="scan'208";a="74332291" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga007.jf.intel.com with ESMTP; 19 Sep 2018 10:38:48 -0700 To: Andrzej Ostruszka , dev@dpdk.org References: <1535718368-15803-1-git-send-email-amo@semihalf.com> <1535720386-18775-1-git-send-email-amo@semihalf.com> <1535720386-18775-2-git-send-email-amo@semihalf.com> <26dc727f-8386-3261-0712-fb3f20566a20@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <81baffdf-1217-750f-89d7-0c84b1e1c96c@intel.com> Date: Wed, 19 Sep 2018 18:38:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/mvneta: add neta PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 17:38:52 -0000 On 9/19/2018 4:14 PM, Andrzej Ostruszka wrote: > On 14.09.2018 18:23, Ferruh Yigit wrote: >> On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: > [...] >> For link status feature "link_update" eth_dev_ops needs to be implemented, >> please either implement it or remove feature. (I saw this done later, please >> add this on relevant patch) >> >>> +MTU update = Y >> >> For mtu update feature "mtu_set" eth_dev_ops needs to be implemented, >> please either implement it or remove feature. (I saw this done later, please >> add this on relevant patch) >> >>> +Jumbo frame = Y >>> +Promiscuous mode = Y >> >> Promiscuous mode support is not enabled. (I saw this done later, please add >> this on relevant patch) >> >>> +CRC offload = Y >>> +L3 checksum offload = Y >>> +L4 checksum offload = Y >> >> Claiming L3 & L4 cksum offload also requires data path implementation to take >> care mbuf.ol_flags flags. (I saw this is done in next patch, please add this >> line in next patch) >> Also I can see these are presented as capabilities but shouldn't this >> information passed to musdk somehow? Are they always enabled? >> >>> +Packet type parsing = Y >> >> Similar to above, dev_supported_ptypes_get() is implemented but this also >> requires data path implementation that fills mbuf->packet_type. (I saw this is >> done in next patch, please add this line in next patch) >> >>> +Basic stats = Y >> >> Basic stats collection is not implemented in this patch. (I saw this done >> later, please add this on relevant patch) > > I have moved documentation of features to relevant patches. > >> There is a limit to number of "iface" in code, does it make sense to document it? > > I don't think so - there won't be a board supporting more than 4 ports. > >>> +RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv); >>> +RTE_PMD_REGISTER_ALIAS(net_mvneta, eth_mvneta); >> >> No need to provide alias for new PMDs > > Removed. So "eth_XXX" naming is just legacy - I see it in many drivers > that they are available both as "net_XXX" and "eth_XXX". It was eth_xxx in the past, renamed to net_xxx and added and alias for eth_xxx for backward compatibility. Since no one uses eth_mvneta no need to keep it.