From: fengchengwen <fengchengwen@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>,
<ciara.power@intel.com>, <kevin.laatz@intel.com>
Subject: Re: [PATCH v4 0/5] support dmadev/ethdev stats reset
Date: Thu, 9 Feb 2023 09:45:38 +0800 [thread overview]
Message-ID: <81c86e0b-e707-1ab7-2cf9-0c8380c6950e@huawei.com> (raw)
In-Reply-To: <Y+Ou+F2uz6n4wIj+@bricha3-MOBL.ger.corp.intel.com>
On 2023/2/8 22:17, Bruce Richardson wrote:
> On Fri, Jan 20, 2023 at 03:34:51AM +0000, Chengwen Feng wrote:
>> This patchset contains dmadev/ethdev stats reset, and also support
>> hide zero for ethdev xstats and two telemetry related bugs.
>>
>> Chengwen Feng (5):
>> dmadev: support stats reset telemetry command
>> telemetry: fix repeat display when callback don't init dict
>> ethdev: add newline to telemetry log string
>> ethdev: support xstats reset telemetry command
>> ethdev: telemetry xstats support hide zero
>>
> On one level, I can understand how this may be useful, but on the other
> side, we also support having multiple different clients connecting to
> telemetry simultaneously. Would it not be problematic to have stats
> suddenly being reset by one connection without the others being aware of
> it?
It's a problem. Anyone who can connect can execute the commands.
For this modify case, I suggest adding LOG for later refer. and will fix in V5.
Thanks.
>
> /Bruce
> .
>
next prev parent reply other threads:[~2023-02-09 1:45 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:07 [PATCH v5 " Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 2/5] telemetry: fix repeated display when callback don't set dict Chengwen Feng
2022-12-19 9:33 ` Bruce Richardson
2022-12-26 4:53 ` fengchengwen
2023-01-06 16:07 ` Bruce Richardson
2023-01-06 17:33 ` Bruce Richardson
2023-01-11 12:38 ` fengchengwen
2022-12-19 9:07 ` [PATCH v5 3/5] ethdev: support xstats reset telemetry command Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 4/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 5/5] ethdev: add newline to telemetry log string Chengwen Feng
2022-12-26 4:55 ` [PATCH v5 0/5] support dmadev/ethdev stats reset fengchengwen
2023-01-11 12:02 ` [PATCH v2 " Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 2/5] telemetry: fix repeat display when callback don't set dict Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 0/5] support dmadev/ethdev stats reset Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-11 13:58 ` Bruce Richardson
2023-01-11 12:06 ` [PATCH v2 2/5] telemetry: fix repeat display when callback don't set dict Chengwen Feng
2023-01-11 14:01 ` Bruce Richardson
2023-01-11 12:06 ` [PATCH v2 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-11 14:08 ` Bruce Richardson
2023-01-20 3:51 ` fengchengwen
2023-01-11 12:36 ` [PATCH v2 0/5] support dmadev/ethdev stats reset fengchengwen
2023-01-20 3:25 ` [PATCH v3 " Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 2/5] telemetry: fix repeat display when callback don't init dict Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 0/5] support dmadev/ethdev stats reset Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict Chengwen Feng
2023-02-08 14:15 ` Bruce Richardson
2023-02-09 1:33 ` fengchengwen
2023-01-20 3:34 ` [PATCH v4 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-02-06 8:39 ` [PATCH v4 0/5] support dmadev/ethdev stats reset Thomas Monjalon
2023-02-08 14:17 ` Bruce Richardson
2023-02-09 1:45 ` fengchengwen [this message]
2023-02-09 2:32 ` [PATCH v5 0/2] " Chengwen Feng
2023-02-09 2:32 ` [PATCH v5 1/2] dmadev: support stats reset telemetry command Chengwen Feng
2023-02-09 2:32 ` [PATCH v5 2/2] ethdev: support xstats " Chengwen Feng
2023-02-15 3:19 ` Dongdong Liu
2023-02-16 11:53 ` fengchengwen
2023-02-16 12:06 ` Ferruh Yigit
2023-02-16 12:42 ` fengchengwen
2023-02-16 12:54 ` Bruce Richardson
2023-02-16 12:55 ` Bruce Richardson
2023-02-17 9:44 ` fengchengwen
2023-02-20 13:05 ` Thomas Monjalon
2023-07-03 3:58 ` fengchengwen
2023-07-03 7:20 ` Thomas Monjalon
2023-07-03 13:44 ` Morten Brørup
2023-07-04 6:41 ` fengchengwen
2024-10-03 18:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c86e0b-e707-1ab7-2cf9-0c8380c6950e@huawei.com \
--to=fengchengwen@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).