From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27EF741C45; Thu, 9 Feb 2023 02:45:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B12B040DDA; Thu, 9 Feb 2023 02:45:42 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 5E1844067B for ; Thu, 9 Feb 2023 02:45:40 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PC0251cRlzJr0C; Thu, 9 Feb 2023 09:41:01 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Feb 2023 09:45:38 +0800 Subject: Re: [PATCH v4 0/5] support dmadev/ethdev stats reset To: Bruce Richardson CC: , , , , , References: <20221219090723.29356-1-fengchengwen@huawei.com> <20230120033456.29710-1-fengchengwen@huawei.com> From: fengchengwen Message-ID: <81c86e0b-e707-1ab7-2cf9-0c8380c6950e@huawei.com> Date: Thu, 9 Feb 2023 09:45:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/2/8 22:17, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:51AM +0000, Chengwen Feng wrote: >> This patchset contains dmadev/ethdev stats reset, and also support >> hide zero for ethdev xstats and two telemetry related bugs. >> >> Chengwen Feng (5): >> dmadev: support stats reset telemetry command >> telemetry: fix repeat display when callback don't init dict >> ethdev: add newline to telemetry log string >> ethdev: support xstats reset telemetry command >> ethdev: telemetry xstats support hide zero >> > On one level, I can understand how this may be useful, but on the other > side, we also support having multiple different clients connecting to > telemetry simultaneously. Would it not be problematic to have stats > suddenly being reset by one connection without the others being aware of > it? It's a problem. Anyone who can connect can execute the commands. For this modify case, I suggest adding LOG for later refer. and will fix in V5. Thanks. > > /Bruce > . >