From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C9C888D39 for ; Thu, 19 May 2016 09:51:22 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB7116265D; Thu, 19 May 2016 07:51:21 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-221.ams2.redhat.com [10.36.5.221]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4J7pJRV023301; Thu, 19 May 2016 03:51:20 -0400 To: Neil Horman , dev@dpdk.org References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1463605687-649-1-git-send-email-nhorman@tuxdriver.com> <1463605687-649-2-git-send-email-nhorman@tuxdriver.com> Cc: Bruce Richardson , Thomas Monjalon , Stephen Hemminger From: Panu Matilainen Message-ID: <81cef5e5-3220-710f-aebf-a703c1423199@redhat.com> Date: Thu, 19 May 2016 10:51:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463605687-649-2-git-send-email-nhorman@tuxdriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 19 May 2016 07:51:22 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCHv2 1/4] pmdinfogen: Add buildtools and pmdinfogen utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 07:51:23 -0000 On 05/19/2016 12:08 AM, Neil Horman wrote: [...] > + if (strcmp(secname, ".modinfo") == 0) { > + if (nobits) > + fprintf(stderr, "%s has NOBITS .modinfo\n", filename); > + info->modinfo = (void *)hdr + sechdrs[i].sh_offset; > + info->modinfo_len = sechdrs[i].sh_size; > + } else if (strcmp(secname, "__ksymtab") == 0) > + info->export_sec = i; > + else if (strcmp(secname, "__ksymtab_unused") == 0) > + info->export_unused_sec = i; > + else if (strcmp(secname, "__ksymtab_gpl") == 0) > + info->export_gpl_sec = i; > + else if (strcmp(secname, "__ksymtab_unused_gpl") == 0) > + info->export_unused_gpl_sec = i; > + else if (strcmp(secname, "__ksymtab_gpl_future") == 0) > + info->export_gpl_future_sec = i; > + Looks like a leftover from kernel modpost.c, not needed in DPDK. - Panu -