From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>,
Ali Alnubani <alialnu@nvidia.com>,
Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] devtools: check for supported git version
Date: Wed, 26 Oct 2022 08:52:24 +0100 [thread overview]
Message-ID: <81d75a97-6e5f-2a89-2b18-ac02f5195503@amd.com> (raw)
In-Reply-To: <CAJFAV8yi04Vy-JKYkzv7hg=PWj=hC-c6_=+YqJwOoAH_FBZtLQ@mail.gmail.com>
On 10/26/2022 7:24 AM, David Marchand wrote:
> On Tue, Oct 25, 2022 at 12:15 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>>
>> The script devtools/parse-flow-support.sh uses the git-grep
>> option (-o, --only-matching), which is only supported from
>> git version 2.19 and onwards.[1]
>>
>> The script now exits early providing a clear message to the user
>> about the required git version instead of showing the following
>> error messages multiple times:
>> error: unknown switch `o'
>> usage: git grep [<options>] [-e] <pattern> [<rev>...] [[--] <path>...]
>> [..]
>>
>> [1] https://github.com/git/git/blob/v2.19.0/Documentation/RelNotes/2.19.0.txt
>>
>> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> I don't have a "non working" git, but the patch lgtm.
>
> Acked-by: David Marchand <david.marchand@redhat.com>
>
+Chaoyong,
He had observed the problem, perhaps he can help to test.
next prev parent reply other threads:[~2022-10-26 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 15:37 [PATCH] " Ali Alnubani
2022-10-25 8:39 ` David Marchand
2022-10-25 10:15 ` [PATCH v2] " Ali Alnubani
2022-10-26 6:24 ` David Marchand
2022-10-26 7:52 ` Ferruh Yigit [this message]
2022-10-26 8:34 ` Chaoyong He
2022-10-31 15:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d75a97-6e5f-2a89-2b18-ac02f5195503@amd.com \
--to=ferruh.yigit@amd.com \
--cc=alialnu@nvidia.com \
--cc=chaoyong.he@corigine.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).