From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D433A0542; Wed, 26 Oct 2022 09:52:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBC6640E28; Wed, 26 Oct 2022 09:52:33 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58]) by mails.dpdk.org (Postfix) with ESMTP id 9D71840A7F for ; Wed, 26 Oct 2022 09:52:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nWpkAZjF/MjEU07JXIsPuxUcLPliO9Ls4kFDqHgJqsdhRDW02f42Vf6Bi8btxCpFRaE/sSpdGFKWb70TZm5Lz3OeBRMbEVXzoAyYszBVzeswb1YH8bi0JKbhAD66H8L9WitMaYwOOBgpuklwZBUXn/1fPO5VbOdqLTC2euBBj/apHu9wm1ImrgGCAskK3jiWtZ5sS1Xv2UmoMJi2zmN3CRk/DglhSzvWhtCG9GwyAlQ5+5yBGwaYojE43LOpoTYtB9ewkoM4k1skZXak/WvQoOvTszN++hQ82ot7SWq/eyDQr+474G0AGEMTh4WTxEWyb6cTK51BJkLBZJeQGo34Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8RPr663BgnCVJ4Dq4UyxsXts8kRYVjECJIY4/h7E+zs=; b=kp7qMrw/sAEEGlWfgAzDpls2KyyG4QEJhBbNn26ztmuufl3GWFLMNBeoB522IfeFLroBOLE2bil1mAK1k1to1+lodjrUUnEQ+NB96Pbo8VONo2K4xtlOojbBAdpMYOyJXvjWbKHmAUUfKMFzqTPj/XV3jU2XEFesnScAwX2M6EJt6dQUXgtiCSssFKQkw/fJRpTyGtBFJW7us5XG/Elf49uXNePuavvMXQmOoBEaZTYFuNH5r6vLc4YUBT/C3WFiiKThSaoSA4jxWs8h5OJqKVms/h5cYVut5exmwoGtwxM7LTrGPvwwAkec6KAs3dCeh866sv3dI7Mwh9y1XCI5qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RPr663BgnCVJ4Dq4UyxsXts8kRYVjECJIY4/h7E+zs=; b=k9gGLq2fxHjdFiYlaxN9ZPtnayt1DNgJjSj4Y96JK1meC+PauJvTRgmjw6C3IuXCvhPjv2yvL5qVw8k6vC5z6oHPtTUSnsOb1PmAeNcYuGfZW7pQhEuY7evdNd0zSdwqzd4VLOXOEtSpPPLctSZJJeUWfmofKBDuN15G8JgnJr4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by CY5PR12MB6036.namprd12.prod.outlook.com (2603:10b6:930:2c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Wed, 26 Oct 2022 07:52:28 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%8]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022 07:52:28 +0000 Message-ID: <81d75a97-6e5f-2a89-2b18-ac02f5195503@amd.com> Date: Wed, 26 Oct 2022 08:52:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] devtools: check for supported git version Content-Language: en-US To: David Marchand , Ali Alnubani , Chaoyong He Cc: dev@dpdk.org, Thomas Monjalon References: <20221024153706.3117107-1-alialnu@nvidia.com> <20221025101512.3190439-1-alialnu@nvidia.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0081.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::21) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|CY5PR12MB6036:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fafe78a-1b41-4595-2b6b-08dab7270789 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IZ4YIELjp3kSL48V/gp4cMZT+ljct6H/TuXVfOmbc2M1Xk7V8ZBY9fMOmb07D8zaBnLOfVeSKZERicq3hveqz2Tf0VzqL1NYJHLvbMXM5L42oOmzyTP++t7sO6v4W9o4/8lmr7tRRIeFcRQvrwffccnYAJbo10x478s/b8TGAPCYGmzVN21CziXaWet/IBcuO4ybHJwVhfLnsH36QV4GBp7KALaoNA9jg4nEFnprErfSsyw7/QFVph/MCuWHrmbfsZg/K/25aLREr4gSb3gb8m05uS1by0SJtwHjFFgVEHYHrqkq7LA4xxg8Nxrb++OcrhoxtaI3Hjp9g011Ts62cxTBOwaWlWSgccBfwZrJ0QNslAqcWavh9b63/hdLu7mDd7T0FC1/abB+YGI8U5Fsihq9g6RQ1xzZlz6888/iM81rNBAWE2SmbF9GpreFaY1gNJ3TOMf7ztKmLs9GjT1znn/RQ3ke2sgi4nZadwj8XuHlF2LrS9Bxlt+vU6+zHYP80DRKFRz6OYO2s0IXSq21CIJkCQ7j1V1coje3SHlbMo/Y+cN1BIxWt7Z71AUW6/jY6aaJwkY7YhF5WOV4VbP07pJR1M6V9xV8L1VMjoXADtJriEEr5DAqpRGNixS6oXJrGmqbT1OjTyeQ2DBcd7mvoal/PmIuT4TiFe+GLIdnUEnthrnh85Be4k6ZMzcnfBDL8GVXrxqj5z1wTx7nLRvtjgDb5BtAbesUduaeJjE/enMnf0yYo+FKH+fKhCtSaIuJNiSUUhynT1w2htHMsGm5EXh8TMr9uhDwpNHkCi5TZZv9igVrYm5AedD568NaEVsv X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(110136005)(316002)(186003)(83380400001)(2616005)(478600001)(6506007)(6512007)(26005)(36756003)(966005)(38100700002)(53546011)(41300700001)(8936002)(8676002)(6666004)(86362001)(44832011)(4744005)(5660300002)(31686004)(2906002)(66946007)(66476007)(66556008)(31696002)(4326008)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3RlYXJaN3BaYThJbDlXSWlmTTlPYzc1MVZWS1VQVEpweC9uTUMwcm1jNW84?= =?utf-8?B?VzB6N2hvdkM3anNaRUZPbmdReVBlbUI5TEpZdzJSQkRGeWNFdmNrMTkxMmMr?= =?utf-8?B?YnAyekpiNm5DNEdFY1JjQy9CajMvS1gwRDUvd1pCTEFleGJGcVNISExJUlFu?= =?utf-8?B?aFhLRUt5NUVtbVVvRjhhOWZmRnJIaFM2NUZ6bk9vYmM4MHFhUWV6WnpTQkM4?= =?utf-8?B?NVhuZXMzMDBkRXpXNVRTa1BIS0dVbWgvazFDZjBvMmRsTXIxdWdYa3MxdGQ0?= =?utf-8?B?SCs3dlpwSEwrT1JWcTFVYUNJWHdSMEttZ213ZkpRUEZ4N200Wk92QW82Zjhk?= =?utf-8?B?di9YV0hMaCs0Uk1iTmo3L3dTc011eVFRR3RaS2hMcXkxK2dMcGVUODlNN3d2?= =?utf-8?B?WFppcC9GWTJxWXc2NWZuNjFtWlhZOHIvQmFIL0VaYi8xcnljdUI1bzgwc3Jr?= =?utf-8?B?RllQWUlJckRUQzNrWHdQaFI1TWR2THk1STlPeWoybVdLLzdNTGRQTDlwWnph?= =?utf-8?B?ZGs4YVdZRitEQ1NKc3E4eWhJYlpxV0s5S0RIR0tUVmNqQTJ3Q1hsbEVZMFZh?= =?utf-8?B?R0Nma3JVWE01S1BiTmh1ZFcvWEJSUS9lMzhZTUgveFdIak1vS1NpMFJ2bVg3?= =?utf-8?B?cmVmSjAyM2o5Sk44VjdkOWlqQmZwL09BUEpVS2VQbmNqTk5ER09iTlNQeWtz?= =?utf-8?B?VU4zK2N3UExpMElSb1BBUlFpbGI0ZzByRm1nWkl5aFM4dDZuSTBtTkdEREtv?= =?utf-8?B?YTd2cHp1cHhIMlBFT0pTNDA3dmQwNGJZMllLWE1Rbm5mcGI3cGc2L3FuY1Bj?= =?utf-8?B?ZlVPWHZ0Z3VhZmhsczRYVGU4REI2RXpuSmNHcDFRczYzOUp3alJra0lscDRw?= =?utf-8?B?T3ZwV1NuRGFkcyt4N3hkS1g3WncxTDRXdm52NDBFaFp5VThOQUdIb1NNQ0o4?= =?utf-8?B?b0JQVlBabElLc3Qvb0ZEYytWbkpLT1Z4Q25XVDFoTDFDb3M3K3RibGE5Zjg5?= =?utf-8?B?SUFaR2hRS1p3UVliVUJHcFRLZS92ZW5ITU5UWS9TemovV0pYSEIzNnFnMlpP?= =?utf-8?B?cnY0TGJyVmxCVUsxOXpabVZiT1pUV1JnZ2FtSXV1V1FhQkdDZTlRM2M2enpH?= =?utf-8?B?aU9aL0lPYk1mc0wzVnR4Z2drRGhtRXdMRFprWlpHaGsvTDhidzB0UEgzTjZx?= =?utf-8?B?enpsOUNXWnlBOWNLaEU4T1EvVUdjR3I4ci9walBBc3NJWkxNcHlGbkFGajd5?= =?utf-8?B?WnRUZzJuZEhvQXI2U1ZqcFhKNHREVEdFT3ZPeHZJQ1ZGWHZCTzd3UzhkbmZu?= =?utf-8?B?L255dzhJakdYNlBnQnU0cm1UWmVuSTlZN0NNZ0xzb3VRU00xL244OFJoRFdp?= =?utf-8?B?V2dhaDNNcHB1Y1ZFOFVSSk80U1RTTkQ4TDZhTFpTM3pPdlhxL1EyU0RaUlAv?= =?utf-8?B?Zzlja0RKRmRiVUEyUXVUT24yaEg4SzN0ZVFhc0xpQndtYTVQSWZhZWlOT3g3?= =?utf-8?B?SEJRUFpWOCt1L3JxaWRJNGJKTjhFQTZaZUlSZ1NMc1lBeTF0MmNCYzZJNnZF?= =?utf-8?B?dy9XU0JSVGJ2VnNUNS9pRUVIVllLbnpwUXpuS0huc3U2NXBYRmNSbnJKd1Q2?= =?utf-8?B?UmhRcGR6bzIrQ1BhaW1LQTlyT0h6U1JJcWY5KzlvZ3F0RWRTdmZTU09Mb2o1?= =?utf-8?B?SkZ2eWEyelVDZXRZcGFiRjFCZ21MZmw1cXcvMWF1aWg4N05COWcvUkRXSm1V?= =?utf-8?B?RFNRRWQwcTlIeTNlYmFrRzZJdERjaUtFcnNmRC9FbmRNbzRLeVJwZkxab2JF?= =?utf-8?B?eWJWQlRjWTUyL0tSWkRabUpHZmQ2Zm1zOVpmd2h0VFg1Yjc4dElVaGZtS2U1?= =?utf-8?B?R3g2dlRudThMbWM1cHZQRkF2bGpTMmJlMktPVHJkdWNwMWI5dXZwRHRYRkdr?= =?utf-8?B?TkJtbG9HS1puUVFzTlQrbmNjQnF2SVlndzFQTUN4U01lNkxweEpwckZuQVoy?= =?utf-8?B?SWx5WDdvTmpaSWJaOVhkd1JnbmExazVzaXExQnVtLzVNbWZwUGY0UnZtK1Iv?= =?utf-8?B?Y3hnSnR4bVhnRzlLdnhZdVc3UWthWWxpdGtIR2RiWGJYMlhkd2l3WGF3UFZE?= =?utf-8?Q?670G48vdP0Eo1MQYBi4BkU0NC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fafe78a-1b41-4595-2b6b-08dab7270789 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 07:52:28.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8RXc7LwJ+oRyRjN48CwLB3tJ0+97elo3cvwp5y2ty4t8m4k3428I16xNv7K4vnuk X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/26/2022 7:24 AM, David Marchand wrote: > On Tue, Oct 25, 2022 at 12:15 PM Ali Alnubani wrote: >> >> The script devtools/parse-flow-support.sh uses the git-grep >> option (-o, --only-matching), which is only supported from >> git version 2.19 and onwards.[1] >> >> The script now exits early providing a clear message to the user >> about the required git version instead of showing the following >> error messages multiple times: >> error: unknown switch `o' >> usage: git grep [] [-e] [...] [[--] ...] >> [..] >> >> [1] https://github.com/git/git/blob/v2.19.0/Documentation/RelNotes/2.19.0.txt >> >> Signed-off-by: Ali Alnubani >> Signed-off-by: Thomas Monjalon > > I don't have a "non working" git, but the patch lgtm. > > Acked-by: David Marchand > +Chaoyong, He had observed the problem, perhaps he can help to test.