From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jianfeng.tan@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E81424CA6 for <dev@dpdk.org>; Wed, 28 Feb 2018 16:01:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 07:01:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,406,1515484800"; d="scan'208";a="20992760" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.25.28]) ([10.255.25.28]) by fmsmga008.fm.intel.com with ESMTP; 28 Feb 2018 07:01:02 -0800 To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org> References: <31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519672713.git.anatoly.burakov@intel.com> <2f9a4da56e7f31f141db8cb2bb34d3c7fef97691.1519740527.git.anatoly.burakov@intel.com> <ED26CBA2FAD1BF48A8719AEF02201E36514556D1@SHSMSX103.ccr.corp.intel.com> <8cc51c18-9999-642c-f8e3-3b3834104cc3@intel.com> From: "Tan, Jianfeng" <jianfeng.tan@intel.com> Message-ID: <81e0656d-ee88-ba05-0215-a9efa486e598@intel.com> Date: Wed, 28 Feb 2018 23:01:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8cc51c18-9999-642c-f8e3-3b3834104cc3@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 28 Feb 2018 15:01:05 -0000 On 2/28/2018 6:21 PM, Burakov, Anatoly wrote: > On 28-Feb-18 1:52 AM, Tan, Jianfeng wrote: >> Hi Anatoly, >> >>> -----Original Message----- >>> From: Burakov, Anatoly >>> Sent: Tuesday, February 27, 2018 10:36 PM >>> To: dev@dpdk.org >>> Cc: Tan, Jianfeng >>> Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC >>> >>> Currently, filter value is hardcoded and disconnected from actual >>> value returned by eal_mp_socket_path(). >> >> I can understand the hardcode is not good. But why it's not >> consistent with the actual value returned from eal_mp_socket_path()? > > It is consistent. It's just that it's disconnected from the value > returned by eal_mp_socket_path(). Meaning, if you change how > eal_mp_socket_path() works, you'll also have to update the filter (or > you may forget to do it and have a bug). This patch makes it so that > mp_filter value is automatically updated, should you change internal > workings of eal_mp_socket_path(). Yeah, that makes sense. Thank you for fixing it. Thanks, Jianfeng