From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5AACA0561; Wed, 3 Mar 2021 14:27:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A45C440696; Wed, 3 Mar 2021 14:27:43 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E10004068C for ; Wed, 3 Mar 2021 14:27:42 +0100 (CET) IronPort-SDR: CUa0QW5edxWeq+fSgfsUDqIDTNbo9CH7udGaimB02mn1zodgJpkqh4Sm8gMCAkVICzwq/v/QNp oB7haRqibuoA== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="174314270" X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="174314270" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 05:27:41 -0800 IronPort-SDR: 0NFBcAQgpRDAPEyLFIKMQe+eVK+HKvlvcdL1DVnbep+O4HNErsv4e05lK5NkcwmQ88Klc5sCJP xxl2YDBfQ8KA== X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="445246961" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.219.174]) ([10.213.219.174]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 05:27:40 -0800 To: Lijun Ou Cc: dev@dpdk.org, linuxarm@openeuler.org References: <1614130139-42926-1-git-send-email-oulijun@huawei.com> <1614130139-42926-10-git-send-email-oulijun@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <81ea08bc-6570-9b98-952c-97c6a4a62d0f@intel.com> Date: Wed, 3 Mar 2021 13:27:39 +0000 MIME-Version: 1.0 In-Reply-To: <1614130139-42926-10-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 09/13] net/hns3: fix maximum frame size update after buffer alloc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/24/2021 1:28 AM, Lijun Ou wrote: > From: Chengchang Tang > > After MTU changed, the buffer used to store packets in HW should be > reallocated. And buffer size is allocated based on the maximum frame > size in the PF struct. However, the value of maximum frame size is > not updated in time when MTU is changed. This would lead to a packet > loss for not enough buffer. > > This patch update the maximum frame size before reallocating the HW > buffer. And a rollback operation is added to avoid the side effects > of buffer reallocation failures. > > Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") > Fixes: d51867db65c1 ("net/hns3: add initialization") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Lijun Ou After the previous 'before/after' confusion, what do you think to update the patch title as: net/hns3: fix HW buffer size on MTU update