From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 529814C74 for ; Wed, 7 Mar 2018 12:29:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 03:29:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,435,1515484800"; d="scan'208";a="22706626" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.5.25]) ([10.252.5.25]) by orsmga007.jf.intel.com with ESMTP; 07 Mar 2018 03:29:48 -0800 To: Thomas Monjalon , Arnon Warshavsky Cc: bruce.richardson@intel.com, dev@dpdk.org References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> <304114136.g7uiPYdxRp@xps> <4197355.YAsZy1EAlL@xps> From: "Burakov, Anatoly" Message-ID: <81ecbc4a-0200-3b42-8da1-fe87e8c14c04@intel.com> Date: Wed, 7 Mar 2018 11:29:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4197355.YAsZy1EAlL@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 11:29:51 -0000 On 07-Mar-18 9:59 AM, Thomas Monjalon wrote: > 07/03/2018 10:05, Burakov, Anatoly: >> On 07-Mar-18 8:32 AM, Thomas Monjalon wrote: >>> Hi, >>> >>> 06/03/2018 19:28, Arnon Warshavsky: >>>> The use case addressed here is dpdk environment init >>>> aborting the process due to panic, >>>> preventing the calling process from running its own tear-down actions. >>> >>> Thank you for working on this long standing issue. >>> >>>> A preferred, though ABI breaking solution would be >>>> to have the environment init always return a value >>>> rather than abort upon distress. >>> >>> Yes, it is the preferred solution. >>> We should not use exit (panic & co) inside a library. >>> It is important enough to break the API. >> >> +1, panic exists mostly for historical reasons AFAIK. it's a pity i >> didn't think of it at the time of submitting the memory hotplug RFC, >> because i now hit the same issue with the v1 - we might panic while >> holding a lock, and didn't realize that it was an API break to change >> this behavior. >> >> Can this really go into current release without deprecation notices? > > If such an exception is done, it must be approved by the technical board. > We need to check few criterias: > - which functions need to be changed > - how the application is impacted > - what is the urgency > > If a panic is removed and the application is not already checking some > error code, the execution will continue without considering the error. > > Some rte_panic could be probably removed without any impact on applications. > Some rte_panic could wait for 18.08 with a notice in 18.05. > If some rte_panic cannot wait, it must be discussed specifically. > Can we add a compile warning for adding new rte_panic's into code? It's a nice tool while debugging, but it probably shouldn't be in any new production code. -- Thanks, Anatoly