From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 337F1A04F6;
Tue, 7 Jan 2020 15:29:39 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B17EF1D14C;
Tue, 7 Jan 2020 15:29:38 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B9E461D14B;
Tue, 7 Jan 2020 15:29:37 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 27B4121BBA;
Tue, 7 Jan 2020 09:29:37 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Tue, 07 Jan 2020 09:29:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=W4LMA6zKIIrU1Nghza07XRMdpAhZJ1/NPWORibNtNZk=; b=Ij4ayit3EJua
ukIppnRPwL88rbaqKecaf8kzWlt2O+2MJoMHCVVvuSmUGN/YIpFin0/i+ID3JKY6
Q+caH47S1rpwcsdgL5J1e5Jjfobng4Rm3WDG7zr15h6LUUk21DuYvKM6Jd0X1Thk
XKfBnRmp5W9mwq4bfgd6h9XpUqNTA5k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=W4LMA6zKIIrU1Nghza07XRMdpAhZJ1/NPWORibNtN
Zk=; b=MbnXPMuYwYDthVXg5k/soS2uVYvc9btD3tH1mxUy0tNBeBMS1O8SDpjl0
R4dRDzOSY/Ys0+j0GmnPno/FiTem6WGejdrlASDtkY9v5Vl9bE6Qto/9HHjP2Qvb
G72K6ea47vrKWW+0H+ck45o9H0RyQAefAQDi/bMTeB9WEUy8z7CUrzJQx7pdkbU9
EoaPDtvO/zBMHQecQQSTp2cMtaixwfjxdkKYidET5OHZ/km0hs4B35bfO+oFmMSD
KDe22C+lykMJgZcI069LLv+Ud8KXmLghpAeCnwYnQhkzwYBbJQ5vYEc8/K0RGQjZ
JdparPgV1yBi38UuRPl1ZETG8qSJQ==
X-ME-Sender: <xms:0JUUXunily17dLZlloYqJrPHx8Xd4QhtcfqLBxjD7bv6oQDvB3UhCQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdehgedgudelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:0JUUXrA61UxbZeFKwiFIizojEqRTWXArS_2o_PERRIemsdcJ9-E2Dw>
<xmx:0JUUXgClLiMO-nrs1_VCmhwbO8C9__dND_BpxL15oAUg04jvCbp_dg>
<xmx:0JUUXiGAOJ2uKsOdQgd4zGA89L3XwTEfXCB0cFFuM7ppLpMJtFcnkg>
<xmx:0ZUUXou2eVHbJeekp6_CJpbmnHja1YfNHe-T3hHdenVpNU-4DKcdgA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 154413060774;
Tue, 7 Jan 2020 09:29:36 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Suanming Mou <suanmingm@mellanox.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>, xiangxia.m.yue@gmail.com,
rasland@mellanox.com, stable@dpdk.org
Date: Tue, 07 Jan 2020 15:29:20 +0100
Message-ID: <8204855.LtI52ktEx1@xps>
In-Reply-To: <1578387392-114282-1-git-send-email-suanmingm@mellanox.com>
References: <1578387392-114282-1-git-send-email-suanmingm@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect pointer operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi,
How this issue was seen? Is it related to the bug reported by Tonghao Zhang?
If yes, you may use "Reported-by:".
One comment about the title, please describe which area is fixed,
instead of "incorrect pointer operation" which is very generic.
The title should probably include the word "meter".
Then in the explanations below, please explain what is the impact of the bug.
Thanks
07/01/2020 09:56, Suanming Mou:
> The meter suffix flow item pointer restore is not correct to minus a
> fixed value. It should minus the real offset it increases.
>
> Set the value to the real offset the pointer increases to fix the issue.
>
> Fixes: 9ea9b049a960 ("net/mlx5: split meter flow")
> Cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Tested-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>