From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dengdui Huang <huangdengdui@huawei.com>, dev@dpdk.org
Cc: stephen@networkplumber.org, aman.deep.singh@intel.com,
yuying.zhang@intel.com, lihuisong@huawei.com,
liuyonglong@huawei.com, liudongdong3@huawei.com
Subject: Re: [PATCH] app/testpmd: support config offloads for all ports
Date: Sat, 11 Nov 2023 02:50:09 +0000 [thread overview]
Message-ID: <820ded2a-d934-4e3d-91c9-9d76d9294348@amd.com> (raw)
In-Reply-To: <20231110091013.1737957-1-huangdengdui@huawei.com>
On 11/10/2023 9:10 AM, Dengdui Huang wrote:
> Support config Rx/Tx offload for all ports in following commands:
> 1. port config all rx_offload (offloading) (on|off)
> 2. port config all tx_offload (offloading) (on|off)
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
<...>
> @@ -11230,6 +11238,79 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = {
> }
> };
>
> +/* Enable/Disable a per port offloading */
>
Comment needs to be updated for 'all' port, and it may be good to add
Rx, like:
/* Enable/Disable all port Rx offloading */
Similar comment is for Tx code.
As this is only a minor change and rest looks good to me, I will update
while merging.
next prev parent reply other threads:[~2023-11-11 2:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 9:10 Dengdui Huang
2023-11-11 2:50 ` Ferruh Yigit [this message]
2023-11-11 3:09 ` Ferruh Yigit
2023-11-11 3:09 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820ded2a-d934-4e3d-91c9-9d76d9294348@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).