From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0098B432F9; Sat, 11 Nov 2023 03:50:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7A1242E02; Sat, 11 Nov 2023 03:50:37 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by mails.dpdk.org (Postfix) with ESMTP id AAFE44025C for ; Sat, 11 Nov 2023 03:50:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NZzXPZC9m+olKO/yIEVlOiurUSCHWZwQDCjoUS2KjWQiSuMG6QuAxtGstaGxnSrm8Xfcp/ZmcI2i163WqQfJwSugjtqfyvijaIIDHS4nvcrrIcsqjsiegueyhKaeSs4BC+DVzPiqwU5q0ieQ7ZeEmfj3HsvCgbhdVp8SUT+d6DLHT7tSwCNrnIjy9Vl1mIo1Y7Z34EH1v8bDi2RGLlg8JGPHfoscCaP8SB+aDuUC413w+8Uf6c3gJYRMFIy8qRagxiJerNOu8xjs8a4xAiQU0gBrUtRulgD7u0CkSutQ+g8g429kgcSOiXtppjb/68VvWBZyC5rU3Rn/+vBCNu6pIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yY87FYzmhlfMKqx4kLllIGhWhH2SaEc2z8tXeoV/vZE=; b=Cx03Fk3yvVDsKvvOO5ihrRk7/tTdMc/H2ikXn17L4RE7AHzgKtYk5dE9NFed0cKamRSc6AROY1piSsSZ4naalQXrS+LnMw2VV/PylL24If112vOTfRwItLskKomZ3GX5k2/xVKToZVDx3jXxvp3s7ty0mpe5QiXZNYgTnEZZqiws1OFnZwdUdnFWnJ8ooa0BuAVChaayQMmj8DRvdiVFn+3ioCUJu8Z8qlJtpBcWbgGjYIDHpW5DmochR8i6SzXrDoSMO+r4amL8k3FaTxNtpgvM9J+JlUUNCOL/37clzZpokXPpATFdIYEX/MKvXvwC0UqlaGoVdSOV4Wn+mkCT2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yY87FYzmhlfMKqx4kLllIGhWhH2SaEc2z8tXeoV/vZE=; b=LF+Vh5ojhigmUMWhI1UOI5hkpb4h0sLnd78u4hZMMO94muR85z6w0kUW3RGoedol/gr6ly5ENowAVVoJxsp0MiZp9EAhil6SmJ/eibHLT9aQtNz1sVGhql2ZXPMDQJ8YDtYvyKE+3nChSKrGxHG17pkoSZVtN4vKL5VsjUhBskU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV8PR12MB9183.namprd12.prod.outlook.com (2603:10b6:408:193::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Sat, 11 Nov 2023 02:50:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Sat, 11 Nov 2023 02:50:33 +0000 Message-ID: <820ded2a-d934-4e3d-91c9-9d76d9294348@amd.com> Date: Sat, 11 Nov 2023 02:50:09 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: support config offloads for all ports Content-Language: en-US To: Dengdui Huang , dev@dpdk.org Cc: stephen@networkplumber.org, aman.deep.singh@intel.com, yuying.zhang@intel.com, lihuisong@huawei.com, liuyonglong@huawei.com, liudongdong3@huawei.com References: <20231110091013.1737957-1-huangdengdui@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231110091013.1737957-1-huangdengdui@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV8PR12MB9183:EE_ X-MS-Office365-Filtering-Correlation-Id: 58a10df2-7c24-4aa9-42d3-08dbe260f96a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HN7RvLOPZA6K1NLatWNUHvaVJYVzZgWvyGKcjbDm+MlzBJS7sUD25Xv005vNdeoOjjZdjlOW/J4rABS7MoKNQ8F6vVSd5iu8LBEyikthn9xnMP2YdHdZLDprR0coBmNrLuDg3brJ1jyuH4GuwQwgDoZaYP5EDnCve1wbtdtGmsPFHmbEvLEIW+tIIHtyLotaL0kfybQ9GQ4f9AQas4OkCO2WYkjQZIOiSV8kwXNxsb6dlnxwq0av0fJ9QxC1klH++VmaaZa0vXJYaV97whc2sU1yjFNplnkaVq7YqKYqugfX4oJzwZpoAtfs4hxiDuBTqUNi2MAbWNb0pELicDiLrCF6LuqUcRb4jGUZ+4rbbeHPMp6uzhSRovcgHAMrhy5dNKNZ11/GKpi/w75aUt7g78Pfvm1o1rX2f6rUG+MyE6XzR2Wf4OM77+8PxCPsu3e2wl+r3ASefFZGzTA1KO3MFmsIzPZJEcBvbBfvC9/Wlygi+4vi304GsIdbZcnqgLdM0m6mXRUuiv1MZis8rdkjrAJGbEC7x5/zrW3ZWJ7GIVI58qGdI29lfT5ZQW52Nphdm/k1PuExA66n2IDvSdu5qvVnkxkreTHtFkhHpFkEZmHcCpsiG4BnKVrEM7wZtocOn23Qc2/u7UiTZ11srtWHXg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(346002)(39860400002)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(36756003)(8936002)(83380400001)(316002)(26005)(66946007)(66556008)(2906002)(4744005)(66476007)(4326008)(44832011)(5660300002)(53546011)(478600001)(6486002)(8676002)(6506007)(6666004)(2616005)(6512007)(31686004)(31696002)(38100700002)(86362001)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YittQlRTay83cGs2cFVzR0ZzbVUrMUw2NEZCTlZ4YVVRS3dkblIzakdCQ2Q3?= =?utf-8?B?dmxCMmtrYk5jb3dnZGVHSTcvQmVJMWpHeTZCTVN5QjEzV0Qzd201RkFYSlhD?= =?utf-8?B?YUUxL1g2NG0yMUdZYld6Z0tRTzR3UmFDbG5LV0Fsb3pCUC9FMjA2R29CSkdM?= =?utf-8?B?UGI4Wm1CT051K1luemN2OUJ5M0xURjhCTnoxM2VzMjlUQ3lPUVdwQS92L1Vy?= =?utf-8?B?azU3RDFlTWFZL0JkTkREeVJ1K0J6UW5KUmNDMm5VMkN0czYyeWRBZ2IrUjIw?= =?utf-8?B?OFBHNnN2eTNSNStGZHBvVnJucStNd01WYy9tODBRcXQ0dmhTWHFaM2t3alVu?= =?utf-8?B?N0QzUU5MVVNqa0RmUk1nckR2RHdPMEZFL3RMa1loRWJEZDFBUjNyOHNGR2VJ?= =?utf-8?B?VlVXOE44dWczbEs4T1NKZ00wQTAraXJ5aVhMUkZqWjkzODFyaFRVdHhhcmZN?= =?utf-8?B?ZEo0WUt5Q09xdXd3QmJ6ZVlNazFLTkdWeHpCSkN5eFdEY0ZDWEp3elA3d3lE?= =?utf-8?B?b0ZGU0pDa0NNVkZ1NmtqN2d3aEd4R0FEOEdKTHpzZzlMREQ4azI1ZG9QN3o1?= =?utf-8?B?eEtkdmVIVUJ4d0xIOGFFRHJVblUydVlXdytiSEhsUzNZcXoxNzEraWVQU1pZ?= =?utf-8?B?MGJrelBEcmJOVW1VQ0tyRk5PS09VcjNJNFFVYjRQeEF1NXJORytzZ2VrSE1m?= =?utf-8?B?M0h4NXJzTmY5QkpBa0JSenJITDZ6K1NmQWNGcnhVekJ1RGVNdjhpVWY0TFNE?= =?utf-8?B?c1EwRHgwT2pldmF2bTZScE5yaGZNT2Q1OGJ5YmJqeC9rVHVKenh3cWxzSFlu?= =?utf-8?B?ajBrQ1U0UjMvaURndnRIV3ZKTWdQNjdFMHJYZFNwQVFKSUNpS0NzVXBmdzlK?= =?utf-8?B?dlhqN05nbDhkTXBlTmFxenBaNXNlUGxKeU9zYmg5ZElZaVRpNjFMUThHMGxl?= =?utf-8?B?aFhvRW1kU29Xd0NPMzByNm5pSUxhVFk4NUlaK1FiZzJPNndQU2xUb2JEZFI0?= =?utf-8?B?dSthQytGOFN2Yzc4SE03SnJBWCtCSHk1Z3h6MjIrSXVQazlHak9wSjBZWkl6?= =?utf-8?B?Z25CL2NMTGpuM1ZUWkxFTTdGZldocGNMamNza2tqenR6OWhzdnpWVmdMeThx?= =?utf-8?B?ekYvWXRsK1dCVTh0K1R6c0J0N1NRSW1SWWVmekZqWlEvVE1lQ2huQ1ZrU0dO?= =?utf-8?B?V3BLMFFYUFZBNCtkZ3pxQ215b1hzc1Z0V3J2UEdQck1VRVNybnVzZ1E4K3JT?= =?utf-8?B?MCtuYXBYbHlTWDFTeENkdmxQVUJnY2tuODR1M3ZVMjBzT1IvaWgwd3ovaG5V?= =?utf-8?B?VDlJYTRuR3NYVGZ1S1V2b3FYTzNlblcyVmlxUWFrQUtQZUY1QXd4S2M2RmRi?= =?utf-8?B?TjRQNG5zVW8yU09HNG9aMzUwd1ZSanJXMzJmQnBERFJuZVpWSUI1ZnJ0WkJN?= =?utf-8?B?bml5a0UvVGx5UkxGZ2l5SlFKbERoVVY5Rks2UWxLQU41UjlOeWlGeEVoaWJu?= =?utf-8?B?MlArSzlRcms2L2RReUZWYW1iQ29BSnVxVFNwc3dsYVNuY2FoL2Z3MWhXSldM?= =?utf-8?B?czMxUWcxdzV1NEVaZFlsU21FOXhGTGZCTWgvR1lLTDByWGc0YXZZSjJCa3Bp?= =?utf-8?B?RTgrNlJ2bC9WaWdjWENCYzcyZTR6dVRiMzVCekhHZFFOd3dySDFPV092V3dR?= =?utf-8?B?TDZKSE5EeXozcENzN2E5R1RyOFpQVjZDbHJOVGRTdkNqam02eS9uVU5VQ01m?= =?utf-8?B?cHV5ZEZZSVNoTXRuSkVDOVA5cUxkN1A1RGVCeGtab0MrcWJidFpBc09LMm0w?= =?utf-8?B?L3Ryb3JUa1VlQm9MejB2ZHBRaUFyTEY2U3FsMGRhRnk5R1plNnp5RS91NzM3?= =?utf-8?B?TUNnL3lhVVZTQXZZc2dhc1ZNUFhqMUtHYWg4YlJEOHZtT2RGSm1NazEwNlVC?= =?utf-8?B?OHgrWVUxdnZlMjI1ekJjbXpzVitEQmk4U1hacThSODEwRWFpYTROR2EvTFVF?= =?utf-8?B?cUoxeWQxTlBzTWxRM3BlS3NpY0E2aXVnei9vSllLT3B2OXpDSmxRWjNnaHQ4?= =?utf-8?B?blRKVWROQy83bmtDRTl0QzVQbXd2UXpHZ1ZVRzB3SlpUcE54Z1RGVkhtRE9S?= =?utf-8?Q?3JV9ERJYYtbd8S97D25Ayk49y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58a10df2-7c24-4aa9-42d3-08dbe260f96a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2023 02:50:33.4752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qi74GwqTAvB0ELDfZfpyjFLD9wDRnw1z+ViwhSH9akMO44CdkSmTQUUgpI4JfWMt X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9183 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2023 9:10 AM, Dengdui Huang wrote: > Support config Rx/Tx offload for all ports in following commands: > 1. port config all rx_offload (offloading) (on|off) > 2. port config all tx_offload (offloading) (on|off) > > Signed-off-by: Dengdui Huang > Acked-by: Chengwen Feng > Reviewed-by: Ferruh Yigit <...> > @@ -11230,6 +11238,79 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = { > } > }; > > +/* Enable/Disable a per port offloading */ > Comment needs to be updated for 'all' port, and it may be good to add Rx, like: /* Enable/Disable all port Rx offloading */ Similar comment is for Tx code. As this is only a minor change and rest looks good to me, I will update while merging.