From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6EF4A04BA; Wed, 7 Oct 2020 11:56:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93F914C9D; Wed, 7 Oct 2020 11:56:18 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3E1362BC7; Wed, 7 Oct 2020 11:56:15 +0200 (CEST) IronPort-SDR: KQHqHSkISGoDojYr6obvRu2xaEJ1KonBVQuVdyuD4Pxn82UXqdyxy2vLvnTw65S7p4+jgD59/I K2u2PHgua4JA== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="229021854" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="229021854" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:56:13 -0700 IronPort-SDR: ahoLPY1JwyTtQx+GjLN2Cgr6+igBsjkXrim+K7GODqGL7lHvB2vJi34qtFwHEaB9rdcyqUEv4c 5zW9+0w+EbBw== X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="461253807" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.102]) ([10.213.193.102]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:56:11 -0700 To: Raslan Darawsheh , "Xueming(Steven) Li" , Matan Azrad , Slava Ovsiienko Cc: "dev@dpdk.org" , Asaf Penso , "stable@dpdk.org" References: <1599711897-21330-1-git-send-email-xuemingl@nvidia.com> From: Ferruh Yigit Message-ID: <8210b384-e788-3aa3-aeaf-7a52687a1b72@intel.com> Date: Wed, 7 Oct 2020 10:56:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: disable flow dump for Verbs flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/6/2020 4:24 PM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: dev On Behalf Of Xueming Li >> Sent: Thursday, September 10, 2020 7:25 AM >> To: Matan Azrad ; Slava Ovsiienko >> >> Cc: dev@dpdk.org; Asaf Penso ; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow >> >> There was a segment fault when dump flows with device argument of >> dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb >> resources were not initialized. It's suggested to use mlx_fs_dump >> for Verbs flow dump. >> >> This patch adds verbs engine check, prints warning message and return >> gracefully. >> >> Cc: stable@dpdk.org >> Signed-off-by: Xueming Li Can you please provide the fixed commit information? That is required to figure out which stable tress to backport. >> --- >> drivers/net/mlx5/mlx5_flow.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c >> index 4c29898203..5a28b80ee4 100644 >> --- a/drivers/net/mlx5/mlx5_flow.c >> +++ b/drivers/net/mlx5/mlx5_flow.c >> @@ -6268,6 +6268,11 @@ mlx5_flow_dev_dump(struct rte_eth_dev *dev, >> struct mlx5_priv *priv = dev->data->dev_private; >> struct mlx5_dev_ctx_shared *sh = priv->sh; >> >> + if (!priv->config.dv_flow_en) { >> + if (fputs("device dv flow disabled\n", file) <= 0) >> + return -errno; >> + return -ENOTSUP; >> + } >> return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh- >>> rx_domain, >> sh->tx_domain, file); >> } >> -- >> 2.25.1 > > Patch applied to next-net-mlx, > > > Kindest regards, > Raslan Darawsheh >