From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id EF0A1C398 for ; Mon, 13 Apr 2015 13:05:33 +0200 (CEST) Received: by widjs5 with SMTP id js5so61744132wid.1 for ; Mon, 13 Apr 2015 04:05:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=F4Ccrma8bd15TszukdP6Rxd6NAbmnjPDUD29xNfWvag=; b=mQ8tt5g4Kn0UmC6+BXaK/lVmS7mA4+BcZ0WOLV+D+BQiVQnDXckeGNMa+GnRnIlhe9 Yngx80eX2Vn1dpCoAstxmGb/pHRaE45WYBhAHTZF5twEbXhAff+I6xqadMdudlNUgysS oIltCeb7fTG4DVvk9AvKD5kVEJ5FdzEPu0qyYej45aPvTVe6psz25PLOqn9YbjQFK08t cjvyCxRO3iVsV5V3wtxx+dOWfdpGKo3WSRBqfjAZld/tPMvDj2mspf5vwiiW93BiAKZm FkYTkpRJHie2E2yZpHFmjG6lfeME9Pi/6E66E4L8utSjNZIbOVZbq+DgMT/ZAQKujrMQ yetA== X-Gm-Message-State: ALoCoQk63YjK08HapYcBJN48Qy68ZO7grIOj/6JnWevRyHl/oQotR6tBG8Pz69MIBh+2sHqTM0+P X-Received: by 10.194.185.68 with SMTP id fa4mr26171856wjc.111.1428923133738; Mon, 13 Apr 2015 04:05:33 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id c3sm11007092wiz.2.2015.04.13.04.05.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2015 04:05:32 -0700 (PDT) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" Date: Mon, 13 Apr 2015 13:04:52 +0200 Message-ID: <8213158.HXtgWEKkcl@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <552B91E5.9070803@intel.com> References: <1428505645-5578-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20150409203409.GB29807@hmsreliant.think-freely.org> <552B91E5.9070803@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 11:05:34 -0000 2015-04-13 10:52, Gonzalez Monroy, Sergio: > On 09/04/2015 21:34, Neil Horman wrote: > > On Thu, Apr 09, 2015 at 08:00:26PM +0300, Avi Kivity wrote: > >> On 04/09/2015 02:19 PM, Neil Horman wrote: > >>> On Thu, Apr 09, 2015 at 12:06:47PM +0300, Avi Kivity wrote: > >>>> On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: > >>>>> On 08/04/2015 19:26, Stephen Hemminger wrote: > >>>>>> On Wed, 8 Apr 2015 16:07:21 +0100 > >>>>>> Sergio Gonzalez Monroy wrote: > >>>>>> > >>>>>>> Currently, the target/rules to build combined libraries is different > >>>>>>> than the one to build individual libraries. > >>>>>>> > >>>>>>> By removing the combined library option as a build configuration option > >>>>>>> we simplify the build pocess by having a single point for > >>>>>>> linking/archiving > >>>>>>> libraries in DPDK. > >>>>>>> > >>>>>>> This patch removes CONFIG_RTE_BUILD_COMBINE_LIB build config option and > >>>>>>> removes the makefiles associated with building a combined library. > >>>>>>> > >>>>>>> The CONFIG_RTE_LIBNAME config option is kept as it will be use to > >>>>>>> always generate a linker script that acts as a single combined library. > >>>>>>> > >>>>>>> Signed-off-by: Sergio Gonzalez Monroy > >>>>>>> > >>>>>> No. We use combined library and it greatly simplfies the application > >>>>>> linking process. > >>>>>> > >>>>> After all the opposition this patch had in v2, I did explain the current > >>>>> issues > >>>>> (see http://dpdk.org/ml/archives/dev/2015-March/015366.html ) and this was > >>>>> the agreed solution. > >>>>> > >>>>> As I mention in the cover letter (also see patch 2/5), building DPDK > >>>>> (after applying this patch series) will always generate a very simple > >>>>> linker script that behaves as a combined library. > >>>>> I encourage you to apply this patch series and try to build your app > >>>>> (which links against combined lib). > >>>>> Your app should build without problem unless I messed up somewhere and it > >>>>> needs fixing. > >>>> Is it possible to generate a pkgconfig file (dpdk.pc) that contains all of > >>>> the setting needed to compile and link with dpdk? That will greatly > >>>> simplify usage. > >>>> > >>>> A linker script is just too esoteric. > >>>> > >>> Why esoteric? We're not talking about a linker script in the sense of a binary > >>> layout file, we're talking about a prewritten/generated libdpdk_core.so that > >>> contains linker directives to include the appropriate libraries. You link it > >>> just like you do any other library, but it lets you ignore how they are broken > >>> up. > >> You mean DT_NEEDED? That's great, but it shouldn't be called a linker > >> script. > >> > > no, I don't mean DT_NEEDED, I mean a linker script, because thats what what > > sergio wrote is. > > > >>> We could certainly do a pkg-config file, but I don't think thats any more > >>> adventageous than this solution. > >> It solves more problems -- cflags etc. Of course having the right DT_NEEDED > >> is a good thing regardless. > >> > > Thats a good point, pkgconfig doesn't provide that additionally. Perhaps having > > both is the best solution. As for the DT_NEEDED issues, the earlier threads > > ennumerated all the problems that were being found with the way the libraries > > were organized (circular dependencies). > > > > Neil > I am not entirely sure of the conclusion of this thread. > > Are we happy with the current linker script solution as a replacement of > the combined lib? > Do we want to provide pkg-config file in addition or instead of linker > script? Yes pkg-config should be an addition on top of shared/static split/combined libraries (or linker script). It should be an alternative to mk/rte.app.mk. > I think I will split the series as there seems to be no objections to > the patches related to DT_NEEDED entries. > I'll post a series for DT_NEEDED entries and another series for dealing > with the combined lib (once we get to an agreement). > > Does it sound reasonable? Yes good idea, thanks.