From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 068DDA00C5; Thu, 15 Sep 2022 12:14:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF43340A7B; Thu, 15 Sep 2022 12:14:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C847840156 for ; Thu, 15 Sep 2022 12:14:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663236872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L0t4l6NYtFJ9bMwivuUqIWC45s1MRuXRfFO4DdHma7A=; b=h6IUkZensZO1UFLm7XuceMSJZk+ZXZaTXDQTHYrFLjj1oHdLYitfQAKlt2q1JGBFd1tEzP 92tjV9F7CkUtcsmuBZEldlK8wZYiOtp2GIzG+FtC+OoY8GRHhSPpiNi/ruoIGr70hFgVaW ZzQrDM1/FXomMU1L2A95nJBnBmacKFg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-636-bko7dzGEPdWf680wM7-Gdw-1; Thu, 15 Sep 2022 06:14:31 -0400 X-MC-Unique: bko7dzGEPdWf680wM7-Gdw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDD4F29AA2E9; Thu, 15 Sep 2022 10:14:30 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62CAC1121314; Thu, 15 Sep 2022 10:14:29 +0000 (UTC) Message-ID: <821b0512-2131-8783-cc1d-833e9cb3b3e3@redhat.com> Date: Thu, 15 Sep 2022 12:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 25/37] baseband/acc100: update log messages To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-26-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-26-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Add extra values for some log messages. No functional impact. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index a302905c78..8898147239 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1170,6 +1170,7 @@ acc100_dev_info_get(struct rte_bbdev *dev, > > /* Read and save the populated config from ACC100 registers */ > fetch_acc100_config(dev); > + /* Check the status of device */ > dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > /* Expose number of queues */ > @@ -3244,7 +3245,7 @@ enqueue_ldpc_enc_one_op_tb(struct acc100_queue *q, struct rte_bbdev_enc_op *op, > { > #ifndef RTE_LIBRTE_BBDEV_SKIP_VALIDATE > if (validate_ldpc_enc_op(op, q) == -1) { > - rte_bbdev_log(ERR, "LDPC encoder validation failed"); > + rte_bbdev_log(ERR, "LDPC encoder validation rejected"); > return -EINVAL; > } > #endif > @@ -4167,8 +4168,9 @@ acc100_enqueue_status(struct rte_bbdev_queue_data *q_data, > { > q_data->enqueue_status = status; > q_data->queue_stats.enqueue_status_count[status]++; > - rte_bbdev_log(WARNING, "Enqueue Status: %d %#"PRIx64"", > - status, > + > + rte_bbdev_log(WARNING, "Enqueue Status: %s %#"PRIx64"", > + rte_bbdev_enqueue_status_str(status), > q_data->queue_stats.enqueue_status_count[status]); > } > > @@ -4863,6 +4865,7 @@ dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data, > return -1; > > rsp.val = atom_desc.rsp.val; > + rte_bbdev_log_debug("Resp. desc %p: %x\n", desc, rsp.val); > > /* Dequeue */ > op = desc->req.op_addr; > @@ -4945,8 +4948,9 @@ dequeue_dec_one_op_tb(struct acc100_queue *q, struct rte_bbdev_dec_op **ref_op, > atom_desc.atom_hdr = __atomic_load_n((uint64_t *)desc, > __ATOMIC_RELAXED); > rsp.val = atom_desc.rsp.val; > - rte_bbdev_log_debug("Resp. desc %p: %x", desc, > - rsp.val); > + rte_bbdev_log_debug("Resp. desc %p: %x r %d c %d\n", > + desc, rsp.val, > + cb_idx, cbs_in_tb); > > op->status |= ((rsp.input_err) > ? (1 << RTE_BBDEV_DATA_ERROR) : 0); Reviewed-by: Maxime Coquelin Thanks, Maxime