From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 51FA8A05D3 for ; Thu, 23 May 2019 10:48:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 392E64F91; Thu, 23 May 2019 10:48:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 02BAC2B9E for ; Thu, 23 May 2019 10:48:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2019 01:48:56 -0700 X-ExtLoop1: 1 Received: from jdcole-mobl1.amr.corp.intel.com (HELO [10.252.22.10]) ([10.252.22.10]) by orsmga003.jf.intel.com with ESMTP; 23 May 2019 01:48:54 -0700 To: nicolas.dichtel@6wind.com, dev@dpdk.org Cc: Olivier Matz , Didier Pallard References: <20190522154143.8041-1-nicolas.dichtel@6wind.com> <07c05411-51bb-2a8c-c941-bc7483683c02@intel.com> <4db07102-c4b0-2e54-634c-3dc576e8c5ef@6wind.com> From: "Burakov, Anatoly" Message-ID: <822475d3-f6a3-f993-2574-8497933d3783@intel.com> Date: Thu, 23 May 2019 09:48:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4db07102-c4b0-2e54-634c-3dc576e8c5ef@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-May-19 5:08 PM, Nicolas Dichtel wrote: > > Le 22/05/2019 à 17:57, Burakov, Anatoly a écrit : >> On 22-May-19 4:41 PM, Nicolas Dichtel wrote: >>> move_pages() is only used to get the numa node id, but this function >>> is not allowed by default in docker (it needs CAP_SYS_NICE and an update of >>> the seccomp profile). >>> get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in >>> the default seccomp profile. >>> >>> Note that the returned value of move_pages() was not checked, thus some >>> errors could be hidden (if the requested id was 0). >>> >>> Signed-off-by: Nicolas Dichtel >>> Reviewed-by: Olivier Matz >>> Reviewed-by: Didier Pallard >>> --- >> >> I can see the check for move_pages and it's a good fix, but what is the relation >> to docker init here? The patch by itself only enables handling of move_pages() >> failure and adds nothing else. The commit message doesn't match the patch in >> question IMO. > I'm not sure to understand your comment. The call to move_pages() is replaced by > a call to get_mempolicy(). > What am I missing? > Oh, apologies, i misread the patch. It is i who was missing something :) > > Regards, > Nicolas > -- Thanks, Anatoly