From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 422D2A0A0A; Tue, 23 Mar 2021 17:02:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4002140F53; Tue, 23 Mar 2021 17:02:53 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 6A9B54069E for ; Tue, 23 Mar 2021 17:02:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DDA585C00D3; Tue, 23 Mar 2021 12:02:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 23 Mar 2021 12:02:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= VX2trFFWpHj7id3AskufOhG2CzuVun5hHPWmz77R03I=; b=BGDJAXGEwGZ8THaD KdiiRmIs8OYGwzA9ALMD3EiFGjzDm3w7JlbO3KJqMLxeEh6+I2ZN7fFoZZnzyjzY 2f7MR2Ua2AcDUQSz752KfT3GzxzsEw5vdNGjHPO66CU6dc68szK6Up5R2oVOhI+j bEyRq97JXNErv57iOkfUdMhDcNsjuMxiG0hgBN5ZXiMeal9okCgEPJKa5GAt/Xhw PV0q8Q0h7PZ6UP5P5YzhvpC4sCdCKTdTGEqgXbZo1jNBWGb65l6ySnN7SKPOddjA lbYTQ6S4Kykvlr8GIWMMxn6BWhkS3uiNlpDZ4FoZYAFQpfre0+q35wUw3QYM5tPE sS5nLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VX2trFFWpHj7id3AskufOhG2CzuVun5hHPWmz77R0 3I=; b=JU1h3m+zX5xaQQJg+A1cAo6QzxQ/ApUEoUuwurwknAnCKeyEpWdi1aY7x RC55cqa8p4KasM4gjkcOHekLQFWXG/RJPq/hM7vKhjYs3OKgyGygvKzzseqv/pz5 S1iYeHQ/BQnAMiSxP0Ej26zBKVsvtQf+D9EgSBV5zjMY2F7k8rFnAlpGQP5gJTGa jcU6NLrqYT8dVxbsdQNGDtgUjMXoA8c7CNd7nd9wyY5KLk3F/lR5DYyN8APiVnO7 SiftK2nM1lFlpSUV8CqH4OPTp6ZdPs4kjJahu+kivAmtF8WUJVIixNzHEQmu8YSH V8VIlPrlaKw6mMAEQgU9ywoY3H/Rw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9D14124041F; Tue, 23 Mar 2021 12:02:50 -0400 (EDT) From: Thomas Monjalon To: Savinay Dharmappa Cc: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, dev@dpdk.org Date: Tue, 23 Mar 2021 17:02:47 +0100 Message-ID: <8237421.lxdJbKsof4@thomas> In-Reply-To: <20210309161002.31384-1-savinay.dharmappa@intel.com> References: <20210309160156.31183-1-savinay.dharmappa@intel.com> <20210309161002.31384-1-savinay.dharmappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/03/2021 17:10, Savinay Dharmappa: > tc ov watermark is initialized with computed value of > max tc ov watermark. Sorry I don't understand what the change is doing. Was there an issue? In the title, please avoid "tc ov" which is meaningless for most of readers I guess. > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > - s->tc_ov_wm = s->tc_ov_wm_max; [...] > + s->tc_ov_wm = s->tc_ov_wm_max;