From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98B56A054F; Mon, 1 Mar 2021 22:44:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52CD54069E; Mon, 1 Mar 2021 22:44:00 +0100 (CET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id A3EA640041 for ; Mon, 1 Mar 2021 22:43:59 +0100 (CET) Received: by mail-wr1-f43.google.com with SMTP id d11so17708202wrj.7 for ; Mon, 01 Mar 2021 13:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=ngIuhvSS0qKj6yHXdVbL6+yFLQ7rNojyfIzp7kUTHeg=; b=hiGfJ7zoN2HpUgBBUuJ1yqGMrNW2TPaEyE+9ds97/Y0AVLxSl98WtXWb0661ohW10X jCK+f5XTI2V1BCBbe61DEDh3WyrCYqXeDDwVhfqodp86jQe1BEsiPKIa7AauyKr9YrXQ H1aV1zcEIH3zsJO4MwItKQiMjhiDvAnj9NTV9a8G1zmuZDab0oeyWcDZGFsI9RH66DXc J4XxWgPv8jIUfFjRlp+aaJhvWMJPgNUsi2vYilDCMCDhWSxzizRtOyJukU2obd40n5SK zb70oBoUBXKROSOlASdcGW00gl+2RK374Pa9H37PiJ6J3tOIuxzxGRwRDeJyipI7BL4P orGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=ngIuhvSS0qKj6yHXdVbL6+yFLQ7rNojyfIzp7kUTHeg=; b=s5mGLIWXJ1z5EB6BYKrZto8BJWK4RL3YTeF1PlWNY0djHqn3QU7AVDISCNMM1y69xy 4kiMXQPPdk/k56x0Qnw4FfiS2PVRZB7VassQ3IgBDqA/sS+MRDylunJMOvSlp8HyY4zF Q88kRoRt6FVtE+VSLMa3fw+2yBSTioBMMWhnwCckMcCFNVwlQ753R8ML8RmyRjoI/PCz wxaRhKWXDe0rajvjx0UoQ0Tkg/CVp1igNcvRNGqC0YyC9xe16W3tRGXNe9BVAfv9k24U 06xLYfmTMzkOtSdTpD58bb+zxSAVNxP1n+npaHtOjIF50c7F1v6/AqMHucD3HEZmnJ6M gTRA== X-Gm-Message-State: AOAM532yK8LWHMOqFIJx6bZ8JtxSkGmdbNSEwHYNyHqmCkm+VPE92Zqw Q9kVEzJDVCoGHyMRP64bHVhx3Q== X-Google-Smtp-Source: ABdhPJxYNGF6ayEpZgxJWgwn9+VLbb+fE+VCx7PIug/GJBzJxfLSKA9ZDpTmu3URKNaHQ+k7K8+GpA== X-Received: by 2002:adf:80e7:: with SMTP id 94mr18657525wrl.5.1614635039376; Mon, 01 Mar 2021 13:43:59 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id n6sm6566066wrt.1.2021.03.01.13.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 13:43:58 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: Ferruh Yigit , dev@dpdk.org, Tyler Retzlaff , Mike Wells , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Jie Zhou References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-5-dmitry.kozliuk@gmail.com> <6c5e9d34-abfa-d808-eef0-165315baf3ce@intel.com> <20210225220440.2bda87c3@sovereign> <20210226021001.73829588@sovereign> Message-ID: <826eb0d3-3c0b-7581-99be-77e9bb6e8fa2@mayadata.io> Date: Mon, 1 Mar 2021 21:43:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226021001.73829588@sovereign> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Complete removal of non-standard dependencies in headers is within a grasp. > Then we can remove shims and include whatever needed. > Thoughts? Sounds good. A couple of 'gotchas' that I've come across (but may not be an issue for DPDK): * Memory allocation / free that spans a dll boundary (see earlier email). * posix_memalign is unfortunately specified as using free(), so we'll either have to modify the calls to rte_posix_memalign / rte_free_memalign (which means code analysis to find which free calls need changing), or wrapper free() to distinguish the two types of memory somehow. I 'solved' this for SPDK by using posix_memalign for everything and I have a vague recollection that the mingw libc does something similar. * Sockets are unfortunately specified as using close(). This is probably easy to address by rte_ wrapping all socket calls. Regards, Nick