From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B01A62B94 for ; Wed, 24 Oct 2018 16:18:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 07:18:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="268415927" Received: from mkovacev-mobl.ger.corp.intel.com (HELO [10.237.221.98]) ([10.237.221.98]) by orsmga005.jf.intel.com with ESMTP; 24 Oct 2018 07:18:13 -0700 To: Akhil Goyal , "dev@dpdk.org" Cc: "roy.fan.zhang@intel.com" , "arkadiuszx.kusztal@intel.com" References: <20181012144501.19562-1-marko.kovacevic@intel.com> <20181017124937.38052-1-marko.kovacevic@intel.com> <20181017124937.38052-3-marko.kovacevic@intel.com> From: Marko Kovacevic Message-ID: <8280df23-7cde-668c-2176-a787daabd457@intel.com> Date: Wed, 24 Oct 2018 15:18:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 2/8] examples/cryptodev_fips_validate: add aes parser and enablement for test types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 14:18:16 -0000 On 24/10/2018 13:37, Akhil Goyal wrote: > > On 10/17/2018 6:19 PM, Marko Kovacevic wrote: >> diff --git a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h >> index beb6bed..5ac858d 100644 >> --- a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h >> +++ b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h >> @@ -23,6 +23,7 @@ >> #define FAX_FILE_PERFIX "fax" >> >> enum fips_test_algorithms { >> + FIPS_TEST_ALGO_AES = 0, >> FIPS_TEST_ALGO_MAX >> }; >> >> @@ -77,6 +78,21 @@ struct fips_test_callback { >> struct fips_val *val; >> }; >> >> +enum fips_aesavs_test_types { >> + AESAVS_TYPE_GFXBOX = 0, >> + AESAVS_TYPE_KEYSBOX, >> + AESAVS_TYPE_VARKEY, >> + AESAVS_TYPE_VARTXT, >> + AESAVS_TYPE_MMT, >> + AESAVS_TYPE_MCT, >> +}; > It would be better to start the enums from 1. Consider a case when an > uninitialized/unsupported type is accidentally used and it would be > treated as AES and would be processed accordingly. sure ill change that