From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 968344618E; Tue, 4 Feb 2025 16:59:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 760C2410E3; Tue, 4 Feb 2025 16:59:33 +0100 (CET) Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) by mails.dpdk.org (Postfix) with ESMTP id E85EC400D6 for ; Tue, 4 Feb 2025 16:59:31 +0100 (CET) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 67F7F11401D0; Tue, 4 Feb 2025 10:59:31 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 04 Feb 2025 10:59:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1738684771; x=1738771171; bh=KHe4nVJbc/ZEjMHZPZmSfAZ2/hX2X3rj50vbFskzEDk=; b= Qt1gxAbKmQ9jiel2jtFcCqoDmS1nGgEJaa5aVnnn9M9oRc39jfDaOPmhemDA0RTh E0K8Rip4vjCflExDn/RdXCi5ehw5gMzbtUlydiOwJ9ZDjZ+uFHyBEwWqNK73e62L 7uGjlJeAf15ydF5cdMWd7dPqoL6s+d89fGnv67+c3/HwUjoNeBU4u3UA0vcWz51Q K39iiyJjM+eSZgyGhfcwh87thA4sEgBbceZuzmnvx3Vi0r+y/vWl1Q2VeNAMcGMF yqqlDiXKOWA9qNpef1iENEwPNi9uzJSi4WMACTPLCf2D2MBNZ3SduXvBvU7YWauW fLvURLYiRBOJp5/+E6OuRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1738684771; x= 1738771171; bh=KHe4nVJbc/ZEjMHZPZmSfAZ2/hX2X3rj50vbFskzEDk=; b=A 6phxRJwFiVCzFlDnNAOXOislmm9RaY8OAguENe8KlEHY7QHIv0NMOTg0oOZutdO+ 3fWHuj6onCd87w5Pm/uqXXuUihhoHkcbLr46mIUBbaG+BWgdz7R+KqZ0of8bTkDk MnWEsWhYgLpY8QEebyh4FW93ggqroxLYx4dFy493rzptAJ0B4AvZiSMasogKyA3L 14DM8fe8IUwTxnJWJcfQJ8qhsyYnhZheVaUsqsA9jXHnjHYJwMukRDWKuRVMbR5z 1CWvOmnWByEZwtS+sRS66PvKKDzjVndOICFtYpz0Q61bGrKNlabzOji3nopTAoWO dCOHJvRosnkQn/MYlfgKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtdelhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdeg keeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvh hiugdrmhgrrhgthhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopeguvghvsegu phgukhdrohhrghdprhgtphhtthhopegsrhhutggvrdhrihgthhgrrhgushhonhesihhnth gvlhdrtghomhdprhgtphhtthhopegrnhgurhgvmhhuvgeslhhinhhugidrmhhitghrohhs ohhfthdrtghomhdprhgtphhtthhopehrohhrvghtiihlrgeslhhinhhugidrmhhitghroh hsohhfthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Feb 2025 10:59:30 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, andremue@linux.microsoft.com, roretzla@linux.microsoft.com Subject: Re: [PATCH] devtools: forbid use of compiler pragmas Date: Tue, 04 Feb 2025 16:59:28 +0100 Message-ID: <8281045.JRmrKFJ9eK@thomas> In-Reply-To: <20250130083741.3258965-1-david.marchand@redhat.com> References: <20250130083741.3258965-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/01/2025 09:37, David Marchand: > Using pragma must be prevented to avoid breaking builds with other > compilers. > Let EAL use them (like for abstraction macros). > > Signed-off-by: David Marchand > --- > + # forbid use of #pragma > + awk -v FOLDERS='lib drivers app examples' \ > + -v SKIP_FILES='lib/eal/include/rte_common.h' \ > + -v EXPRESSIONS='(#pragma|_Pragma)' \ > + -v RET_ON_FAIL=1 \ > + -v MESSAGE='Using compilers pragma is not allowed' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=1 Acked-by: Thomas Monjalon