From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id AF986C38E for ; Sun, 10 May 2015 23:26:20 +0200 (CEST) Received: by wizk4 with SMTP id k4so84284854wiz.1 for ; Sun, 10 May 2015 14:26:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1IYJHEziRUo7xbkZzadqpIcOHPeG0VKCHbis3OCMWyc=; b=ihSZn2Eqf1Ydsi9BivMcGmu/mJnW6nPpO1MktpJn7ZictHScIVNVlsDsMQTqGy3/OL ZOpjbab/inndWM8w1doLGMBiQTYRvkDVxtTwsHKqHI1+jX+i5Z/ZlZwNDXzlEO+7kxqc 67SirHIMFb5lKUc95vDzI+auh5gxOOPa9LiTAh02nWFkVCsN+xxcBLQpA3inyKJ3KoxZ hzcCCjCNbrYrANCC+i8vFRmZIemPMkblu9SGg5u8+LlKp87v4gQGUHSfLaTXkhJwVWnV jC92IMdi83GY22rNirJFeXOV2UrRuRGOHTX9HD4WfzRizLIjnjON7iXEtDthCoYddiNZ CQzA== X-Gm-Message-State: ALoCoQmSkCyUEMr9+Ls+FIuM63mmGbDNSZGwEUUWd/59WsEJqsrJwNmJ1q/iE4whyLlxF7fBTxuj X-Received: by 10.180.187.170 with SMTP id ft10mr14042518wic.75.1431293180484; Sun, 10 May 2015 14:26:20 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u6sm19711861wjy.13.2015.05.10.14.26.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 May 2015 14:26:19 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Sun, 10 May 2015 23:25:38 +0200 Message-ID: <8281433.nBqoHGD3WT@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <1430834880-14482-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com> <1430834880-14482-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] kni: fix compilation issue in KNI vhost on kernel 3.19/4.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 May 2015 21:26:20 -0000 Hi Pablo, 2015-05-05 15:08, Pablo de Lara: > Due to commit c0371da6 in kernel 3.19, which removed msg_iov > and msg_iovlen from struct msghdr, DPDK would not build. > Also, functions memcpy_toiovecend and memcpy_fromiovecend > were removed in commits ba7438ae and 57dd8a07, being substituted by > copy_from_iter and copy_to_iter. >=20 > This patch makes use of struct iov_iter, which has references > to msg_iov and msg_iovln, and makes use of copy_from_iter > and copy_to_iter. >=20 > Changes in v2: > - Replaced functions memcpy_toiovecend and memcpy_fromiovecend > with copy_from_iter and copy_to_iter >=20 > Changes in v3: > - Fixed variable names > - Add missing checks >=20 > Reported-by: Thomas Monjalon > Signed-off-by: Pablo de Lara I have the following errors with Linux 4.0.1: lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: initialization fr= om incompatible pointer type .ndo_bridge_setlink =3D igb_ndo_bridge_setlink, ^ lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: (near initializat= ion for =E2=80=98igb_netdev_ops.ndo_bridge_setlink=E2=80=99) lib/librte_eal/linuxapp/kni/igb_main.c: In function =E2=80=98igb_xmit_f= rame_ring=E2=80=99: lib/librte_eal/linuxapp/kni/igb_main.c:5482:2: error: implicit declarat= ion of function =E2=80=98vlan_tx_tag_present=E2=80=99 if (vlan_tx_tag_present(skb)) { ^ lib/librte_eal/linuxapp/kni/igb_main.c:5484:3: error: implicit declarat= ion of function =E2=80=98vlan_tx_tag_get=E2=80=99 tx_flags |=3D (vlan_tx_tag_get(skb) << IGB_TX_FLAGS_VLAN_SHIFT); ^