From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) by dpdk.org (Postfix) with ESMTP id 69FF1F72 for ; Tue, 8 Nov 2016 10:31:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1272; q=dns/txt; s=iport; t=1478597478; x=1479807078; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=hFd+FH3iv3jMTL1bUWVq3+gaTy5UkvH8BtYlIHcsKnU=; b=EudGIEfW79MZyVeEkHQLMOe1HdkB1MZukg/nuMsSPK5iqqEn1cRiKsQK InYFYgNk/bQb9br5uUEwg98hEjIXgsaoozBiQmGtBuODRrq/tYpyOhYJk lBQGAInm4aUQBieM439qvI3EH3S2tKB72e01D+QkjImySRFMAG9TAExzl 0=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D8AQATmiFY/5xdJa1dHAEBBAEBCgEBg?= =?us-ascii?q?y8BAQEBAR+BVweNMqlGgg+CCIg4PxQBAgEBAQEBAQFiHQuEaCcTUQE+QicEE4h?= =?us-ascii?q?coiSRaFKLSAEBAQEBBQEBAQEBAQEBH4Y+gX0IhmeDYYIvBZouAZBGkBICSZBpA?= =?us-ascii?q?R43eoMxHIFdcoR+gTCBDAEBAQ?= X-IronPort-AV: E=Sophos;i="5.31,609,1473120000"; d="scan'208";a="345827729" Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2016 09:31:17 +0000 Received: from XCH-RCD-016.cisco.com (xch-rcd-016.cisco.com [173.37.102.26]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id uA89VHH8021520 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for ; Tue, 8 Nov 2016 09:31:17 GMT Received: from xch-aln-017.cisco.com (173.36.7.27) by XCH-RCD-016.cisco.com (173.37.102.26) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 8 Nov 2016 03:31:16 -0600 Received: from xch-aln-017.cisco.com ([173.36.7.27]) by XCH-ALN-017.cisco.com ([173.36.7.27]) with mapi id 15.00.1210.000; Tue, 8 Nov 2016 03:31:16 -0600 From: "Pierre Pfister (ppfister)" To: "dev@dpdk.org" Thread-Topic: [PATCH] virtio: tx with can_push when VERSION_1 is set Thread-Index: AQHSOaLaRLG7+j7W/EOP60/1fgXcRg== Date: Tue, 8 Nov 2016 09:31:16 +0000 Message-ID: <82834CFE-767C-41B0-9327-E64B8210E076@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.228.42.38] Content-Type: text/plain; charset="us-ascii" Content-ID: <6DAB4FBD96A9EA48A9ED5AC13FBA9D5A@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] virtio: tx with can_push when VERSION_1 is set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 09:31:18 -0000 Current virtio driver advertises VERSION_1 support, but does not handle device's VERSION_1 support when sending packets (it looks for ANY_LAYOUT feature, which is absent). This patch enables 'can_push' in tx path when VERSION_1 is advertised by the device. This significantly improves small packets forwarding rate towards devices advertising VERSION_1 feature. Signed-off-by: Pierre Pfister --- drivers/net/virtio/virtio_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_r= xtx.c index 724517e..2fe0338 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -925,7 +925,8 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_p= kts, uint16_t nb_pkts) } /* optimize ring usage */ - if (vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) && + if ((vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) || + vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) && rte_mbuf_refcnt_read(txm) =3D=3D 1 && RTE_MBUF_DIRECT(txm) && txm->nb_segs =3D=3D 1 && -- 2.7.4 (Apple Git-66)