From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD22A0A0E; Tue, 11 May 2021 12:49:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EEBF40140; Tue, 11 May 2021 12:49:49 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id E74EF4003E for ; Tue, 11 May 2021 12:49:47 +0200 (CEST) Received: from dggeml753-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FfZNH1hQyz60GF; Tue, 11 May 2021 18:46:23 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggeml753-chm.china.huawei.com (10.1.199.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 18:49:44 +0800 Received: from [127.0.0.1] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 11 May 2021 18:49:44 +0800 To: Thomas Monjalon CC: , , , , , References: <1619662241-61955-1-git-send-email-humin29@huawei.com> <1620186231-35245-1-git-send-email-fengchengwen@huawei.com> <11662132.FWA8Suj1gP@thomas> From: fengchengwen Message-ID: <8284bc61-6bac-0d3d-f676-2a9ea274165d@huawei.com> Date: Tue, 11 May 2021 18:49:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <11662132.FWA8Suj1gP@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3] eal: fix use wrong time API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/5/11 15:36, Thomas Monjalon wrote: > 05/05/2021 05:43, Chengwen Feng: >> Currently, the mp uses gettimeofday() API to get the time, and used as >> timeout parameter. >> >> But the time which gets from gettimeofday() API isn't monotonically >> increasing. The process may fail if the system time is changed. >> >> This fixes it by using clock_gettime() API with monotonic attribution. >> >> Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") >> Fixes: f05e26051c15 ("eal: add IPC asynchronous request") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) >> Acked-by: Morten Brørup >> --- >> v3: >> * add acked-by. >> * change patch's author. > > I did some comments on v2 about potential errors to catch, > but you sent this v3 without participating in v2 discussion. > > Fixed in v4, thanks > > . >