From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90165A09FF; Mon, 4 Jan 2021 17:42:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 464D5160756; Mon, 4 Jan 2021 17:42:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8BEA7160754 for ; Mon, 4 Jan 2021 17:42:49 +0100 (CET) IronPort-SDR: UatGUyr2zqcoRtMIyiz0q76OoKUcpndDUawLKcMX+64kxNIlcjNNnt7QCBYP/Dxo1rWhaRHj/g 4wAGiq03wKuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="174400113" X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="174400113" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 08:42:48 -0800 IronPort-SDR: m7gSbvx9vRoA5t1+wCUO7c9I/16C2Wl4kSSNWd0IQB7JcWbB5omi3KYVaIWzktBIgp37tFcNfy Y7rMPMyGg2eQ== X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="378484965" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.93.148]) ([10.251.93.148]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 08:42:46 -0800 To: "Guo, Jia" , Souvik Dey , "Xing, Beilei" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , Kevin Traynor , Luca Boccassi References: <20201212130525.14656-1-sodey@rbbn.com> <20201215132815.15200-1-sodey@rbbn.com> <04670cb0b85b4b1c90ae264639372754@intel.com> From: Ferruh Yigit Message-ID: <8295f154-93cc-8be7-4697-994e98b5e4be@intel.com> Date: Mon, 4 Jan 2021 16:42:43 +0000 MIME-Version: 1.0 In-Reply-To: <04670cb0b85b4b1c90ae264639372754@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/16/2020 2:09 AM, Guo, Jia wrote: > Acked-by: Jeff Guo > > > From: Souvik Dey > Sent: Tuesday, December 15, 2020 9:28 PM > To: Xing, Beilei ; Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Souvik Dey > Subject: [PATCH v3] net/i40e: issue with ADD VLAN from Guest > > Reset the configuration of vlan strip that would be change > by the pf kernel driver when adding vlan from vf. > Application cannot use rte_eth_dev_set_vlan_offload() to set > the VLAN_STRIP, as this will only work for the first time when > original and current config mismatch, but for all subsequent call > it will be ignored. > > Signed-off-by: Souvik Dey > I suggest title: "net/i40e: fix VLAN stripping in VF" Will update the title and some wording in the commit log while merging. And I assume this should be backported, so will add stable@dpdk.org tag, but can you please confirm the Linux PF behavior was always same? And if the Linux PF behavior was always same, should we add the DPDK commit as fixes commit, @Qi, @Jeff, what do you think? Other question is, does Linux PF and DPDK PF behave differently on enabling VLAN stripping and should it be unified to be consistent?