From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 655592C36 for ; Tue, 20 Mar 2018 15:33:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 07:33:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,335,1517904000"; d="scan'208";a="43683152" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 20 Mar 2018 07:33:31 -0700 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.60]) by fmsmsx107.amr.corp.intel.com ([169.254.6.41]) with mapi id 14.03.0319.002; Tue, 20 Mar 2018 07:33:31 -0700 From: "Luse, Paul E" To: "De Lara Guarch, Pablo" , "'Thomas Monjalon'" CC: "'dev@dpdk.org'" , "Doherty, Declan" , "Harris, James R" , "Verkamp, Daniel" Thread-Topic: [dpdk-dev] Question on AESNI PMD Thread-Index: AdO38lpOBr50FV93SX6Y0kvlI3FInQAAM7ZgABG24YAApu/YwAAZQKoAAA58erAAIF6rMAEYiakg Date: Tue, 20 Mar 2018 14:33:30 +0000 Message-ID: <82C9F782B054C94B9FC04A331649C77AA6B7E96C@fmsmsx104.amr.corp.intel.com> References: <82C9F782B054C94B9FC04A331649C77AA6ABA2B4@fmsmsx104.amr.corp.intel.com> <6138797.4gfP7HpVFi@xps> <82C9F782B054C94B9FC04A331649C77AA6ABEFF1@fmsmsx104.amr.corp.intel.com> <82C9F782B054C94B9FC04A331649C77AA6ABFA05@fmsmsx104.amr.corp.intel.com> <82C9F782B054C94B9FC04A331649C77AA6B03D15@fmsmsx104.amr.corp.intel.com> In-Reply-To: <82C9F782B054C94B9FC04A331649C77AA6B03D15@fmsmsx104.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjA5Y2FlNzEtM2E0NC00MDY3LTg1YmQtNDA1NjI5NTlkMGY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ1OW1qZDlUTjZhemM3Rks0d2ZIMlwvUHgwOHpIZ01WTUdTdGpZR0tSREt5RHI3V2RWb0dqXC9JR00xZUJocE1lNEwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Question on AESNI PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 14:33:33 -0000 Any thoughts on this? -----Original Message----- From: Luse, Paul E=20 Sent: Wednesday, March 14, 2018 5:43 PM To: De Lara Guarch, Pablo ; 'Thomas Monjalo= n' Cc: 'dev@dpdk.org' ; Doherty, Declan ; Harris, James R ; Verkamp, Daniel Subject: RE: [dpdk-dev] Question on AESNI PMD So what do you think - would you like me to clean up my DPDK hack a little = and propose a change to support different external buf_addrs for src/dest o= r did you have something else in mind? Also, it look like I ran into a case where a data buffer of > 32K (the next= increment I tried was 64K) seems to not generate an error but also not enc= rypt the data. Would be good to know if that's a real limitation or not, f= or not I've worked around it in the calling code by breaking things up so t= hat any single crypto op is 32K or less. Thanks Paul -----Original Message----- From: Luse, Paul E Sent: Tuesday, March 13, 2018 12:28 PM To: De Lara Guarch, Pablo ; Thomas Monjalon= Cc: dev@dpdk.org; Doherty, Declan ; Harris, James= R ; Verkamp, Daniel Subject: RE: [dpdk-dev] Question on AESNI PMD Hi Pablo, Thanks for the reply. Wrt your question " Do you mean src and dst using dif= ferent containers (non mbufs), or using mbufs which data is pointing at ano= ther location?" optimally, for storage use cases, something other than m_bu= fs would be great as right now I only use the buf_addr and userdata fields = which sorta answers your question I guess :)=20 Assuming m_bufs is a given for now, I'd like to use one m_buf to describe a= src location that I allocate on my own and assign and a separate m_buf for= a separate destination buffer that I also allocate on my own. That's what = I'm doing now, with a small hack to the function I mention below, and it se= ems to be working good. Thanks! Pau -----Original Message----- From: De Lara Guarch, Pablo Sent: Tuesday, March 13, 2018 12:19 PM To: Luse, Paul E ; Thomas Monjalon Cc: dev@dpdk.org; Doherty, Declan Subject: RE: [dpdk-dev] Question on AESNI PMD Hi Paul, Apologies for the delay. Answers inline. > -----Original Message----- > From: Luse, Paul E > Sent: Tuesday, March 13, 2018 2:16 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; De Lara Guarch, Pablo=20 > ; Doherty, Declan=20 > > Subject: RE: [dpdk-dev] Question on AESNI PMD >=20 > Any thoughts on this? >=20 > Thanks, > Paul >=20 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, March 9, 2018 3:36 PM > To: Luse, Paul E > Cc: dev@dpdk.org; De Lara Guarch, Pablo=20 > ; Doherty, Declan=20 > > Subject: Re: [dpdk-dev] Question on AESNI PMD >=20 > Cc Declan and Pablo, the maintainers >=20 > 09/03/2018 23:08, Luse, Paul E: > > Hi, > > > > I'm working on an SPDK module that uses the DPDK cryptodev > framework, initially I'm using the AESNI PMD and have a few questions.=20 > in the doc it says that only in-place is supported however I see code=20 > in > set_mb_job_params() just after the comment "Mutable crypto operation=20 > parameters" it appears to support a separate src and dst m_buf so=20 > curious about that. > > > > For my use case (storage) I'm using external data buffers so I can't=20 > > use > that code anyways but I was able to make some minor changes and am=20 > able to pass in different src and dst m_bufs that point to my own data=20 > buffers (not in the packet) and it seems to be working fine. > > > > So my 2 questions are: > > > > (1) is the documented in-place limitation simply not correct? You are right, it looks like it is not correct. I need to make sure if the feature is fully supported and we can remove the= limitation. > > > > (2) would there be any upstream interest in supporting a patch that > enables m_bufs using external data buffers for src and dst? Do you mean src and dst using different containers (non mbufs), or using mb= ufs which data is pointing at another location? The first would impact all PMDs and would introduce complexity (plus that w= ould mean an API breakage), that might be unnecessary, whereas the second o= ne is possible to do it from an application point of view (without changing= the API). Thanks, Pablo > > > > Thanks! > > Paul >=20 >=20 >=20 >=20