From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C37F78E56 for ; Thu, 5 Nov 2015 11:44:48 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 05 Nov 2015 02:44:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,247,1444719600"; d="scan'208";a="678838912" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 05 Nov 2015 02:44:47 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Nov 2015 02:44:47 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Nov 2015 02:44:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.199]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.160]) with mapi id 14.03.0248.002; Thu, 5 Nov 2015 18:44:45 +0800 From: "Xu, Qian Q" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload Thread-Index: AQHRFu9RuBd0z9bfVky49JxT4XInnp6LMNoAgAAaWwCAAAdSAIABxy7Q//+DroCAAKEEEA== Date: Thu, 5 Nov 2015 10:44:45 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E03172E9B@shsmsx102.ccr.corp.intel.com> References: <1446634456-413-1-git-send-email-jijiang.liu@intel.com> <4105806.UIj9otbWQy@xps13> <82F45D86ADE5454A95A89742C8D1410E03172DE7@shsmsx102.ccr.corp.intel.com> <3700450.502ikmtvau@xps13> In-Reply-To: <3700450.502ikmtvau@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2015 10:44:49 -0000 OK, I will check it tomorrow.=20 Another comment is that "Legacy vhost + virtio-pmd" is not the common use c= ase. Firstly, in this case, virtio-pmd has no TCP/IP stack, TSO is not very= meaningful; secondly, we can't get performance benefit from this case comp= ared to "Legacy vhost+ legacy virtio". So I'm afraid no customer would like= to try this case since the fake TSO and poor performance.=20 Thanks Qian -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Thursday, November 05, 2015 5:02 PM To: Xu, Qian Q Cc: Liu, Jijiang; dev@dpdk.org; Michael S. Tsirkin Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offlo= ad 2015-11-05 08:49, Xu, Qian Q: > Test Case 1: test_dpdk vhost+ virtio-pmd tso=20 [...] > Test Case 2: test_dpdk vhost+legacy virtio iperf tso [...] > Yes please, I'd like to see a test report showing this virtio running wit= h Linux vhost and without vhost. > We must check that the checksum is well offloaded and sent packets are va= lids. > Thanks Thanks for doing some tests. I had no doubt it works with DPDK vhost. Please could you do some tests without vhost and with kernel vhost? We need to check that the checksum is not missing in such cases.