From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D06375A0C for ; Wed, 23 Mar 2016 02:23:08 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 22 Mar 2016 18:23:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,380,1455004800"; d="scan'208";a="674121894" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2016 18:23:07 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Mar 2016 18:23:07 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Mar 2016 18:23:07 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Wed, 23 Mar 2016 09:23:06 +0800 From: "Xu, Qian Q" To: Thomas Monjalon , Masaru OKI CC: "dev@dpdk.org" , "stephen@networkplumber.org" , "Patel, Rashmin N" , "Shah, Rahul R" Thread-Topic: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error Thread-Index: AQHRg1ngNAN05+WbTUyOW0cloW9xI59mPfnQ Date: Wed, 23 Mar 2016 01:23:05 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E0320DDF3@shsmsx102.ccr.corp.intel.com> References: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com> <2437286.FLD0q4sve1@xps13> In-Reply-To: <2437286.FLD0q4sve1@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y0MDFlZjktYTgxZC00NTEzLTljMTQtMDgyODRkZGFmYzNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InFHM1NYQ1k0aXo5aHRYTitOWDFJYTBWWUxQTE5RT1dCMlYxRHF3U3A3TUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 01:23:09 -0000 In fact, Masaru is the author, and I'm not sure how to detect a VWMARE E100= 0 device, anyone from vmware can check this? Thx.=20 Thanks Qian -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Monday, March 21, 2016 6:08 PM To: Xu, Qian Q; Masaru OKI Cc: dev@dpdk.org; stephen@networkplumber.org Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output erro= r 2016-03-21 17:01, Qian Xu: > INTX is badly emulated in Vmware, INTX toggle check didn't work with=20 > Vmware e1000 device. The patch is to fix the issue. Is it possible to detect a VMware e1000 device? > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > case RTE_INTR_MODE_LEGACY: > - if (pci_intx_mask_supported(dev)) { > - dev_dbg(&dev->dev, "using INTX"); > - udev->info.irq_flags =3D IRQF_SHARED; > - udev->info.irq =3D dev->irq; > - udev->mode =3D RTE_INTR_MODE_LEGACY; > - break; > - } > - dev_notice(&dev->dev, "PCI INTX mask not supported\n"); > + dev_dbg(&dev->dev, "using INTX"); > + udev->info.irq_flags =3D IRQF_SHARED; > + udev->info.irq =3D dev->irq; > + udev->mode =3D RTE_INTR_MODE_LEGACY; > + break; > /* fall back to no IRQ */ > case RTE_INTR_MODE_NONE: This patch is removing the INTX support detection and the fallback to no IR= Q.