DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xu, Qian Q" <qian.q.xu@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get
Date: Thu, 25 Aug 2016 08:36:52 +0000	[thread overview]
Message-ID: <82F45D86ADE5454A95A89742C8D1410E03324D73@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <d410f5d6-f22e-e371-4fea-b19db9fcb426@redhat.com>



-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin
Sent: Thursday, August 25, 2016 3:19 PM
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get



On 08/25/2016 05:03 AM, Yuanhan Liu wrote:
> On Wed, Aug 24, 2016 at 10:11:57AM +0200, Maxime Coquelin wrote:
>>
>>
>> On 08/18/2016 10:48 AM, Yuanhan Liu wrote:
>>> No need to use a pointer to store/retrieve features.
>>>
>>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>>> ---
>>> lib/librte_vhost/vhost_user.c | 20 ++++++++------------
>>> 1 file changed, 8 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/lib/librte_vhost/vhost_user.c 
>>> b/lib/librte_vhost/vhost_user.c index ef4a0c1..eee99e9 100644
>>> --- a/lib/librte_vhost/vhost_user.c
>>> +++ b/lib/librte_vhost/vhost_user.c
>>> @@ -155,23 +155,22 @@ vhost_user_reset_owner(struct virtio_net *dev)
>>> /*
>>>  * The features that we support are requested.
>>>  */
>>> -static int
>>> -vhost_user_get_features(uint64_t *pu)
>>> +static uint64_t
>>> +vhost_user_get_features(void)
>>> {
>>> -	*pu = VHOST_FEATURES;
>>> -	return 0;
>>> +	return VHOST_FEATURES;
>>> }
>>
>> This is not the topic of this series, but I wonder if it could make 
>> sense to be able to override supported features at device init time.
>
> Not quite sure I understood it correctly: is 
> rte_vhost_feature_disable() the answer you are looking for?
Not really.

I meant a per-device supported features, and something you could set also via the vhost PMD options, without needing to recompile.

But maybe it would make more sense to do it a guest level?

Maxime

-------Agreed, as you know we have the vhost PMD port and virtio-user PMD port and we can launch both vhost/virtio on the host, but we 
Can't set the mergeable in the command line, we may need add some feature settings for virtio-user interface. It will be much easier to 
Run tests or application. 

Qian

  reply	other threads:[~2016-08-25  8:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  8:48 [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Yuanhan Liu
2016-08-18  8:48 ` [dpdk-dev] [PATCH 1/7] vhost: remove vhost-cuse Yuanhan Liu
2016-08-22 13:46   ` Thomas Monjalon
2016-08-22 14:09     ` Yuanhan Liu
2016-08-29  6:45     ` Yuanhan Liu
2016-08-24  7:42   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 2/7] vhost: remove sub source dir Yuanhan Liu
2016-08-24  7:44   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 3/7] vhost: refactor source code structure Yuanhan Liu
2016-08-24  7:53   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 4/7] vhost: fold common message handlers Yuanhan Liu
2016-08-24  8:01   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 5/7] vhost: unify function names Yuanhan Liu
2016-08-24  8:02   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 6/7] vhost: get device once Yuanhan Liu
2016-08-24  8:04   ` Maxime Coquelin
2016-08-18  8:48 ` [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get Yuanhan Liu
2016-08-24  8:11   ` Maxime Coquelin
2016-08-25  3:03     ` Yuanhan Liu
2016-08-25  7:18       ` Maxime Coquelin
2016-08-25  8:36         ` Xu, Qian Q [this message]
2016-08-25  9:10           ` Maxime Coquelin
2016-08-26  4:15         ` Yuanhan Liu
2016-08-24  7:30 ` [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Xu, Qian Q
2016-08-24  7:47   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82F45D86ADE5454A95A89742C8D1410E03324D73@shsmsx102.ccr.corp.intel.com \
    --to=qian.q.xu@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).