From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E8A442935 for ; Mon, 10 Oct 2016 12:12:56 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 10 Oct 2016 03:12:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="770824312" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2016 03:12:56 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 03:12:55 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 03:12:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 18:12:53 +0800 From: "Xu, Qian Q" To: Yuanhan Liu CC: "dev@dpdk.org" , Maxime Coquelin Thread-Topic: [dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy Thread-Index: AQHSFVDqzmgwdw6bVEGvN7mzPH4lkqCbkgeggANfxoCAAqDYQA== Date: Mon, 10 Oct 2016 10:12:52 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E392005B2@shsmsx102.ccr.corp.intel.com> References: <1471939839-29778-1-git-send-email-yuanhan.liu@linux.intel.com> <1474604007-5221-1-git-send-email-yuanhan.liu@linux.intel.com> <1474604007-5221-5-git-send-email-yuanhan.liu@linux.intel.com> <82F45D86ADE5454A95A89742C8D1410E391FCDA5@shsmsx102.ccr.corp.intel.com> <20161009020305.GM1597@yliu-dev.sh.intel.com> In-Reply-To: <20161009020305.GM1597@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 10:12:57 -0000 Good to know. I will try v3. BTW, on the master branch, seems vhost PMD is = broken. When we run --vdev 'eth_vhost0,xxxx', then it will report the error= that the driver is not supported. V16.07 is OK, but I haven't got time to= do git bisect.=20 -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Sunday, October 9, 2016 3:03 AM To: Xu, Qian Q Cc: dev@dpdk.org; Maxime Coquelin Subject: Re: [dpdk-dev] [PATCH v2 4/7] vhost: add dequeue zero copy On Thu, Oct 06, 2016 at 02:37:27PM +0000, Xu, Qian Q wrote: > this function copy_desc_to_mbuf has changed on the dpdk-next-virtio repo.= Based on current dpdk-next-virtio repo, the commit ID is as below:=20 > commit b4f7b43cd9d3b6413f41221051d03a23bc5f5fbe > Author: Zhiyong Yang > Date: Thu Sep 29 20:35:49 2016 +0800 >=20 > Then you will find the parameter "struct vhost_virtqueue *vq" is removed,= so if apply your patch on that commit ID, the build will fail, since no vq= definition but we used it in the function.=20 > Could you check? Thx.=20 I knew that: a rebase is needed, and I have done the rebase (locally); just= haven't sent it out yet. --yliu >=20 > =3D=3D Build lib/librte_table > /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c: In function 'copy_de= sc_to_mbuf': > /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c:745:21: error: 'vq' u= ndeclared (first use in this function) > zmbuf =3D get_zmbuf(vq); > ^ > /home/qxu10/dpdk-zero/lib/librte_vhost/virtio_net.c:745:21: note: each=20 > undeclared identifier is reported only once for each function it=20 > appears in > /home/qxu10/dpdk-zero/mk/internal/rte.compile-pre.mk:138: recipe for=20 > target 'virtio_net.o' failed > make[5]: *** [virtio_net.o] Error 1 > /home/qxu10/dpdk-zero/mk/rte.subdir.mk:61: recipe for target=20 > 'librte_vhost' failed > make[4]: *** [librte_vhost] Error 2 > make[4]: *** Waiting for unfinished jobs.... >=20