From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1A1B51E2B; Mon, 9 Jan 2017 09:02:19 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 09 Jan 2017 00:02:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="920393439" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2017 00:02:17 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 9 Jan 2017 00:02:17 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 9 Jan 2017 00:02:17 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 16:02:15 +0800 From: "Xu, Qian Q" To: Yuanhan Liu , Stephen Hemminger , "Wei, FangfangX" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Liu, Yong" Thread-Topic: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process Thread-Index: AQHSagUcTGImkiKufky+0h0FLNfmCKEvFbSAgACx1XA= Date: Mon, 9 Jan 2017 08:02:14 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E3B4D643B@shsmsx102.ccr.corp.intel.com> References: <1482922962-21036-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-3-git-send-email-yuanhan.liu@linux.intel.com> <20170108151500.3272484c@xeon-e3> <20170109051919.GB21228@yliu-dev.sh.intel.com> In-Reply-To: <20170109051919.GB21228@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 08:02:20 -0000 Fangfang,=20 Could you help double confirm below error and the patchset ? Thanks.=20 http://dpdk.org/patch/18975 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, January 9, 2017 1:19 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; stable@dpdk.org; Xu, Qian Q ; Liu, > Yong > Subject: Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method= for > secondary process >=20 > On Sun, Jan 08, 2017 at 03:15:00PM -0800, Stephen Hemminger wrote: > > On Fri, 6 Jan 2017 18:16:16 +0800 > > Yuanhan Liu wrote: > > > > > If the primary enables the vector Rx/Tx path, the current code would > > > let the secondary always choose the non vector Rx/Tx path. This > > > results to a Rx/Tx method mismatch between primary and secondary > > > process. Werid errors then may happen, something like: > > > > > > PMD: virtio_xmit_pkts() tx: virtqueue_enqueue error: -14 > > > > > > Fix it by choosing the correct Rx/Tx callbacks for the secondary proc= ess. > > > That is, use vector path if it's given. > > > > > > Fixes: 8d8393fb1861 ("virtio: pick simple Rx/Tx") > > > > > > Cc: stable@dpdk.org > > > Signed-off-by: Yuanhan Liu > > > > This is failing on intel compile tests. > > > > > > http://dpdk.org/patch/18975 >=20 > Thanks, but it looks like a false alarm to me, for reasons below. >=20 > > Failed Build #2: > > OS: RHEL7.2_64 > > Target: x86_64-native-linuxapp-gcc > > MKRES test_resource_c.res.o /home/patchWorkOrg/compilation/x86_64- > native-linuxapp-gcc/lib/librte_ethdev.a(rte_ethdev.o): In function > `rte_eth_dev_pci_probe': > > rte_ethdev.c:(.text+0x9c4): undefined reference to > `eth_dev_attach_secondary' > > collect2: error: ld returned 1 exit status >=20 > - eth_dev_attach_secondary is not defined in this patch, it's defined > (and used) in the first patch. >=20 > - eth_dev_attach_secondary is actually defined; The report even shows > it fails to build with gcc: the gcc build passes on my dev box. >=20 > Honestly, I seldom trusted the build reports from STV. >=20 > --yliu