From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option
Date: Thu, 11 Jan 2018 17:50:19 +0000 [thread overview]
Message-ID: <82b1a4c3-ba00-aa4e-2576-517cbe01b977@intel.com> (raw)
In-Reply-To: <20171108004106.5072-1-thomas@monjalon.net>
On 11/8/2017 12:41 AM, Thomas Monjalon wrote:
> The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH
> has been added just before the 17.11 release.
> Such new options are forbidden and must be replaced by a run-time option.
> If it is not replaced in 18.02-rc1, this removal will be applied.
I hope this is not forgotten!
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> config/common_base | 1 -
> drivers/net/qede/qede_ethdev.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index 34f04a9fe..9ae5ec30f 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -415,7 +415,6 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
> CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
> CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
> CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
> #Provides abs path/name of the firmware file.
> #Empty string denotes driver will use default firmware
> CONFIG_RTE_LIBRTE_QEDE_FW=""
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index 883214515..0de3a2760 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -453,12 +453,10 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
> params.update_vport_active_tx_flg = 1;
> params.vport_active_rx_flg = flg;
> params.vport_active_tx_flg = flg;
> -#ifndef RTE_LIBRTE_QEDE_VF_TX_SWITCH
> if (IS_VF(edev)) {
> params.update_tx_switching_flg = 1;
> params.tx_switching_flg = !flg;
> }
> -#endif
> for_each_hwfn(edev, i) {
> p_hwfn = &edev->hwfns[i];
> params.opaque_fid = p_hwfn->hw_info.opaque_fid;
>
next prev parent reply other threads:[~2018-01-11 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 0:41 Thomas Monjalon
2018-01-11 17:50 ` Ferruh Yigit [this message]
2018-01-11 19:03 ` Mody, Rasesh
2018-01-12 22:00 ` Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b1a4c3-ba00-aa4e-2576-517cbe01b977@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=rasesh.mody@cavium.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).