From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E14101B2A0 for ; Thu, 11 Jan 2018 18:50:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 09:50:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,345,1511856000"; d="scan'208";a="9400456" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga002.fm.intel.com with ESMTP; 11 Jan 2018 09:50:19 -0800 To: Thomas Monjalon , Rasesh Mody , Harish Patil Cc: dev@dpdk.org References: <20171108004106.5072-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <82b1a4c3-ba00-aa4e-2576-517cbe01b977@intel.com> Date: Thu, 11 Jan 2018 17:50:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20171108004106.5072-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 17:50:23 -0000 On 11/8/2017 12:41 AM, Thomas Monjalon wrote: > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH > has been added just before the 17.11 release. > Such new options are forbidden and must be replaced by a run-time option. > If it is not replaced in 18.02-rc1, this removal will be applied. I hope this is not forgotten! > > Signed-off-by: Thomas Monjalon > --- > config/common_base | 1 - > drivers/net/qede/qede_ethdev.c | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/config/common_base b/config/common_base > index 34f04a9fe..9ae5ec30f 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -415,7 +415,6 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n > CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n > -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n > #Provides abs path/name of the firmware file. > #Empty string denotes driver will use default firmware > CONFIG_RTE_LIBRTE_QEDE_FW="" > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index 883214515..0de3a2760 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -453,12 +453,10 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg) > params.update_vport_active_tx_flg = 1; > params.vport_active_rx_flg = flg; > params.vport_active_tx_flg = flg; > -#ifndef RTE_LIBRTE_QEDE_VF_TX_SWITCH > if (IS_VF(edev)) { > params.update_tx_switching_flg = 1; > params.tx_switching_flg = !flg; > } > -#endif > for_each_hwfn(edev, i) { > p_hwfn = &edev->hwfns[i]; > params.opaque_fid = p_hwfn->hw_info.opaque_fid; >