From: "Minggang(Gavin) Li" <gavinl@nvidia.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH V2] net/mlx5: add support for flows targeting multicast MAC addresses
Date: Fri, 15 Aug 2025 09:55:10 +0800 [thread overview]
Message-ID: <82b383fa-80bb-47a4-8a58-23b0573db3b4@nvidia.com> (raw)
In-Reply-To: <3720215.hdfAi7Kttb@thomas>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On 8/14/2025 10:05 PM, Thomas Monjalon wrote:
> 14/08/2025 12:08, Gavin Li:
>> Rules for multicast MAC addresses are intended to filter multicast traffic
>> and are managed through multicast MAC add/remove APIs. In mlx5_dev_spawn
>> function, devices (PF, VFs, and SFs) retrieve the netdev-configured MAC
>> addresses via netlink and store them in the PMD device data, which
>> includes multicast MAC addresses.
>>
>> To update multicast MAC address rules, create them within
>> mlx5_traffic_enable.
> Sorry this is not clear.
> Please explain what was the previous behaviour with a past tense,
> and what is the new changed behaviour.
ACK
>> BITFIELD_DECLARE(mac_own, uint64_t, MLX5_MAX_MAC_ADDRESSES);
>> + BITFIELD_DECLARE(mac_pmd, uint64_t, MLX5_MAX_MAC_ADDRESSES);
> Not sure about the naming.
> What is the difference between mac_own and mac_pmd?
mac_own serves as a flag for MAC addresses, indicating that they were
added for VF by pmd. This flag is useful for the flush API, which can
clear flows associated with VF MAC addresses. Similarly, mac_pmd is used
to show that a MAC address was added by pmd for PF, VF, and SFs. It
helps differentiate MAC addresses that have been synchronized from the
kernel driver.
>
[-- Attachment #2: Type: text/html, Size: 2810 bytes --]
prev parent reply other threads:[~2025-08-15 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 10:08 Gavin Li
2025-08-14 14:05 ` Thomas Monjalon
2025-08-15 1:55 ` Minggang(Gavin) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b383fa-80bb-47a4-8a58-23b0573db3b4@nvidia.com \
--to=gavinl@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).