* [PATCH] net/nfp: remove unneeded header inclusion
@ 2022-04-08 9:41 David Marchand
2022-04-21 11:14 ` Niklas Soderlund
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-04-08 9:41 UTC (permalink / raw)
To: dev; +Cc: Niklas Soderlund
Looking at this driver history, there was never a need for including
execinfo.h.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index bad80a5a1c..08bc4e8ef2 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -16,9 +16,6 @@
#include <assert.h>
#include <stdio.h>
-#if defined(RTE_BACKTRACE)
-#include <execinfo.h>
-#endif
#include <stdlib.h>
#include <unistd.h>
#include <stdint.h>
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/nfp: remove unneeded header inclusion
2022-04-08 9:41 [PATCH] net/nfp: remove unneeded header inclusion David Marchand
@ 2022-04-21 11:14 ` Niklas Soderlund
2022-05-04 12:31 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Soderlund @ 2022-04-21 11:14 UTC (permalink / raw)
To: David Marchand; +Cc: dev
Hi David,
Thanks for your work.
On 2022-04-08 11:41:16 +0200, David Marchand wrote:
> Looking at this driver history, there was never a need for including
> execinfo.h.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index bad80a5a1c..08bc4e8ef2 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -16,9 +16,6 @@
>
> #include <assert.h>
> #include <stdio.h>
> -#if defined(RTE_BACKTRACE)
> -#include <execinfo.h>
> -#endif
> #include <stdlib.h>
> #include <unistd.h>
> #include <stdint.h>
> --
> 2.23.0
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/nfp: remove unneeded header inclusion
2022-04-21 11:14 ` Niklas Soderlund
@ 2022-05-04 12:31 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2022-05-04 12:31 UTC (permalink / raw)
To: Niklas Soderlund, David Marchand; +Cc: dev
On 4/21/2022 12:14 PM, Niklas Soderlund wrote:
> Hi David,
>
> Thanks for your work.
>
> On 2022-04-08 11:41:16 +0200, David Marchand wrote:
>> Looking at this driver history, there was never a need for including
>> execinfo.h.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>
Fixes: bdbf45c24b07 ("net/nfp: fix build with musl libc")
Cc: stable@dpdk.org
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-04 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 9:41 [PATCH] net/nfp: remove unneeded header inclusion David Marchand
2022-04-21 11:14 ` Niklas Soderlund
2022-05-04 12:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).