From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A0BE5D1BB for ; Tue, 28 Mar 2017 10:47:50 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 28 Mar 2017 01:47:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="948934460" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2017 01:47:48 -0700 To: Thomas Monjalon References: <1489558767-56329-2-git-send-email-david.hunt@intel.com> <1490004522-183515-1-git-send-email-david.hunt@intel.com> <1490004522-183515-8-git-send-email-david.hunt@intel.com> <1739985.xpKzEM05ln@xps13> Cc: dev@dpdk.org, bruce.richardson@intel.com From: "Hunt, David" Message-ID: <82bde780-5547-c574-0f63-08a86c065d31@intel.com> Date: Tue, 28 Mar 2017 09:47:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1739985.xpKzEM05ln@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 07/18] lib: make v20 header file private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 08:47:51 -0000 On 27/3/2017 2:10 PM, Thomas Monjalon wrote: > 2017-03-20 10:08, David Hunt: >> Signed-off-by: David Hunt >> Acked-by: Bruce Richardson > [...] >> SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h >> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h > There is no explanation for this change. > I think it would be clearer if squashed with the previous patch, > switching to the new API. > > Let me know, I can squash it myself :) Sure, makes sense to squash this one. Please do. :) Thanks, Dave.