From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 63A512C36 for ; Thu, 28 Sep 2017 18:05:26 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2017 09:05:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,450,1500966000"; d="scan'208";a="904797295" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2017 09:05:24 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170928141329.73874-1-ajit.khaparde@broadcom.com> <20170928141329.73874-19-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <82c7d78a-8af2-1523-2bab-4ca6e79e45b6@intel.com> Date: Thu, 28 Sep 2017 17:05:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928141329.73874-19-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 18/24] net/bnxt: add support for flow filter ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 16:05:26 -0000 On 9/28/2017 3:13 PM, Ajit Khaparde wrote: > This patch adds support for flow validate/create/destroy/flush, > ethertype add/del ops > > Signed-off-by: Ajit Khaparde > -- > v1->v2: incorporate review comments. > v2->v3: fix 32-bit builds. <...> > +static struct rte_flow * > +bnxt_flow_create(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct rte_flow_error *error) > +{ > + struct bnxt *bp = (struct bnxt *)dev->data->dev_private; > + struct bnxt_filter_info *filter; > + struct bnxt_vnic_info *vnic; > + struct rte_flow *flow; > + unsigned int i; > + int ret = 0; > + > + flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0); > + if (!flow) { > + rte_flow_error_set(error, ENOMEM, > + RTE_FLOW_ERROR_TYPE_HANDLE, NULL, > + "Failed to allocate memory"); > + return flow; > + } > + > + ret = bnxt_flow_agrs_validate(attr, pattern, actions, error); > + if (ret != 0) { Hi Ajit, clang is giving following [1] build error here. Error log is quite verbose, clang even suggests multiple solutions :) [1] .../dpdk/drivers/net/bnxt/bnxt_filter.c:923:6: error: variable 'filter' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (ret != 0) { ^~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_filter.c:965:23: note: uninitialized use occurs here bnxt_free_filter(bp, filter); ^~~~~~ .../dpdk/drivers/net/bnxt/bnxt_filter.c:923:2: note: remove the 'if' if its condition is always false if (ret != 0) { ^~~~~~~~~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_filter.c:908:33: note: initialize the variable 'filter' to silence this warning struct bnxt_filter_info *filter; ^ = NULL