From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 01C4C37A2 for ; Wed, 1 May 2019 12:10:36 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id p16so773551wma.1 for ; Wed, 01 May 2019 03:10:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Q9TGKTaKg7Rph3Ys+mykUXXwBIG2BtIyBIheDvFSQn8=; b=D6i1LP9K/J4aw2b5Cww++StRoUTFRHgyPxGFXrEY+vWfLi3WysPAq+Hro9dc5LgNfJ bK0sY0apGBvPbYCY4ItIKRVuMIBgdhpZIyN2Q/ZMAAxbeS+ejTkiH6pa0WbO5pj/gJjU 6QKOZcwJoO7LBag/1XJB6Yp0t8Zpf1wfS9t/45Du/wQhZytPfcROpEyhoteI69GBBbZC UWw+EoP3HVwsQ8/TjYrttGUNBAZw3jzLKfp5FA09pDqwkWh6HCTENL/bJIA89aDZslA2 yhAoFZtnJFjJKRl77gAy9TSbuQ/3CIlODek/gsOVFCdBUcRCR1Ggj+m59psy9i502aR/ moHw== X-Gm-Message-State: APjAAAWAnaOu7JrxPFq/oDehkjiWjq6oGpG+l9e8T1EE84fqH4tcjvkY ZYiqcfIAY6hRLJI9wLa3gqs= X-Google-Smtp-Source: APXvYqznOqeAX1wXU1vtDHmozYgsM9e6OvZlSPddm8Kz/msUAAQA5h7f/AskXXs7AotbSdiKuq/sCQ== X-Received: by 2002:a7b:cb4e:: with SMTP id v14mr5953778wmj.52.1556705436556; Wed, 01 May 2019 03:10:36 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a4sm6808833wmf.45.2019.05.01.03.10.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 03:10:35 -0700 (PDT) Message-ID: <82d1bf3148ba860598ce98c68ff96fec960fd1c7.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net Date: Wed, 01 May 2019 11:10:35 +0100 In-Reply-To: <20190426165043.17268-4-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 10:10:37 -0000 On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The post-install script to symlink the PMDs from their own PMD > directory to > the regular lib directory (so they would be found by ld at runtime) > was > using the "-r" flag to ln to create relative symlinks. This flag is > unsupported by ln on FreeBSD causing the ninja install step to fail. >=20 > Reworking the script to take the relative driver path as parameter > removes > the need for ln to calculate the relative path ensuring compatibility > with > FreeBSD. >=20 > As part of the fix, we move the registration of the install script to > the > config/meson.build file, from the top level one. This improves > readability > as the script takes as parameters the variables set in that file. >=20 > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory") >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > buildtools/symlink-drivers-solibs.sh | 7 ++++--- > config/meson.build | 7 +++++++ > meson.build | 7 ------- > 3 files changed, 11 insertions(+), 10 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A513EA0AC5 for ; Wed, 1 May 2019 12:10:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 698ED397D; Wed, 1 May 2019 12:10:37 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 01C4C37A2 for ; Wed, 1 May 2019 12:10:36 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id p16so773551wma.1 for ; Wed, 01 May 2019 03:10:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Q9TGKTaKg7Rph3Ys+mykUXXwBIG2BtIyBIheDvFSQn8=; b=D6i1LP9K/J4aw2b5Cww++StRoUTFRHgyPxGFXrEY+vWfLi3WysPAq+Hro9dc5LgNfJ bK0sY0apGBvPbYCY4ItIKRVuMIBgdhpZIyN2Q/ZMAAxbeS+ejTkiH6pa0WbO5pj/gJjU 6QKOZcwJoO7LBag/1XJB6Yp0t8Zpf1wfS9t/45Du/wQhZytPfcROpEyhoteI69GBBbZC UWw+EoP3HVwsQ8/TjYrttGUNBAZw3jzLKfp5FA09pDqwkWh6HCTENL/bJIA89aDZslA2 yhAoFZtnJFjJKRl77gAy9TSbuQ/3CIlODek/gsOVFCdBUcRCR1Ggj+m59psy9i502aR/ moHw== X-Gm-Message-State: APjAAAWAnaOu7JrxPFq/oDehkjiWjq6oGpG+l9e8T1EE84fqH4tcjvkY ZYiqcfIAY6hRLJI9wLa3gqs= X-Google-Smtp-Source: APXvYqznOqeAX1wXU1vtDHmozYgsM9e6OvZlSPddm8Kz/msUAAQA5h7f/AskXXs7AotbSdiKuq/sCQ== X-Received: by 2002:a7b:cb4e:: with SMTP id v14mr5953778wmj.52.1556705436556; Wed, 01 May 2019 03:10:36 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a4sm6808833wmf.45.2019.05.01.03.10.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 03:10:35 -0700 (PDT) Message-ID: <82d1bf3148ba860598ce98c68ff96fec960fd1c7.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net Date: Wed, 01 May 2019 11:10:35 +0100 In-Reply-To: <20190426165043.17268-4-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190501101035.uBNIyXjlig4fjawlzZQp-gzVtXd1YuNQBhSexyhg5Js@z> On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The post-install script to symlink the PMDs from their own PMD > directory to > the regular lib directory (so they would be found by ld at runtime) > was > using the "-r" flag to ln to create relative symlinks. This flag is > unsupported by ln on FreeBSD causing the ninja install step to fail. >=20 > Reworking the script to take the relative driver path as parameter > removes > the need for ln to calculate the relative path ensuring compatibility > with > FreeBSD. >=20 > As part of the fix, we move the registration of the install script to > the > config/meson.build file, from the top level one. This improves > readability > as the script takes as parameters the variables set in that file. >=20 > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory") >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > buildtools/symlink-drivers-solibs.sh | 7 ++++--- > config/meson.build | 7 +++++++ > meson.build | 7 ------- > 3 files changed, 11 insertions(+), 10 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi