From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4621A00C5; Mon, 26 Dec 2022 05:54:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B8E040146; Mon, 26 Dec 2022 05:54:00 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 5AD7F40143 for ; Mon, 26 Dec 2022 05:53:59 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NgQQ36zC6z16Lp2; Mon, 26 Dec 2022 12:52:43 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 26 Dec 2022 12:53:57 +0800 Subject: Re: [PATCH v5 2/5] telemetry: fix repeated display when callback don't set dict To: Bruce Richardson CC: , , , , , References: <20221219090723.29356-1-fengchengwen@huawei.com> <20221219090723.29356-3-fengchengwen@huawei.com> From: fengchengwen Message-ID: <82dd43d3-661f-64dc-8ce0-a7b6b2a62d79@huawei.com> Date: Mon, 26 Dec 2022 12:53:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022/12/19 17:33, Bruce Richardson wrote: > On Mon, Dec 19, 2022 at 09:07:20AM +0000, Chengwen Feng wrote: >> When telemetry callback didn't set dict and return a non-negative >> number, the telemetry will repeat to display the last result. >> >> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> --- > > Hi Chengwen, > > I'm a little curious about this bug. Can you describe some steps to > reproduce it as I'm curious as to exactly what is happening. The fix seems > a little strange to me so I'd like to investigate a little more to see if > other approaches might work. Hi Bruce, Sorry for late reply. The steps: 1. applay "[PATCH v5 1/5] dmadev: support stats reset telemetry command" 2. compile 3. start dpdk-dma: dpdk-dma -a DMA.BDF -a NIC.BDF -- -c hw 4. start telemetry, and execute /dmadev/stats,0, and then /dmadev/stats_reset,0 the output of /dmadev/stats_reset,0 will be the same of previous cmd "/dmadev/stats,0" e.g. my environment: --> /dmadev/stats,0 { "/dmadev/stats": { "submitted": 23, "completed": 23, "errors": 0 } } --> /dmadev/stats_reset,0 { "/dmadev/stats_reset": { "submitted": 23, "completed": 23, "errors": 0 } } The rootcause is that the /dmadev/stats_reset don't set the outer parameter "struct rte_tel_data *info" and return zero. BTW: although the telemetry mainly used to query, but some reset counter maybe usefull, and it already exist like: "/eventdev/rxa_stats_reset" and this patchset. > > Thanks, > /Bruce > . >