From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD822A00C2; Thu, 16 Jun 2022 19:03:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FF2340FAE; Thu, 16 Jun 2022 19:03:54 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) by mails.dpdk.org (Postfix) with ESMTP id C79D740141 for ; Thu, 16 Jun 2022 19:03:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8sICk+QdHd1rtdT6B8erAAL01n5/O/T0kzZJxsZcMdutCZPSj+YuDUnAr5sCpOz4boZwT1XkqLVTo++pioJ5I4pJO7S6YnKBrdvxaHRnvcNKqzRRAiMi7JvScwoPTSH/uFPvvg0750OEPkBr0jrQKxy++qTArYp0PoNdt/VUGmBUH9kHaaMY/7fXZ4hXOSFtbnHwSHQUzhz7nAZeD7SDMUcb1FhywWQVB+f/+S5DcTDGM3MRSWtpfz/wGFqKrFrYQafgZP5QzpmwPolekB8lTjmmiiikCMRE+vJcdsorSL4nCcEpDmDepRFY99eKDEAbS90LbPcZJGzcL3PXVk4tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVnVACmShd9hr1rLRGOrX/5FzCuWqrtfCQbTqhy0Dyo=; b=ZY1vFBjrFSw64j2dj9wPbn47cw7TZBjBPtM/SSldiTRY1ZeniWRlr2Bs6R9iaCqqGOAg+V3UJ0akVlwqhfaKGUROrbkowBdvAb3/RpisTXuGWeQf+hWlVMfKfteMTXQ2TOSBMHE62sTH79VLVO4g4+c+DDJHBFFvpUbHcGVsdMdqPTGhL25famKbiJIlZM2Nse8ts56MINs9xAuXL87nMvzMPzBen1UosZWS19Fwyt9G55Lu3R+tDSHKgfgf99au6goe4rT+c3jQc6t+2hK+u/mKw38UXJspyAZsQP/Xid5I+9BZSRG3EH3tf46Hz8MWE7YN59ZSdzSPL6QstxwBtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=broadcom.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVnVACmShd9hr1rLRGOrX/5FzCuWqrtfCQbTqhy0Dyo=; b=GyLu1nY5tkuc7Jyjtq5RTF3d7otGBEdAo/4gKIQiYAXNlfr+3k1BVrPb28OQALeZchMepLUfkHCEZm/vAPXen42VAQdRdpmLcL3PEJSBraUsiE79E+P5wXIAlTUC82FS+c1c37CnI/w0WpbZAy+Lp1ylqeZSAipzWu3y1Ryiu1U= Received: from DM6PR02CA0059.namprd02.prod.outlook.com (2603:10b6:5:177::36) by MWHPR02MB2558.namprd02.prod.outlook.com (2603:10b6:300:42::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Thu, 16 Jun 2022 17:03:51 +0000 Received: from DM3NAM02FT020.eop-nam02.prod.protection.outlook.com (2603:10b6:5:177:cafe::63) by DM6PR02CA0059.outlook.office365.com (2603:10b6:5:177::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15 via Frontend Transport; Thu, 16 Jun 2022 17:03:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT020.mail.protection.outlook.com (10.13.4.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Thu, 16 Jun 2022 17:03:50 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 16 Jun 2022 18:03:49 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 16 Jun 2022 18:03:49 +0100 Envelope-to: kalesh-anakkur.purayil@broadcom.com, ajit.khaparde@broadcom.com, dev@dpdk.org Received: from [172.21.34.28] (port=27211) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o1suL-0004hm-5R; Thu, 16 Jun 2022 18:03:49 +0100 Message-ID: <82e65d9f-7b5f-25de-65db-6d3f2f67fe27@xilinx.com> Date: Thu, 16 Jun 2022 18:03:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD Content-Language: en-US To: Kalesh A P CC: , References: <20220615145703.6613-1-kalesh-anakkur.purayil@broadcom.com> <20220615145703.6613-5-kalesh-anakkur.purayil@broadcom.com> From: Ferruh Yigit In-Reply-To: <20220615145703.6613-5-kalesh-anakkur.purayil@broadcom.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1670836f-e5d4-486b-cff8-08da4fba2fe6 X-MS-TrafficTypeDiagnostic: MWHPR02MB2558:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ROkLPkMIyIEmIaIoMPV3J7V9l2o4PKSta00PA7/AUbw6e8Lg+Ke3Goid+UlmoUSDmKvdfrZmUf1PNze1q1oOSl1vSN4wN247v4/mRHDpwJe3GT/N2B2U6oGd0/9Aqt0HwIKX7v+pW617981vy0z8kJLAWQlaPRuK8HREuAPu0W4HQgNNROB2Li7yyUf2MV++bM8zF/OhXGOLHVRzeblLk1tTuVR/WbK6Y2ypWfHKN1YI/1Khcma2WpMmfXtZPscRCGkJdpdMeenftDz0eigMVNAH/ogdzBYBH1u2LjLQ3j1HJmQSalZRqoRxhTx/Ur13eZc47+CchGxOrw5E04fIPoMz3LJ9ZhKcpDOZ8WmP4HhumD1yg0l3R8nHxSW2TjXdfvJk8LLCLer3iTMM7B7FiK4W6PCcIKAEq4DRrPfJJEnXjgM7i5T4qHRMzR5jRO+TcBy3lwFLWz5F2SfLZaBihDqvsouQ+jEmXtpr/lstXy1Fc0qO4sT9zD2OyZ9QfM7jgeFywSmqcXfZxiBxXo5CGAfnBBs20PpOwHihwASC9fY4ditDI8QuA6xWHcH9vOma2t2wnGG0KnGlcelYFjj4xGxqwcJR+IOgusLjrk7fpEYI6JELnergEmvUmw+qOTh7sNPwGzv55hn24ssqUNeU9OjA4IUjjc61soCpt57NIcfKv6d211rhAIBs3C/+FK8KD1ft8TuTju79PSmCLW0f90P2zaBW8B5eNIZaq4jwf4Y= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(36840700001)(40470700004)(46966006)(7636003)(426003)(336012)(44832011)(2906002)(36756003)(9786002)(31686004)(8936002)(2616005)(508600001)(5660300002)(6916009)(70586007)(70206006)(54906003)(316002)(31696002)(4326008)(53546011)(186003)(356005)(47076005)(36860700001)(83380400001)(82310400005)(8676002)(26005)(40460700003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 17:03:50.9545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1670836f-e5d4-486b-cff8-08da4fba2fe6 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2558 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/15/2022 3:56 PM, Kalesh A P wrote: > > From: Damodharam Ammepalli > > Currently, we fail the init/probe of pmd if eth_dev->data->nb_tx_queues > or eth_dev->data->nb_rx_queues is 0. We are removing this check. > Is there a valid usecase for Rx only or Tx only config? I assume testpmd doesn't support it, how are you testing this? > Fixes: daef48efe5e5 ("net/bnxt: support set MTU") > Cc: stable@dpdk.org > > Signed-off-by: Damodharam Ammepalli > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur > --- > drivers/net/bnxt/bnxt_ethdev.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 34f2149..8181e1f 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp) > sizeof(struct bnxt_ring_stats) * > bp->tx_cp_nr_rings, > 0); > - if (bp->prev_tx_ring_stats == NULL) > + if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL) > goto error; > > return 0; > @@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) > int vlan_mask = 0; > int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; > > - if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) { > - PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); > - return -EINVAL; > - } > - > if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) > PMD_DRV_LOG(ERR, > "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", > -- > 2.10.1 >