Like for other Arm chips, the 'soc' entry is also needed. Fixes: fddbe822c3eb ("config/arm: add Qualcomm") Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> --- config/arm/meson.build | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 22cd81319c06..83df190343b1 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -298,6 +298,13 @@ soc_octeontx2 = { 'numa': false } +soc_qualcomm = { + 'description': 'Qualcomm', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_stingray = { 'description': 'Broadcom Stingray', 'implementer': '0x41', @@ -334,6 +341,7 @@ socs = { 'n1sdp': soc_n1sdp, 'n2': soc_n2, 'octeontx2': soc_octeontx2, + 'qualcomm': soc_qualcomm, 'stingray': soc_stingray, 'thunderx2': soc_thunderx2, 'thunderxt88': soc_thunderxt88 -- 2.29.2
28/04/2021 18:08, Thierry Herbelot:
> Like for other Arm chips, the 'soc' entry is also needed.
>
> Fixes: fddbe822c3eb ("config/arm: add Qualcomm")
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Is there any testing of this platform?
<snip> > Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers > > 28/04/2021 18:08, Thierry Herbelot: > > Like for other Arm chips, the 'soc' entry is also needed. > > > > Fixes: fddbe822c3eb ("config/arm: add Qualcomm") > > > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> > > Is there any testing of this platform? I do run DPDK on this platform. I think we should support it for some more time. >
On 4/28/21 8:21 PM, Honnappa Nagarahalli wrote: > <snip> > >> Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers >> >> 28/04/2021 18:08, Thierry Herbelot: >>> Like for other Arm chips, the 'soc' entry is also needed. >>> >>> Fixes: fddbe822c3eb ("config/arm: add Qualcomm") >>> >>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> >> >> Is there any testing of this platform? > I do run DPDK on this platform. I think we should support it for some more time. We also run DPDK on these machines. Thierry -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware
On Wed, Apr 28, 2021 at 6:09 PM Thierry Herbelot <thierry.herbelot@6wind.com> wrote: > > Like for other Arm chips, the 'soc' entry is also needed. Please spare some time to explain the reason why it is needed. > > Fixes: fddbe822c3eb ("config/arm: add Qualcomm") This is not the right Fixes: line, since the soc notion in config/arm/ is fairly recent. Probably: Fixes: f2340c858046 ("config/arm: add platform config option") We have a list of supported socs in doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst. It is already out of sync, I sent a fix for this. For now, please add this soc in the documentation. -- David Marchand
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration. Fixes: f2340c858046 ("config/arm: add platform config option") Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 22cd81319c06..4518b7e877b3 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -298,6 +298,13 @@ soc_octeontx2 = { 'numa': false } +soc_qualcomm = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_stingray = { 'description': 'Broadcom Stingray', 'implementer': '0x41', @@ -334,6 +341,7 @@ socs = { 'n1sdp': soc_n1sdp, 'n2': soc_n2, 'octeontx2': soc_octeontx2, + 'qualcomm': soc_qualcomm, 'stingray': soc_stingray, 'thunderx2': soc_thunderx2, 'thunderxt88': soc_thunderxt88 -- 2.29.2
> -----Original Message----- > From: Thierry Herbelot <thierry.herbelot@6wind.com> > Sent: Thursday, April 29, 2021 10:07 AM > To: dev@dpdk.org > Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon > <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa > Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang > <ruifeng.wang@arm.com> > Subject: [PATCH-V2] config/arm: restore support for Qualcomm servers > > From the documentation: > "The SoC configuration is a combination of implementer and CPU part number > configuration and SoC-specific configuration." > > Align Qualcomm SoC configuration with the configuration of other server SoCs > (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer > configuration. > > Fixes: f2340c858046 ("config/arm: add platform config option") > Since this is just adding new soc configuration, I don't think it's actually fixing anything. > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> > -- > V2: > - use the right original commit in Fixes > --- > config/arm/meson.build | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 22cd81319c06..4518b7e877b3 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -298,6 +298,13 @@ soc_octeontx2 = { > 'numa': false > } > > +soc_qualcomm = { > + 'description': 'Qualcomm Centriq 2400', > + 'implementer': '0x51', > + 'part_number': '0xc00', > + 'numa': false > +} > + > soc_stingray = { > 'description': 'Broadcom Stingray', > 'implementer': '0x41', > @@ -334,6 +341,7 @@ socs = { > 'n1sdp': soc_n1sdp, > 'n2': soc_n2, > 'octeontx2': soc_octeontx2, > + 'qualcomm': soc_qualcomm, Now that I'm looking at this change, I see that you've added the qualcomm soc here and it's not added to the docs in this patch, but rather the patch which fixes the docs. I think you should move the qualcomm doc addition to this patch (and the other patch would just have the fixes). > 'stingray': soc_stingray, > 'thunderx2': soc_thunderx2, > 'thunderxt88': soc_thunderxt88 > -- > 2.29.2 >
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration. Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 ++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 9 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 22cd81319c06..4518b7e877b3 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -298,6 +298,13 @@ soc_octeontx2 = { 'numa': false } +soc_qualcomm = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_stingray = { 'description': 'Broadcom Stingray', 'implementer': '0x41', @@ -334,6 +341,7 @@ socs = { 'n1sdp': soc_n1sdp, 'n2': soc_n2, 'octeontx2': soc_octeontx2, + 'qualcomm': soc_qualcomm, 'stingray': soc_stingray, 'thunderx2': soc_thunderx2, 'thunderxt88': soc_thunderxt88 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index 3e170436cd4f..5513948c9037 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -211,6 +211,7 @@ Substitute <target_soc> with one of the supported SoCs:: n1sdp: Arm Neoverse N1SDP n2: Arm Neoverse N2 octeontx2: Marvell OCTEON TX2 + qualcomm: Qualcomm Centriq 2400 stingray: Broadcom Stingray thunderx2: Marvell ThunderX2 T99 thunderxt88: Marvell ThunderX T88 -- 2.29.2
> -----Original Message----- > From: Thierry Herbelot <thierry.herbelot@6wind.com> > Sent: Thursday, April 29, 2021 11:23 AM > To: dev@dpdk.org > Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon > <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa > Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang > <ruifeng.wang@arm.com> > Subject: [PATCH-V3] config/arm: restore support for Qualcomm servers > > From the documentation: > "The SoC configuration is a combination of implementer and CPU part number > configuration and SoC-specific configuration." > > Align Qualcomm SoC configuration with the configuration of other server SoCs > (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer > configuration. > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> > -- > V3: > - include doc patch > - remove Fixes line > V2: > - use the right original commit in Fixes > --- > config/arm/meson.build | 8 ++++++++ > doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 22cd81319c06..4518b7e877b3 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -298,6 +298,13 @@ soc_octeontx2 = { > 'numa': false > } > > +soc_qualcomm = { > + 'description': 'Qualcomm Centriq 2400', > + 'implementer': '0x51', > + 'part_number': '0xc00', > + 'numa': false > +} > + > soc_stingray = { > 'description': 'Broadcom Stingray', > 'implementer': '0x41', > @@ -334,6 +341,7 @@ socs = { > 'n1sdp': soc_n1sdp, > 'n2': soc_n2, > 'octeontx2': soc_octeontx2, > + 'qualcomm': soc_qualcomm, > 'stingray': soc_stingray, > 'thunderx2': soc_thunderx2, > 'thunderxt88': soc_thunderxt88 > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > index 3e170436cd4f..5513948c9037 100644 > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > @@ -211,6 +211,7 @@ Substitute <target_soc> with one of the supported > SoCs:: > n1sdp: Arm Neoverse N1SDP > n2: Arm Neoverse N2 > octeontx2: Marvell OCTEON TX2 > + qualcomm: Qualcomm Centriq 2400 Now that I think about it, 'qualcomm' isn't a suitable name for an soc, as it's the name of the company, not the soc. The description says this is the Centriq 2400 soc, so I suggest renaming it to that (qualcomm -> centriq2400 and soc_qualcomm -> soc_centriq2400 or something similar). > stingray: Broadcom Stingray > thunderx2: Marvell ThunderX2 T99 > thunderxt88: Marvell ThunderX T88 > -- > 2.29.2 >
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration. Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 ++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 9 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 22cd81319c06..162a19e0a383 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -223,6 +223,13 @@ soc_bluefield = { 'numa': false } +soc_centriq2400 = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_cn10k = { 'description' : 'Marvell OCTEON 10', 'implementer' : '0x41', @@ -325,6 +332,7 @@ socs = { 'generic': soc_generic, 'armada': soc_armada, 'bluefield': soc_bluefield, + 'centriq2400': soc_centriq2400, 'cn10k' : soc_cn10k, 'dpaa': soc_dpaa, 'emag': soc_emag, diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index 3e170436cd4f..90f6472780d7 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -202,6 +202,7 @@ Substitute <target_soc> with one of the supported SoCs:: generic: Generic un-optimized build for all aarch64 machines. armada: Marvell ARMADA bluefield: NVIDIA BlueField + centriq2400: Qualcomm Centriq 2400 cn10k: Marvell OCTEON 10 dpaa: NXP DPAA emag: Ampere eMAG -- 2.29.2
> -----Original Message----- > From: Thierry Herbelot <thierry.herbelot@6wind.com> > Sent: Thursday, April 29, 2021 6:07 PM > To: dev@dpdk.org > Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net; > Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang > <Ruifeng.Wang@arm.com> > Subject: [PATCH-V4] config/arm: restore support for Qualcomm servers > > From the documentation: > "The SoC configuration is a combination of implementer and CPU part > number configuration and SoC-specific configuration." > > Align Qualcomm SoC configuration with the configuration of other server > SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing > implementer configuration. > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> > -- > V4: > - use a more specific SoC name > V3: > - include doc patch > - remove Fixes line > V2: > - use the right original commit in Fixes > --- > config/arm/meson.build | 8 ++++++++ > doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 22cd81319c06..162a19e0a383 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -223,6 +223,13 @@ soc_bluefield = { > 'numa': false > } > > +soc_centriq2400 = { > + 'description': 'Qualcomm Centriq 2400', > + 'implementer': '0x51', > + 'part_number': '0xc00', > + 'numa': false > +} > + > soc_cn10k = { > 'description' : 'Marvell OCTEON 10', > 'implementer' : '0x41', > @@ -325,6 +332,7 @@ socs = { > 'generic': soc_generic, > 'armada': soc_armada, > 'bluefield': soc_bluefield, > + 'centriq2400': soc_centriq2400, > 'cn10k' : soc_cn10k, > 'dpaa': soc_dpaa, > 'emag': soc_emag, > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > index 3e170436cd4f..90f6472780d7 100644 > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > @@ -202,6 +202,7 @@ Substitute <target_soc> with one of the supported > SoCs:: > generic: Generic un-optimized build for all aarch64 machines. > armada: Marvell ARMADA > bluefield: NVIDIA BlueField > + centriq2400: Qualcomm Centriq 2400 There is a patch to improve documentation: http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/ May be you can make your patch based on that one. Thanks. > cn10k: Marvell OCTEON 10 > dpaa: NXP DPAA > emag: Ampere eMAG > -- > 2.29.2
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration. Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/ V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index fbe942e5ec97..2f0ed2fe9428 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -223,6 +223,13 @@ soc_bluefield = { 'numa': false } +soc_centriq2400 = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_cn10k = { 'description' : 'Marvell OCTEON 10', 'implementer' : '0x41', @@ -327,6 +334,7 @@ soc_thunderxt88 = { # generic: Generic un-optimized build for all aarch64 machines. # armada: Marvell ARMADA # bluefield: NVIDIA BlueField +# centriq2400: soc_centriq2400, # cn10k: Marvell OCTEON 10 # dpaa: NXP DPAA # emag: Ampere eMAG @@ -344,6 +352,7 @@ socs = { 'generic': soc_generic, 'armada': soc_armada, 'bluefield': soc_bluefield, + 'centriq2400': soc_centriq2400, 'cn10k' : soc_cn10k, 'dpaa': soc_dpaa, 'emag': soc_emag, -- 2.29.2
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, April 29, 2021 5:16 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>
> Subject: [PATCH-V5] config/arm: restore support for Qualcomm servers
>
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part number
> configuration and SoC-specific configuration."
>
> Align Qualcomm SoC configuration with the configuration of other server SoCs
> (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer
> configuration.
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration. Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V6: - rebase after merge of "doc: fix Arm SoCs list" V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/ V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 65f7ac672def..c68ea24f312f 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -223,6 +223,13 @@ soc_bluefield = { 'numa': false } +soc_centriq2400 = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_cn10k = { 'description' : 'Marvell OCTEON 10', 'implementer' : '0x41', @@ -326,6 +333,7 @@ Start of socs list generic: Generic un-optimized build for all aarch64 machines. armada: Marvell ARMADA bluefield: NVIDIA BlueField +centriq2400: Qualcomm Centriq 2400 cn10k: Marvell OCTEON 10 dpaa: NXP DPAA emag: Ampere eMAG @@ -346,6 +354,7 @@ socs = { 'generic': soc_generic, 'armada': soc_armada, 'bluefield': soc_bluefield, + 'centriq2400': soc_centriq2400, 'cn10k' : soc_cn10k, 'dpaa': soc_dpaa, 'emag': soc_emag, -- 2.29.2
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, May 6, 2021 5:26 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
> Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Subject: [PATCH-V6] config/arm: restore support for Qualcomm servers
>
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part
> number configuration and SoC-specific configuration."
>
> Align Qualcomm SoC configuration with the configuration of other server
> SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
> implementer configuration.
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V6:
> - rebase after merge of "doc: fix Arm SoCs list"
> V5:
> - rebase after
> http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-
> david.marchand@redhat.com/
> V4:
> - use a more specific SoC name
> V3:
> - include doc patch
> - remove Fixes line
> V2:
> - use the right original commit in Fixes
> ---
> config/arm/meson.build | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 65f7ac672def..c68ea24f312f 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -223,6 +223,13 @@ soc_bluefield = {
> 'numa': false
> }
>
> +soc_centriq2400 = {
> + 'description': 'Qualcomm Centriq 2400',
> + 'implementer': '0x51',
> + 'part_number': '0xc00',
> + 'numa': false
> +}
> +
> soc_cn10k = {
> 'description' : 'Marvell OCTEON 10',
> 'implementer' : '0x41',
> @@ -326,6 +333,7 @@ Start of socs list
> generic: Generic un-optimized build for all aarch64 machines.
> armada: Marvell ARMADA
> bluefield: NVIDIA BlueField
> +centriq2400: Qualcomm Centriq 2400
> cn10k: Marvell OCTEON 10
> dpaa: NXP DPAA
> emag: Ampere eMAG
> @@ -346,6 +354,7 @@ socs = {
> 'generic': soc_generic,
> 'armada': soc_armada,
> 'bluefield': soc_bluefield,
> + 'centriq2400': soc_centriq2400,
> 'cn10k' : soc_cn10k,
> 'dpaa': soc_dpaa,
> 'emag': soc_emag,
> --
> 2.29.2
I believe a meson cross file is also needed. The cross file consumes defined soc info.
Please check other cross files in config/arm for reference.
> -----Original Message----- > From: Ruifeng Wang <Ruifeng.Wang@arm.com> > Sent: Friday, May 7, 2021 9:23 AM > To: Thierry Herbelot <thierry.herbelot@6wind.com>; dev@dpdk.org > Cc: thomas@monjalon.net; Juraj Linkeš <juraj.linkes@pantheon.tech>; > Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com> > Subject: RE: [PATCH-V6] config/arm: restore support for Qualcomm servers > In addition to Ruifeng's cross file addition, I'd also change the subject to something like "config/arm: add Qualcomm Centriq 2400 SoC config" which is more accurate (add instead of restore and the patch only adds support for one server, not multiple). > I believe a meson cross file is also needed. The cross file consumes defined soc > info. > Please check other cross files in config/arm for reference.
From the documentation: "The SoC configuration is a combination of implementer and CPU part number configuration and SoC-specific configuration." Align Qualcomm SoC configuration with the configuration of other server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer configuration, and a cross file. Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> -- V7: - use a more specific subject - add a cross file V6: - rebase after merge of "doc: fix Arm SoCs list" V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/ V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/arm64_centriq2400_linux_gcc | 16 ++++++++++++++++ config/arm/meson.build | 9 +++++++++ 2 files changed, 25 insertions(+) create mode 100644 config/arm/arm64_centriq2400_linux_gcc diff --git a/config/arm/arm64_centriq2400_linux_gcc b/config/arm/arm64_centriq2400_linux_gcc new file mode 100644 index 000000000000..dfe911033196 --- /dev/null +++ b/config/arm/arm64_centriq2400_linux_gcc @@ -0,0 +1,16 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +platform = 'centriq2400' diff --git a/config/arm/meson.build b/config/arm/meson.build index 65f7ac672def..c68ea24f312f 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -223,6 +223,13 @@ soc_bluefield = { 'numa': false } +soc_centriq2400 = { + 'description': 'Qualcomm Centriq 2400', + 'implementer': '0x51', + 'part_number': '0xc00', + 'numa': false +} + soc_cn10k = { 'description' : 'Marvell OCTEON 10', 'implementer' : '0x41', @@ -326,6 +333,7 @@ Start of socs list generic: Generic un-optimized build for all aarch64 machines. armada: Marvell ARMADA bluefield: NVIDIA BlueField +centriq2400: Qualcomm Centriq 2400 cn10k: Marvell OCTEON 10 dpaa: NXP DPAA emag: Ampere eMAG @@ -346,6 +354,7 @@ socs = { 'generic': soc_generic, 'armada': soc_armada, 'bluefield': soc_bluefield, + 'centriq2400': soc_centriq2400, 'cn10k' : soc_cn10k, 'dpaa': soc_dpaa, 'emag': soc_emag, -- 2.29.2
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Friday, May 7, 2021 4:48 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
> Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Subject: [PATCH-V7] config/arm: add Qualcomm Centriq 2400 SoC config
>
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part
> number configuration and SoC-specific configuration."
>
> Align Qualcomm SoC configuration with the configuration of other server
> SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
> implementer configuration, and a cross file.
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V7:
> - use a more specific subject
> - add a cross file
> V6:
> - rebase after merge of "doc: fix Arm SoCs list"
> V5:
> - rebase after
> http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-
> david.marchand@redhat.com/
> V4:
> - use a more specific SoC name
> V3:
> - include doc patch
> - remove Fixes line
> V2:
> - use the right original commit in Fixes
> ---
> config/arm/arm64_centriq2400_linux_gcc | 16 ++++++++++++++++
> config/arm/meson.build | 9 +++++++++
> 2 files changed, 25 insertions(+)
> create mode 100644 config/arm/arm64_centriq2400_linux_gcc
>
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > From the documentation:
> > "The SoC configuration is a combination of implementer and CPU part
> > number configuration and SoC-specific configuration."
> >
> > Align Qualcomm SoC configuration with the configuration of other server
> > SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
> > implementer configuration, and a cross file.
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied, thanks