From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71EC0A0511; Fri, 8 Apr 2022 04:35:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B7C14067E; Fri, 8 Apr 2022 04:35:48 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by mails.dpdk.org (Postfix) with ESMTP id 0B1934003F for ; Fri, 8 Apr 2022 04:35:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJC56ORk4tMSoEqFmFrPMvnX1XBT3ZrfrqgLNpVIm6Vbp0YL/ew1aOtkdpc9RYDin+u/dtqtI1tzW0wBMaAcwkNLyhUfVgZRHvGkO36zv4hn69iCMferzDXstkOTQiTHsSBnhMDl37Kpushav6b6LXic/P+mxNdRlXZSY1N6hZEKxbLajvszzwwynCRRKLbtpjobG4ohr9naV44dFQur/NRzHxwWB0QfsQtMil1CsGRIKq6CkySrPhd8ZyaDI6ZrvjWSEqEIjQ6z2F92mAMARcts6VhwFNblb3tYLkTz2WNaZqLuy7RgofFE3otvo+l0iVmq5ynbhZodLMbEnLikkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mwC56C1j4R4xEIiZuNOtzQNiIokiq1LQw+u3HkiN35w=; b=hseyrBUmYawXlF69GPpqI/D9MXSS5FJAHXEYDpcV5KECZWJfzYrAsEFZF9nk/H+JfWJP83r7vIIGaVKGWMNPqEbBdlSSP+RHhit4nqkVvV9CjcqW0EIoJPV3QsStxKXPGkxfFBXn6vsRY9hpGQEqlP1q1YDtfYMZhhXRFeVIfbCev9AYcsbL8e8OhL7eR5s9fhcm82mpLXNbvjY2YqFjl9ip6ZkxuhsY4aDBE3qMPjaRa4QOcb/u4lQHUjgc/09IMxbUumUT8T9EE2ii8EySaVJSg1e7VzB0W816IZGY/QnvutM69FGIGSBCrLTUz1SPrtBUmj1b434/G3N6hE4A/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwC56C1j4R4xEIiZuNOtzQNiIokiq1LQw+u3HkiN35w=; b=aTb46RgTa2TpZvZKtO6Mrua/6dIuSpt9+WN/XyEQr/2urrbXs/p62x+jgt9Wk/guMajR5wpmo/Kul/T3ls/8rJCfoCPSeaZDc6cF/3DXD7zC0jhOsb8Qm3DFvaEQTxEwB7PAadV2cXq+KPQhAB/wDyytGfJuCPTAfsiH43QKUvPv2N+ahb9Wr2hX6tyozzdnAYQvUcehRfYIZ9i9+1B5rxzJpPg4DbKczsAJ2DYvhswjMU8lunj/FcBlXhu/jJaldAdmxWh2WqnVgImHxfnp48L+mHNecjL9CoaAXBQ8bz+BDvq7QHcek3sMn1RNaiMO+Vl7yrWNu5hKx0sVkw5W6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CO6PR12MB5459.namprd12.prod.outlook.com (2603:10b6:303:13b::16) by BN6PR1201MB0147.namprd12.prod.outlook.com (2603:10b6:405:56::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Fri, 8 Apr 2022 02:35:42 +0000 Received: from CO6PR12MB5459.namprd12.prod.outlook.com ([fe80::c819:1efc:65dd:196f]) by CO6PR12MB5459.namprd12.prod.outlook.com ([fe80::c819:1efc:65dd:196f%6]) with mapi id 15.20.5144.026; Fri, 8 Apr 2022 02:35:42 +0000 Content-Type: multipart/alternative; boundary="------------8H8t0f9HHCwJji7P28yBU1FT" Message-ID: <82fe43d5-0c6f-efae-dc9f-da7ffb88f882@nvidia.com> Date: Fri, 8 Apr 2022 10:35:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints Content-Language: en-US To: Stephen Hemminger Cc: Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org References: <20220407080428.619f5791@hermes.local> From: Jack Min In-Reply-To: <20220407080428.619f5791@hermes.local> X-ClientProxiedBy: HK2PR03CA0046.apcprd03.prod.outlook.com (2603:1096:202:17::16) To CO6PR12MB5459.namprd12.prod.outlook.com (2603:10b6:303:13b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18ae90c7-15a4-46a2-ccfe-08da190879cc X-MS-TrafficTypeDiagnostic: BN6PR1201MB0147:EE_ X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TrBG/moJ0M2Vrsca+5EmUotYC+1QvLTqCPE/lJf6S+AWdP5pMyLeAZPXkfUgA7g8/JN7TBQtefqMW9dw/Zzhr25nUTCnzW4u7hSC56GrdSiJqIcOwZV77mGmRAjgWC3XeBQ1uZnxXFo8E7NtfQ4Un11Bk/dEM/EfsCie7pYVjHVVHBDCGSjxfNlLINZDKeD4VS5Ta5N0exy37uDo4cyjZ+OFjYFLbd5sB8mks+P1qT0WEo6daZcSPBmYE8kyGQ075YsZAXuE1X3u8VIxoGM0K/CbQb7xcp+opvKdo8Zet0S0FhWoj29bnh+6kAzWp8zezBbqeWyDA3i/NbWlqLOl2N8aBVsSJYFGyQFHyRYV17dOM/h9YbA3veHmZIeXQJRz5c/Td5uBk0FclY9ovNKFJJbB6i3CQ10SlieiPd0Sc+t5NAaPok3ce4CSwR/y630Nosj4CK/Uk53yprN9qBCIGx/L4tNW6Jo9KGHSvpYGo/LU78Bm0EZpRQ2IznXQM0yftfsftmWWk9stwuucMD8peySJFVna6vxE6gSS2fstLJ32UWr2DS43lH8XOn2l6oe3VQupYwsOan1/vNBCU5OIVoAr9UTK04FwbnkMUm47bM5fNoYTFSQuwVqhyhuo/HY5kTMcoRC8vWYfUf3Bte/Kov/XiylvvFI/T4thSjo7N08gOhT+y8LfGAaE1fgEzXLZrqiy2wYgbjqiNZjocMMPDJLLjhTT+6IO7Lr7ZwEPQOA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5459.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(4326008)(36756003)(508600001)(186003)(316002)(66946007)(31686004)(66476007)(54906003)(6916009)(66556008)(8676002)(53546011)(6506007)(8936002)(2616005)(2906002)(86362001)(5660300002)(6486002)(31696002)(33964004)(6666004)(6512007)(38100700002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnRYVDRvVXV5RDJvaDlNUmt2YlFZU2VsUlpmQUd3OWJUbDVsZkZxbWgxNnN2?= =?utf-8?B?bGUyS1o2Q1UwZ09jSFgwclJtdHlVS0VIMmR5WTJZaWFEV3gwSWVUc3RmbGgw?= =?utf-8?B?OC8xTS9IZ3pUR1FiK2tmaDIyU0Vac05reE95elBzTXIrdzg3eExqYlZLUU4x?= =?utf-8?B?ZTNqT1psZ290dk00VXB4d1pBL3dmR2M5VEpwOVRIcXpZaTU1UlFVakRGRmlT?= =?utf-8?B?Ry9jZWdIUG5GYlA3Y0FEcHMyRFd2YXRFMTYxZDN2N0l3ZEcyTEltTHE2WGpo?= =?utf-8?B?OWRoaHNtajZXZUhkZ0tDMmRTbW1HTTMwcGlvRURDeThYQ3RqbVpGRVlRWWwr?= =?utf-8?B?OWdjTzJEc1U0aXJ6UlVidU5HZ2I3VnJNRjh0NXVadFh3b3R0TGRNOHVjNkRP?= =?utf-8?B?V3R3SlZvUHk3aDBwY1BydnRZd0ErRjhhVjV5QURBQm9ISVEwbE1SUUU2NGVG?= =?utf-8?B?MWJWdUVhMmF6cGphdVNDOVNaRWljUlo0WmwrZUwwU1NQQld6MEphbzBGdW1w?= =?utf-8?B?Njk3Zm94ZTJFbWlpbGZ5My85Qk16WVRlWE9XV25yeklhQXpCT2pIY1padmxO?= =?utf-8?B?LzArM2JVQllRRDVUa25mNDNZTG9aWW42VUJxQXRra1NSVTJmRTJPVWFxV3ov?= =?utf-8?B?VGxZYzVTZTB5Q1o4dlZTUWN6aTdOMXh3OCsyZUZRRzlybWFaV3VkakJvL3Js?= =?utf-8?B?OHNZRElkQjNTM2svUjNINmFpWUlKdzZTYlUwVWh2d0Rjb2tYdllqWE93Nk1F?= =?utf-8?B?SWs0Vjl4ZGNBdHVYYmdkVFlZZkNhQVQ5eHZrdDRDdjVURnhlMEZxcWZacFp5?= =?utf-8?B?eVdHek8xM0F3a3JES2xDV0hndlVsSEo4ZXhLcXMzZDlkb1pHcitvbWJzYVY3?= =?utf-8?B?emJzRmcvYmI1ejhFSHVhajNrRGN1c3BkT2ViRzQ0Z0diQm1BS0xVbWlLK2tO?= =?utf-8?B?d3d1K0tocWdpQ2RDY0NRR3A4ekRLWC8vU0dnZXE1SUtDY2hMcVJzcWppVE1L?= =?utf-8?B?ZG81d1IybmczOEdoaDNtUVVpZjV4ZFI1QnpJL0J6MlhrUlUra21sNjZ6UkRC?= =?utf-8?B?eUVPWUFtZVR1a0M3aWFocDdkTEtEdm9tUkJNWTcvM2xMcTVxUklBcWdlMkZD?= =?utf-8?B?TzhCWUF0cElWcEF2YUtjWUNBbFY3Tmk5TnBuZjZLYm8xYnZYN005RUZQTXg1?= =?utf-8?B?RVJOODBzbXNtNGtoVW9yVWdTK1UwYUpKYWUwQ2NTeHZyU2E4UWRuRG1zKzhG?= =?utf-8?B?Z3BPN21DMUFUMC9pdC9PWDlRejVmaU5OTkpaNk55U1M2SnRkbVVVQTd3d3hu?= =?utf-8?B?STNkMkpTMmVQQlFVYk51RTBBZGFyVVVZQ0xmWE4yc2ZrYTBQdnc2cTdldnZ5?= =?utf-8?B?cm5VelpnT2FlLzNCbzdhWkJod3pVcUk3T2JqUnQ1dmhYc3hoNUhEd29teU1Y?= =?utf-8?B?c1JhRDE5VDFYVkVIMk5SOG1LUmhZVUZTVkJkWGVab1djc3NSaVRhZlFLbHdB?= =?utf-8?B?YVBhcHBDelpreXFQSnJVWGxHdTcvdlQxL0xOWnVWT3drSEVyYXFham9TNHVT?= =?utf-8?B?L1h6L1ozc3l3c3R5ZmN1c1VqNFNyM2cxS3JUYmY5L1dhMWs0S2NzVDRlbW1y?= =?utf-8?B?SFU4UTFGcjhRRU5yc0JJWE5KYlczeXFEMGhqZ2I4NDd4emIxWFFwZnNXYkJY?= =?utf-8?B?RkVCcnFYaDFmd3FyaHhVQlQzOG9yUWJLSXFqVHdoak1Iamt6d2hJN05Pc3ZE?= =?utf-8?B?SmZqZ0xLVEtTNDVtanVSQ0lORzFNQWpJem9iNmw1T1NQN3B6ZE9SY1JGUGNV?= =?utf-8?B?VTl1YWppSThDTjdNUHQ5OGwxTTBDN1AyZUFpTmJjbHdMMmQvRUV5aTBBekVy?= =?utf-8?B?VFhpaEM5YXNzNzNSWkl0c2d5MEtCbEZuZEZENDJVV1ZkTDhVK3pZdE1ldGIw?= =?utf-8?B?T3VRYTBGdjQweWY4ZUlNc29uTFlDM3QxMERYUTVPSFBHdWdxT2hVV2thK0do?= =?utf-8?B?Z3JSdExSOE40M2c0aTNPM1J0VVhCaW5yN0lGbEJ3TlFzVEo4dExGYWdDUzZB?= =?utf-8?B?c2hUdVl4ZEV2aWk0RTBFR2I0L0JTY0l5NnBPV1FjTE1UZUlKOVhRWWJIWjVW?= =?utf-8?B?Tk9oTmkwTFlkMXIxY0tKYXZ2MUVjT1VZc2lXVTFWck5rRTlIZ3kwYkdpRy9O?= =?utf-8?B?Q1ZtV0ZtSHpPMTMybWVHNEN5b21NT0Jyek1VeDhGUDZxNktGb01QeDdYRDBO?= =?utf-8?B?MldWd010bVRUTDhKM2VDYjkrRDV2VU1lRHpveEN6eE9CVXBQMDlmdkxsd1RY?= =?utf-8?B?Sit3aXo4UTI5a1BDeCt5Y3VBZUVnZjNDWTVBaWVmNFZLblYycHJWdz09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18ae90c7-15a4-46a2-ccfe-08da190879cc X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5459.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 02:35:42.1337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AWqO6Y6ORkvxCdIiuUoS6JlghCJDWPlGfzv5ZumIrWacf7k3W1LL3WWSHbLX++nq3/O2xu627/jcpG5NyLuljw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0147 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------8H8t0f9HHCwJji7P28yBU1FT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/7/22 23:04, Stephen Hemminger wrote: > On Thu, 7 Apr 2022 13:30:46 +0800 > Xiaoyu Min wrote: > >> * @b EXPERIMENTAL: this API may change without prior notice. >> @@ -4972,6 +4983,11 @@ struct rte_flow_port_attr { >> * @see RTE_FLOW_ACTION_TYPE_METER >> */ >> uint32_t nb_meters; >> + /** >> + * Port flags. >> + * @see enum rte_flow_port_flag >> + */ >> + enum rte_flow_port_flag flags; > This would have to wait until 22.11 because it is ABI breakage. > Also, how would this work with old users of API? I'm not familiar with DPKD API/ABI policy, But as my understanding this one is marked as _experimental_ and also all related APIs The experimental is not considered as part of ABI, and we can change them anytime, no? --------------8H8t0f9HHCwJji7P28yBU1FT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 4/7/22 23:04, Stephen Hemminger wrote:
On Thu, 7 Apr 2022 13:30:46 +0800
Xiaoyu Min <jackmin@nvidia.com> wrote:


  * @b EXPERIMENTAL: this API may change without prior notice.
@@ -4972,6 +4983,11 @@ struct rte_flow_port_attr {
 	 * @see RTE_FLOW_ACTION_TYPE_METER
 	 */
 	uint32_t nb_meters;
+	/**
+	 * Port flags.
+	 * @see enum rte_flow_port_flag
+	 */
+	enum rte_flow_port_flag flags;

This would have to wait until 22.11 because it is ABI breakage.
Also, how would this work with old users of API?

I'm not familiar with DPKD API/ABI policy,

But as my understanding this one is marked as _experimental_ and also all related APIs

The experimental is not considered as part of ABI, and we can change them anytime, no?

--------------8H8t0f9HHCwJji7P28yBU1FT--